Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp1370084pxa; Thu, 13 Aug 2020 07:16:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwlEoiqrBNAlL4sivFdbuLK5krTBDbVaHUk4oT1tqq8uFMp2pjW0dYwTjSuU+Fbir7muaLJ X-Received: by 2002:a05:6402:44e:: with SMTP id p14mr5015727edw.1.1597328186434; Thu, 13 Aug 2020 07:16:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597328186; cv=none; d=google.com; s=arc-20160816; b=AMDTOYIqs/UYWcqkJmEwBLwHgcay6IuaFUyOlBjgwVivLaV6PsqDxP49Z/IH8PeN12 DphwzOLDgQ07DxmCd5ToS0pvF9eJx/iMCfzs+wGcu/mX27jOrd7Mjk6OgIwOZpvMz8yt JvXuBsZ5gCIaWy3ep1LREclyFCIZJ2sS21znPD75EkiyWZytko+ASM4qTlvkQBC3y3td VhbFM6Q1lIU4pprsTqlFh0LURmI2atslC1j1YQ3wlaI7XmemF3jI6xfZhUu2iKCog1zE 3tsNjtety79q8x/tPKC6TW1Y0CkgtNT70eNcGIr9GYtY3nhmwYsfh8+SR7XyvFh/fdu7 IY3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=QZ67+4TF1+uyAhK6trST8Nnpbbd1AlRvus37C/UQLq0=; b=IQSHKZpOAS5GfBiWNuNIp5RQx+u27NHwYv3szezGhNeF7SeO21OeMInkfZg6ZZsr/0 AZ+lR0IaPAkvQfJvDIKQ4CvV6d2iOqLXGefHFvdjXb6AWKaPbcMKok8alJmhGCbRRsse EEtv+UkBefrxmQdtz6jzvosFinZ4uRzbwETeeoeWe76MSVOxibTkWiqG3DlcEhL2BN7e VhCdfoonNSYDA0He6N3B0IRDurdLL0cPALmCS4jE8IjSNvj8lJUQay6UXJRuIFbwn7mQ rUdZuvdy1z2b8Zh8GPR7J0uVg0WvRCzHJyucPKmX9kxVLEoqvF2q5MMRHOInXIYRExs4 Cm1A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z20si3362467edq.490.2020.08.13.07.16.02; Thu, 13 Aug 2020 07:16:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726253AbgHMOP1 (ORCPT + 99 others); Thu, 13 Aug 2020 10:15:27 -0400 Received: from smtp-190a.mail.infomaniak.ch ([185.125.25.10]:43725 "EHLO smtp-190a.mail.infomaniak.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726082AbgHMOP0 (ORCPT ); Thu, 13 Aug 2020 10:15:26 -0400 Received: from smtp-3-0000.mail.infomaniak.ch (unknown [10.4.36.107]) by smtp-3-3000.mail.infomaniak.ch (Postfix) with ESMTPS id 4BS7rT0dsFzlhcWv; Thu, 13 Aug 2020 16:15:21 +0200 (CEST) Received: from ns3096276.ip-94-23-54.eu (unknown [94.23.54.103]) by smtp-3-0000.mail.infomaniak.ch (Postfix) with ESMTPA id 4BS7rN3mlnzlh8T7; Thu, 13 Aug 2020 16:15:16 +0200 (CEST) Subject: Re: [PATCH v20 05/12] LSM: Infrastructure management of the superblock To: Stephen Smalley , Casey Schaufler , Kees Cook , John Johansen Cc: linux-kernel@vger.kernel.org, Al Viro , Andy Lutomirski , Anton Ivanov , Arnd Bergmann , James Morris , Jann Horn , Jeff Dike , Jonathan Corbet , Michael Kerrisk , Richard Weinberger , "Serge E . Hallyn" , Shuah Khan , Vincent Dagonneau , kernel-hardening@lists.openwall.com, linux-api@vger.kernel.org, linux-arch@vger.kernel.org, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-security-module@vger.kernel.org, x86@kernel.org References: <20200802215903.91936-1-mic@digikod.net> <20200802215903.91936-6-mic@digikod.net> <779c290b-45f5-b86c-c573-2edb4004105d@tycho.nsa.gov> From: =?UTF-8?Q?Micka=c3=abl_Sala=c3=bcn?= Message-ID: <03f522c0-414c-434b-a0d1-57c3b17fa67f@digikod.net> Date: Thu, 13 Aug 2020 16:15:01 +0200 User-Agent: MIME-Version: 1.0 In-Reply-To: <779c290b-45f5-b86c-c573-2edb4004105d@tycho.nsa.gov> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Antivirus: Dr.Web (R) for Unix mail servers drweb plugin ver.6.0.2.8 X-Antivirus-Code: 0x100000 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/08/2020 21:16, Stephen Smalley wrote: > On 8/2/20 5:58 PM, Mickaël Salaün wrote: >> From: Casey Schaufler >> >> Move management of the superblock->sb_security blob out >> of the individual security modules and into the security >> infrastructure. Instead of allocating the blobs from within >> the modules the modules tell the infrastructure how much >> space is required, and the space is allocated there. >> >> Signed-off-by: Casey Schaufler >> Reviewed-by: Kees Cook >> Reviewed-by: John Johansen >> Reviewed-by: Stephen Smalley >> Reviewed-by: Mickaël Salaün >> Link: >> https://lore.kernel.org/r/20190829232935.7099-2-casey@schaufler-ca.com >> --- >> >> Changes since v17: >> * Rebase the original LSM stacking patch from v5.3 to v5.7: I fixed some >>    diff conflicts caused by code moves and function renames in >>    selinux/include/objsec.h and selinux/hooks.c .  I checked that it >>    builds but I didn't test the changes for SELinux nor SMACK. > > You shouldn't retain Signed-off-by and Reviewed-by lines from an earlier > patch if you made non-trivial changes to it (even more so if you didn't > test them). I think I made trivial changes according to the original patch. But without reply from other people with Signed-off-by or Reviewed-by (Casey, Kees, John), I'll remove them. I guess you don't want your Reviewed-by to be kept, so I'll remove it, except if you want to review this patch (or the modified part).