Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp1404937pxa; Thu, 13 Aug 2020 07:57:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx4AgbWbz28nmPfjHoTL5lXDDrfVFqGXa4IBBWCBIoBx+BGqoUU5XScLglOuyHHK3ih8OE/ X-Received: by 2002:a05:6402:c85:: with SMTP id cm5mr5167067edb.350.1597330665653; Thu, 13 Aug 2020 07:57:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597330665; cv=none; d=google.com; s=arc-20160816; b=Sz7W3w18mquzlljB3WbQrhCnfHs2hofPve6AInpt0/jyzCKijh7J91mSPAPp5GOG7T g1kF8nVOQgZFrwhqCo0HevLBJRPnkVl57qt060JdMGQz9QOK6BEfX/Vm0pCU9TtvJd/1 E3XGPsqyS65B5w+KUjJaNX3qoQF8Tc3dmYiRVp35eL9fNHdARxvfP57lGZ85AAtp0Srb Ajh0kz4OiC1rm42XZ8xcoknKFwOyjQ6v+MeEcE3w2gpLjaMPQObZrJv/G2h5xCQckq0s QXAj7xu+rUmqvBYsvWcCmoNO75cNMNUphO36Hm9iTpVRxmE85EvWpOiaqOug19APK3/L z14A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=2N3vz3aoKozJuLd8HhRVAVV0+DlbtHXg7rxrCEwGelY=; b=wXbHJE83kitOiV4UCSBHWLSQ2VTbKHhh4Ykpoohqts6XRD62Ebg/byvpGYQrD+mRUN NJD+I7r9wc/rdDQKeKzqMjzAETq+uHt9mU9/7o8h/hOhC5NZMMy8Q0T+Fa013Xji9kaA 66O24i9xND5njZCgzS5S2lBhCkyasv1GjAOOtbvuEH829tEFbaWmhO54CcyAbo8hvRyh oZKjwSRsYjaIEUBcxe45vmHLQqdhvZG1yLHIb699j9gPBuDrJq3O4w4h+rTbBg2i3uB8 TwHZ+fanr7Rc93wSBJzV4M0aj3/IjAy8ovBaiMnnEkiWRm3He+lCffdHNu9vdJy/LVjx jEWg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=2Av2azx9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b3si4333386edn.98.2020.08.13.07.57.21; Thu, 13 Aug 2020 07:57:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=2Av2azx9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726682AbgHMO4f (ORCPT + 99 others); Thu, 13 Aug 2020 10:56:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46582 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726167AbgHMO4e (ORCPT ); Thu, 13 Aug 2020 10:56:34 -0400 Received: from mail-io1-xd43.google.com (mail-io1-xd43.google.com [IPv6:2607:f8b0:4864:20::d43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E4BE6C061757 for ; Thu, 13 Aug 2020 07:56:33 -0700 (PDT) Received: by mail-io1-xd43.google.com with SMTP id a5so7489637ioa.13 for ; Thu, 13 Aug 2020 07:56:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=2N3vz3aoKozJuLd8HhRVAVV0+DlbtHXg7rxrCEwGelY=; b=2Av2azx9MhIvUoXaAZXBnYYlP5YN9u45JAgTOqjgnW9MJlQOpjRtOVGtv6zITH6N20 34yQMx+43blJDN9CwZEFY2EGFBSsba0p7OCFNYfgpJSDFcynpdO0ziqX1zJsENMYMkzE /YFiX8ORzlZ5qq/qP0TrVKNgjawRTN2sOsyMErmwsJ1hspoYM3E2/JB38VF7rRMBQALL RK2riwofKiC7kxl4YkPouojYjjgcZLoi3D7TOPvCuSvY39rCq/W9EkN5PFt1Aul+2Z2O Su1r9y0eBcGqgPhekBoedLpDnYcwNO121jDyo36iJnos86vrInbGyoO/LfAa6EhlqzMT G/pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=2N3vz3aoKozJuLd8HhRVAVV0+DlbtHXg7rxrCEwGelY=; b=F6c6zepeS57aoFdIlKXlRMZBKBfDfnT5uDtJGsI7AUHGCESfwCbBLE8Y8iKW8gHJTN 5gUprkB3yrQEREmIpJRgVvC0NTO/51hCvQ0e5XgCtH/Ohr0HUrOHed9gUcG4UNm3GL8d QLNeXsvPeuUWZsqupM23WkZZtqdRnnOSWHeLvqKlnH74lRVQ6eAsi/ST/ECFgduT29Y8 zthZ1H0nSJ8FspYhnVZSn3a6sIwv1kOJlSmL9CTQdRvJSDD+YDB/jTNDLJbsI6MJDJVL 699aeeacRJfbpYSsP0jZaPwM4ERUTBEYIn2KmWr+xCNRbtBhXWSwhOZLv5doOtrG64Xj Mxfg== X-Gm-Message-State: AOAM5305phj1MD1cJfPBAd1+WsLBlsCQMKLQV/6T/T+G24qo/MKH0d7V hs2VnIf0ZcD2O0+9YEyJKKDS9A== X-Received: by 2002:a02:6d5d:: with SMTP id e29mr5296096jaf.139.1597330591852; Thu, 13 Aug 2020 07:56:31 -0700 (PDT) Received: from [192.168.1.58] ([65.144.74.34]) by smtp.gmail.com with ESMTPSA id l2sm2892965ilt.2.2020.08.13.07.56.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 13 Aug 2020 07:56:31 -0700 (PDT) Subject: Re: [PATCH] fs/io_uring.c: Fix uninitialized variable is referenced in io_submit_sqe To: Liu Yong Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org References: <20200813065644.GA91891@ubuntu> From: Jens Axboe Message-ID: <9fd08f8f-8c89-9c59-6d9e-5933ccc65967@kernel.dk> Date: Thu, 13 Aug 2020 08:56:30 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200813065644.GA91891@ubuntu> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/13/20 12:56 AM, Liu Yong wrote: > the commit ("opcode>") > caused another vulnerability. After io_get_req(), the sqe_submit struct > in req is not initialized, but the following code defaults that > req->submit.opcode is available. Thanks, I'll add this for 5.4-stable, it doesn't affect any kernels newer than that. -- Jens Axboe