Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp1406158pxa; Thu, 13 Aug 2020 07:59:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxyaQXqh4NdKaayXVk7vo++foTVaJttYswKn9twQeAx0+zx3K2LcjC98IkkTidEjxHbmXi4 X-Received: by 2002:a17:906:f898:: with SMTP id lg24mr1482922ejb.86.1597330754618; Thu, 13 Aug 2020 07:59:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597330754; cv=none; d=google.com; s=arc-20160816; b=j5lX1+Chfr9sTSY9EyJUEIaajTTQgief9JdCNOIc5YPH6IlLOHHYZnmg5v47J63J8y R5iRPJS80kHT9Fh/fPjvL9p6UeP00iioSqQsDpm7NhP/TAoYi6q9ePQVNVMyr0zphpH9 2/Qa04NZEKfVnZXWx6KRPIQuh1CoeLgKg0R10bfGCLnQSHn9S3PfFfWWqiSkic87/9GJ nhcO7FWSWGd9lxPtzTj42oQ4hNcCrpThQDddP9oAxiWPGjBQTaAwIpFffWWuj3MiN6yP JStNN2Z34PmWgSqgFdHGOUPcgjER9QhLaVkH22vVYS/Hs6MViZ+GwdZVOaIGQM2jxWS8 XPWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=NHc4IgS5EMWw8XD8hr666bQfxWDohgWccYyTY3erxDE=; b=PF7FdK5tqGyCIKgX8AAu8zybqHhPOFNd0huSTMh4WrmcQCCDQXV1GbtthlPrzO1keQ eRCX1iFRSeMrCTmZeNW4iRe6DpEYv/PhsJKgT4ejnwVq2yqIJF0SxkOHuZH6p8KZR/BT 4mhzuguGwvnjJIwm1TpszAzCDKzR0tm+DbAhS1kemqn552TTs0FItVMQTJ3KgQ3qQXtL NzVCujdwtkITH9owX1A4qLrobCnANcOViK8hBjlxc0bVzqBHvKXrgRq0amPT69OShbq9 pvD8a3QclEnzRDuv1uwJRLirpeoq1yNR4nzuD5fzqM6DmLyuS6ZqsYuEIAwNkXqup2Y9 BQVQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h25si3442189eje.30.2020.08.13.07.58.52; Thu, 13 Aug 2020 07:59:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726651AbgHMOzf (ORCPT + 99 others); Thu, 13 Aug 2020 10:55:35 -0400 Received: from dispatch1-us1.ppe-hosted.com ([67.231.154.164]:59884 "EHLO dispatch1-us1.ppe-hosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726622AbgHMOzd (ORCPT ); Thu, 13 Aug 2020 10:55:33 -0400 Received: from mx1-us1.ppe-hosted.com (unknown [10.110.50.150]) by dispatch1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id E1DBF200C9; Thu, 13 Aug 2020 14:55:31 +0000 (UTC) Received: from us4-mdac16-65.at1.mdlocal (unknown [10.110.50.184]) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id DEBBB800A3; Thu, 13 Aug 2020 14:55:31 +0000 (UTC) X-Virus-Scanned: Proofpoint Essentials engine Received: from mx1-us1.ppe-hosted.com (unknown [10.110.49.108]) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 6948D100080; Thu, 13 Aug 2020 14:55:31 +0000 (UTC) Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 2384814005B; Thu, 13 Aug 2020 14:55:31 +0000 (UTC) Received: from [10.17.20.203] (10.17.20.203) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 13 Aug 2020 15:55:25 +0100 Subject: Re: [PATCH] sfc_ef100: Fix build failure on powerpc To: Christophe Leroy , "Solarflare linux maintainers" , Martin Habets , "David S. Miller" , "Jakub Kicinski" CC: , , References: <44e26ec6a1bc01b5b138c29b623c83d5846718b2.1597329390.git.christophe.leroy@csgroup.eu> From: Edward Cree Message-ID: Date: Thu, 13 Aug 2020 15:55:22 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <44e26ec6a1bc01b5b138c29b623c83d5846718b2.1597329390.git.christophe.leroy@csgroup.eu> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Language: en-GB X-Originating-IP: [10.17.20.203] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.6.1012-25600.005 X-TM-AS-Result: No-5.375500-8.000000-10 X-TMASE-MatchedRID: 7ySqCuYCpfgZKb71Tl2YYfZvT2zYoYOwC/ExpXrHizzAlr9zf1x/lojw YzF1DjNPWiR9CUpDXWeo+OAAmru7hxxtkIHKGuMRT3nBCKOvAEvpVMb1xnESMsz/SxKo9mJ4wQ3 t1bD9XwKRY9dCWcgj9mJwCsb/Z8alTX7PJ/OU3vKDGx/OQ1GV8vaSyLmE5Bx3+gtHj7OwNO2Ohz Oa6g8KrV90guFwhBetqWzlavUblWzUlw+R3vVZXldVttIi2JlLK2TLqpu5/SM= X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--5.375500-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.6.1012-25600.005 X-MDID: 1597330531-ci2M3Uh6fLvl Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13/08/2020 15:39, Christophe Leroy wrote: > ppc6xx_defconfig fails building sfc.ko module, complaining > about the lack of _umoddi3 symbol. > > This is due to the following test > > if (EFX_MIN_DMAQ_SIZE % reader->value) { > > Because reader->value is u64. Already fixed in net.git by 41077c990266 ("sfc: fix ef100 design-param checking"). But thanks anyway.