Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20952e3e-6b06-11e4-aff7-07dfbdc5ee18@infradead.org> <810f1b0e-0adf-c316-f23c-172338f9ef0a@linux.intel.com>
In-Reply-To: <810f1b0e-0adf-c316-f23c-172338f9ef0a@linux.intel.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Thu, 13 Aug 2020 23:55:14 +0300
Message-ID: <CAHp75VcJCjJJvbkSiGHC+3_shWRwoqeZHE2KNDLQBjneW=02dg@mail.gmail.com>
Subject: Re: [PATCH] x86/pci: fix intel_mid_pci.c build error when ACPI is not enabled
To:     Arjan van de Ven <arjan@linux.intel.com>
Cc:     Randy Dunlap <rdunlap@infradead.org>,
        LKML <linux-kernel@vger.kernel.org>,
        linux-pci <linux-pci@vger.kernel.org>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Jesse Barnes <jsbarnes@google.com>,
        Len Brown <lenb@kernel.org>,
        Jacob Pan <jacob.jun.pan@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Aug 13, 2020 at 11:31 PM Arjan van de Ven <arjan@linux.intel.com> w=
rote:
> On 8/13/2020 12:58 PM, Randy Dunlap wrote:
> > From: Randy Dunlap <rdunlap@infradead.org>
> >
> > Fix build error when CONFIG_ACPI is not set/enabled by adding
> > the header file <asm/acpi.h> which contains a stub for the function
> > in the build error.
> >
> > ../arch/x86/pci/intel_mid_pci.c: In function =E2=80=98intel_mid_pci_ini=
t=E2=80=99:
> > ../arch/x86/pci/intel_mid_pci.c:303:2: error: implicit declaration of f=
unction =E2=80=98acpi_noirq_set=E2=80=99; did you mean =E2=80=98acpi_irq_ge=
t=E2=80=99? [-Werror=3Dimplicit-function-declaration]
> >    acpi_noirq_set();

Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Thanks!

> > Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> > Cc: Jacob Pan <jacob.jun.pan@linux.intel.com>
> > Cc: Len Brown <lenb@kernel.org>
> > Cc: Bjorn Helgaas <bhelgaas@google.com>
> > Cc: Jesse Barnes <jsbarnes@google.com>
> > Cc: Arjan van de Ven <arjan@linux.intel.com>
> > Cc: linux-pci@vger.kernel.org
> > ---
> > Found in linux-next, but applies to/exists in mainline also.
> >
> > Alternative.1: X86_INTEL_MID depends on ACPI
> > Alternative.2: drop X86_INTEL_MID support
>
> at this point I'd suggest Alternative 2; the products that needed that (p=
ast tense, that technology
> is no longer need for any newer products) never shipped in any form where=
 a 4.x or 5.x kernel could
> work, and they are also all locked down...

This is not true. We have Intel Edison which runs nicely on vanilla
(not everything, some is still requiring a couple of patches, but most
of it works out-of-the-box).

And for the record, I have been working on removing quite a pile of
code (~13kLOCs to the date IIRC) in MID area. Just need some time to
fix Edison watchdog for that.

--=20
With Best Regards,
Andy Shevchenko