Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200326203637.1892-1-dsmythies@telus.net>
In-Reply-To: <20200326203637.1892-1-dsmythies@telus.net>
From:   Len Brown <lenb@kernel.org>
Date:   Thu, 13 Aug 2020 17:16:35 -0400
Message-ID: <CAJvTdKnyeTvJ_iP=XTet0ggs7FqswWQsfYQr5crnPPwOTfBMRg@mail.gmail.com>
Subject: Re: [PATCH] tools/power/x86/turbostat: Always print idle in the
 system configuration header
To:     Doug Smythies <doug.smythies@gmail.com>
Cc:     Doug Smythies <dsmythies@telus.net>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux PM list <linux-pm@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Applied.

thanks!
-Len

On Thu, Mar 26, 2020 at 4:36 PM Doug Smythies <doug.smythies@gmail.com> wrote:
>
> If the --quiet option is not used, turbostat prints a useful system
> configuration header during startup. Inclusion of idle system configuration
> information is a function of inclusion in the columns choosen to be displayed.
>
> Always list the idle system configuration.
>
> Signed-off-by: Doug Smythies <dsmythies@telus.net>
> ---
>  tools/power/x86/turbostat/turbostat.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/tools/power/x86/turbostat/turbostat.c b/tools/power/x86/turbostat/turbostat.c
> index 33b370865d16..834b86676d00 100644
> --- a/tools/power/x86/turbostat/turbostat.c
> +++ b/tools/power/x86/turbostat/turbostat.c
> @@ -3530,9 +3530,6 @@ dump_sysfs_cstate_config(void)
>         int state;
>         char *sp;
>
> -       if (!DO_BIC(BIC_sysfs))
> -               return;
> -
>         if (access("/sys/devices/system/cpu/cpuidle", R_OK)) {
>                 fprintf(outf, "cpuidle not loaded\n");
>                 return;
> --
> 2.25.1
>


-- 
Len Brown, Intel Open Source Technology Center