Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
References: <20200812125300.11889-1-valentin.schneider@arm.com> <20200812125300.11889-3-valentin.schneider@arm.com> <20200813191614.GB2337490@gmail.com>
User-agent: mu4e 0.9.17; emacs 26.3
From:   Valentin Schneider <valentin.schneider@arm.com>
To:     Ingo Molnar <mingo@kernel.org>
Cc:     linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        Russell King <linux@armlinux.org.uk>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        peterz@infradead.org, vincent.guittot@linaro.org,
        morten.rasmussen@arm.com, Quentin Perret <qperret@google.com>
Subject: Re: [PATCH v5 02/17] ARM: Revert back to default scheduler topology.
In-reply-to: <20200813191614.GB2337490@gmail.com>
Date:   Thu, 13 Aug 2020 23:27:05 +0100
Message-ID: <jhjzh6ydvwm.mognet@arm.com>
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 13/08/20 20:16, Ingo Molnar wrote:
> * Valentin Schneider <valentin.schneider@arm.com> wrote:
>
>> The ARM-specific GMC level is meant to be built using the thread sibling
>> mask, but no devicetree in arch/arm/boot/dts uses the 'thread' cpu-map
>> binding. With SD_SHARE_POWERDOMAIN gone, this topology level can be
>> removed, at which point ARM no longer benefits from having a custom defined
>> topology table.
>>
>> Delete the GMC topology level by making ARM use the default scheduler
>> topology table. This essentially reverts commit
>>
>>   fb2aa85564f4 ("sched, ARM: Create a dedicated scheduler topology table")
>>
>> Cc: Russell King <linux@armlinux.org.uk>
>> Suggested-by: Dietmar Eggemann <dietmar.eggemann@arm.com>
>> Reviewed-by: Dietmar Eggemann <dietmar.eggemann@arm.com>
>> Signed-off-by: Valentin Schneider <valentin.schneider@arm.com>
>
> Minor changelog nit, it's helpful to add this final sentence:
>
>     No change in functionality is expected.
>
> ( If indeed no change in functionality is expected. ;-)
>

Right, that's indeed the case here given the GMC domain would always be
degenerated anyway.

> Thanks,
>
>       Ingo