Subject: Re: swapper_space export
From: Arjan van de Ven <arjan@infradead.org>
To: Josef Sipek <jsipek@fsl.cs.sunysb.edu>
Cc: linux-kernel@vger.kernel.org
In-Reply-To: <20060516232443.GA10762@filer.fsl.cs.sunysb.edu>
References: <20060516232443.GA10762@filer.fsl.cs.sunysb.edu>
Content-Type: text/plain
Date: Wed, 17 May 2006 13:18:25 +0200
Message-Id: <1147864721.3051.17.camel@laptopd505.fenrus.org>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1130
Lines: 23

On Tue, 2006-05-16 at 19:24 -0400, Josef Sipek wrote:
> I was trying to compile the Unionfs[1] to get it up to sync it up with
> the kernel developments from the past few months. Anyway, long story
> short...swapper_space (defined in mm/swap_state.c) is not exported
> anymore (git commit: 4936967374c1ad0eb3b734f24875e2484c3786cc). This
> apparently is not an issue for most modules. Troubles arise when the
> modules include mm.h or any of its relatives.
> 
> One simply gets a linker error about swapper_space not being defined.
> The problem is that it is used in mm.h.


don't you think it's really suspect that no other filesystem, in fact no
other driver in the kernel needs this? Could it just be that unionfs is 
using a wrong API ? Because if that's the case you're patch is just the
wrong thing. Maybe the unionfs people should try to submit their code
for review etc......

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/