Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp200777pxa; Fri, 14 Aug 2020 01:22:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxM7jOMlGsJga1SEE6nIBZ2bCjOJ40MovEqJA0ioHFwzuHpOPMuD+l/dRqVLthPuC2QsSFV X-Received: by 2002:a17:906:4e4f:: with SMTP id g15mr1283139ejw.443.1597393352184; Fri, 14 Aug 2020 01:22:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597393352; cv=none; d=google.com; s=arc-20160816; b=C7AIaOX4vQzqpXUHY81PL4KCbXA4iMlOBhf4ebc8bMl1bC4m5XLpeAEWu0LQu3QV4A muakdlbKzPkNnE5Abdmg4n76QN5THowWypmi1EUib4yKCo9RU7lgVvTM401OySueG9xm MNgWVrwu+ndmnWPp4SmfJwW6mLJSYtmBVsL2VosVuF89iPzWii3CpiXAaVOlktAcVm+Y 6KHU5i3ljzSxY2afkd2WmKFvvh83kvggri5HLwuw2U7FgG8s/iLEWZ4qFXeNu/lJo0Fb KF2NQTIkGjb0SpODS2IOxXhdcgPQ5CPxdXxcGzEQBiyE6Ud8XSkdIxMN4RbeGPPerzyA qJbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=g8PSEAUA7x2opNJ9a7x6NEXmPCi+/BopzEM5tlmpuYw=; b=yJ6u2gcVhrivkeYy3kZeTO4qKX/0KmJQZyrefYAghOxc0s8Euz6seI8Y2LniIfJyXG mDv0W6pn4ETwWX8AMGvemWnOONd09KiiDU4ti2tWPDiQKFS5rm9hQgekRZaARSk89qAJ 5hrMB00mFkLtwLddLznzPneu2/FbuZcDLYfQDYU9ZUqwijJZhUBzpEMbZBeSCh0cVSBk 2H/GOrdHqEQiyYnLXn3Q14Y0sl8HLbQle4uQLk6Ve6MRtymLdxQL+lVzyrkyzrY0MQex ac6YQ0pLO9fekzXS55qZTmpWhWsXeJ5g3N9GnYgJrUbSGL8xaeQAoKxhxkfihzMJJxrE dmmQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=casper.20170209 header.b=YiTlwITG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u19si5689294edd.284.2020.08.14.01.22.09; Fri, 14 Aug 2020 01:22:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=casper.20170209 header.b=YiTlwITG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726796AbgHNIRr (ORCPT + 99 others); Fri, 14 Aug 2020 04:17:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36948 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726603AbgHNIRr (ORCPT ); Fri, 14 Aug 2020 04:17:47 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 595B0C061383 for ; Fri, 14 Aug 2020 01:17:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=g8PSEAUA7x2opNJ9a7x6NEXmPCi+/BopzEM5tlmpuYw=; b=YiTlwITG20aDN876I+mE/JX+xS AeqYqW0mEmRrrc6vwVasr/wMYwOG3IBnH8h2+s46OQyWKhMp98c3i4/GlMAg/O5QBj+dJ+DNZ3ZuF OhN8mNTpmBBvJIHzMJ3YdU0+El1b1sqM9yS1H1bhKaKVSWQbJgaDZDXcAuimgx0Hys8Swl7hyGjKT QyjMs8b0FMM/Zobo6kAaxW6s0CHJGIXk1qa+Y9EZuYvflAikGe1fBA2LoMDUAMcCoQBRDlBRz8oZV +uq86/ahtS6IhUc9nPLV11BilFUb52dwDczoHFcvjg8k3gvPjmyBkVZd39iZmCDDh3yy4x74tJZDI JiRKFEQA==; Received: from hch by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1k6Utl-0004nA-DH; Fri, 14 Aug 2020 08:17:13 +0000 Date: Fri, 14 Aug 2020 09:17:13 +0100 From: Christoph Hellwig To: Tianjia Zhang Cc: james.smart@broadcom.com, kbusch@kernel.org, axboe@fb.com, hch@lst.de, sagi@grimberg.me, jthumshirn@suse.de, james_p_freyensee@linux.intel.com, tianjia.zhang@alibaba.com, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org Subject: Re: [PATCH] nvme-fc: Fix wrong return value in __nvme_fc_init_request() Message-ID: <20200814081713.GA18371@infradead.org> References: <20200802111545.5566-1-tianjia.zhang@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200802111545.5566-1-tianjia.zhang@linux.alibaba.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Aug 02, 2020 at 07:15:45PM +0800, Tianjia Zhang wrote: > On an error exit path, a negative error code should be returned > instead of a positive return value. > > Fixes: e399441de9115 ("nvme-fabrics: Add host support for FC transport") > Cc: James Smart > Signed-off-by: Tianjia Zhang Looks good: Reviewed-by: Christoph Hellwig