Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 14 Aug 2020 08:57:31 -0300
From:   Arnaldo Carvalho de Melo <acme@kernel.org>
To:     Changbin Du <changbin.du@gmail.com>
Cc:     Jiri Olsa <jolsa@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Namhyung Kim <namhyung@kernel.org>,
        Steven Rostedt <rostedt@goodmis.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8 05/18] perf ftrace: show trace column header
Message-ID: <20200814115731.GV13995@kernel.org>
References: <20200808023141.14227-1-changbin.du@gmail.com>
 <20200808023141.14227-6-changbin.du@gmail.com>
 <20200814115655.GU13995@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200814115655.GU13995@kernel.org>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Em Fri, Aug 14, 2020 at 08:56:55AM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Sat, Aug 08, 2020 at 10:31:28AM +0800, Changbin Du escreveu:
> > This makes perf-ftrace display column header before printing trace.
> > 
> >   $ sudo perf ftrace
> >   # tracer: function
> >   #
> >   # entries-in-buffer/entries-written: 0/0   #P:8
> >   #
> >   #            TASK-PID     CPU#   TIMESTAMP  FUNCTION
> >   #              | |         |       |         |
> >              <...>-9246  [006]  10726.262760: mutex_unlock <-rb_simple_write
> >              <...>-9246  [006]  10726.262764: __fsnotify_parent <-vfs_write
> >              <...>-9246  [006]  10726.262765: fsnotify <-vfs_write
> >              <...>-9246  [006]  10726.262766: __sb_end_write <-vfs_write
> >              <...>-9246  [006]  10726.262767: fpregs_assert_state_consistent <-do_syscall_64
> 
> We have:
> 
>   # perf report -h header
>   
>    Usage: perf report [<options>]
>   
>           --header          Show data header.
>           --header-only     Show only data header.
>   
>   #
> 
> So perhaps we should have those as well, in the 'ftrace' case one would
> perhaps want to use --no-header, for instance, to do some scripting
> parsing just the trace lines.

This as well can be done after I process this series, to make progress.

Applied.

- Arnaldo