Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp315490pxa; Fri, 14 Aug 2020 05:14:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxkdkCV0/M63XjnfbRcl/SJXUr3sl46QetLEAh1uxdvxZilyK4OvE+DdUkmllFejMd2p5fA X-Received: by 2002:a17:906:82d5:: with SMTP id a21mr2022177ejy.213.1597407285461; Fri, 14 Aug 2020 05:14:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597407285; cv=none; d=google.com; s=arc-20160816; b=fh79OQblf1oLA2APdd4nJeR9Wiey/VKpbVf8doBu9L57hiDQCXVEq+h7pnwkWplc0o 3ihfvLT5j6Zt191rw7CZgVGcXx9bTHN8DnY8c0RMglqVomjUrod73CJWLKkSNG0l/9La xVtlQhyLK49+s72r1oEWGW58k0hNJbAyMPAwus49XyjJSXSivzdsFdLOEE8z5Scqc2s3 dP7DfNy0ywzWHvdRDAmCox+ZETOHZI8IMVaTb8omZ0/zHmisfJHeedFUTd2kttuuzEKq zQivPCsuSKeERdp8uPwB0smUpP+qHgKhy3P7jB13ClDIjIiYOUDD4Jx5v9pWpwPQdjU9 cpDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=vrUq+5CO1ITVVc1UNCGXU5LFynB0HyKas4Zjf+gNR04=; b=PGtSudItzSTYLF7THLYi7+04VQrU8nCqDHGYWrlWz2emSVBYdanJcLZHSj5OpsY+gJ z2RqPth61/BEQQWPLIDKYWE20in3cnAVF49fgYZSmahyvqbVqFjPPDCbbIYnPUzpljFB xR+JtLslSOVcf376hK6Kn6lA+UCU4F0f5IIeLW7Helzh7AhW48W+vv0MsRJdjg0HV5SF 1zI+Vn8aw6HkkmyXuZjILOwU1XrLyJ2I11gR4S3gATmQpSwEoPa9d1o3avTFLVu6ZaNV U+KwthHvhG+HyMStpAp8O/D47T4a+XVFUqg0hankL40I/A6tYd26WOCpAcYl9eydWxLC CeWA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ly7Z3vrH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i21si5372779eje.143.2020.08.14.05.14.22; Fri, 14 Aug 2020 05:14:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ly7Z3vrH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726973AbgHNMMz (ORCPT + 99 others); Fri, 14 Aug 2020 08:12:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:42548 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726735AbgHNMMx (ORCPT ); Fri, 14 Aug 2020 08:12:53 -0400 Received: from quaco.ghostprotocols.net (177.207.136.251.dynamic.adsl.gvt.net.br [177.207.136.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 885BC206B2; Fri, 14 Aug 2020 12:12:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597407172; bh=g386NwDbsu7lGV2HBJwv/hxldaBAgNVPoUH35WpXzFk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ly7Z3vrHtSCkRWNCsQYYg6E7KwZlXOrRZHAL5OUh6aJiry69YQ1piB4ltcKqAdZpz NXOea3l5v4u9szvIVmZb1EknQbswzvW/zDuoAWFBzxd9YI5bh4rStKyUjd3mV6crdM xEqrkiVP0nH0sh26hzWsxBvbcfv/RBzc96v7FImY= Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 998CA40D3D; Fri, 14 Aug 2020 09:12:50 -0300 (-03) Date: Fri, 14 Aug 2020 09:12:50 -0300 From: Arnaldo Carvalho de Melo To: Changbin Du Cc: Jiri Olsa , Peter Zijlstra , Ingo Molnar , Namhyung Kim , Steven Rostedt , linux-kernel@vger.kernel.org Subject: Re: [PATCH v8 04/18] perf ftrace: add option '-m/--buffer-size' to set per-cpu buffer size Message-ID: <20200814121250.GX13995@kernel.org> References: <20200808023141.14227-1-changbin.du@gmail.com> <20200808023141.14227-5-changbin.du@gmail.com> <20200814115318.GT13995@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200814115318.GT13995@kernel.org> X-Url: http://acmel.wordpress.com Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Fri, Aug 14, 2020 at 08:53:18AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Sat, Aug 08, 2020 at 10:31:27AM +0800, Changbin Du escreveu: > > This adds an option '-m/--buffer-size' to allow us set the size of per-cpu > > tracing buffer. > > > > Signed-off-by: Changbin Du > > So this is a little bit confusing, i.e. if I don't specify a suffix (B, > K, M, G) I get: > > # perf ftrace -m 2048 > > Usage: perf ftrace [] [] > or: perf ftrace [] -- [] > > -m, --buffer-size > size of per cpu buffer > # > > Which is not very helpful, and you also forgot to add an entry to 'man > perf-ftrace' (tools/perf/Documentation/perf-ftrace.txt), so only by I must be blind, the entry _was_ added to perf-ftrace.txt, nevermind :-) But the other points still stand :) > looking at the patch I was able to figure out that a suffix is > required. > > Now look how 'perf trace' works: > > # perf trace -m 2048 -e open* --max-events 1 > 0.772 sh/343169 openat(dfd: CWD, filename: /etc/ld.so.cache, flags: RDONLY|CLOEXEC) = 3 > # > > I.e. it doesn't require a unit suffix, which is more natural. > > # perf trace -h -m > > -m, --mmap-pages > number of mmap data pages > > # > > It indicates that the argument is in units of 'pages', while you don't > state that in: > > $ perf ftrace -h -m > > -m, --buffer-size > size of per cpu buffer > > $ > > So please improve the option description and add its longer explanation > in the man page, also I suggest you interpret: > > # perf ftrace -m 2048 > > as asking for 2048K since the file as _kb in its name, so people used to > ftrace will get what they ask for, i.e. N kb. Please add this to the one > line description in 'perf ftrace -h', namely that the default unit os > 'K'. > > All this can be made on top of this series, so I'm applying it now to > make progress. > > - Arnaldo > > > --- > > v2: support units as a suffix. > > --- > > tools/perf/Documentation/perf-ftrace.txt | 5 +++ > > tools/perf/builtin-ftrace.c | 55 ++++++++++++++++++++++++ > > 2 files changed, 60 insertions(+) > > > > diff --git a/tools/perf/Documentation/perf-ftrace.txt b/tools/perf/Documentation/perf-ftrace.txt > > index 4f5628445a63..7a5d915f60b0 100644 > > --- a/tools/perf/Documentation/perf-ftrace.txt > > +++ b/tools/perf/Documentation/perf-ftrace.txt > > @@ -53,6 +53,11 @@ OPTIONS > > Ranges of CPUs are specified with -: 0-2. > > Default is to trace on all online CPUs. > > > > +-m:: > > +--buffer-size:: > > + Set the size of per-cpu tracing buffer, is expected to > > + be a number with appended unit character - B/K/M/G. > > + > > -T:: > > --trace-funcs=:: > > Select function tracer and set function filter on the given > > diff --git a/tools/perf/builtin-ftrace.c b/tools/perf/builtin-ftrace.c > > index 4b3fcee5725a..a3a4f4be9dde 100644 > > --- a/tools/perf/builtin-ftrace.c > > +++ b/tools/perf/builtin-ftrace.c > > @@ -26,6 +26,7 @@ > > #include "thread_map.h" > > #include "util/cap.h" > > #include "util/config.h" > > +#include "util/units.h" > > > > #define DEFAULT_TRACER "function_graph" > > > > @@ -39,6 +40,7 @@ struct perf_ftrace { > > struct list_head graph_funcs; > > struct list_head nograph_funcs; > > int graph_depth; > > + unsigned long percpu_buffer_size; > > }; > > > > struct filter_entry { > > @@ -324,6 +326,21 @@ static int set_tracing_depth(struct perf_ftrace *ftrace) > > return 0; > > } > > > > +static int set_tracing_percpu_buffer_size(struct perf_ftrace *ftrace) > > +{ > > + int ret; > > + > > + if (ftrace->percpu_buffer_size == 0) > > + return 0; > > + > > + ret = write_tracing_file_int("buffer_size_kb", > > + ftrace->percpu_buffer_size / 1024); > > + if (ret < 0) > > + return ret; > > + > > + return 0; > > +} > > + > > static int __cmd_ftrace(struct perf_ftrace *ftrace, int argc, const char **argv) > > { > > char *trace_file; > > @@ -388,6 +405,11 @@ static int __cmd_ftrace(struct perf_ftrace *ftrace, int argc, const char **argv) > > goto out_reset; > > } > > > > + if (set_tracing_percpu_buffer_size(ftrace) < 0) { > > + pr_err("failed to set tracing per-cpu buffer size\n"); > > + goto out_reset; > > + } > > + > > if (write_tracing_file("current_tracer", ftrace->tracer) < 0) { > > pr_err("failed to set current_tracer to %s\n", ftrace->tracer); > > goto out_reset; > > @@ -506,6 +528,37 @@ static void delete_filter_func(struct list_head *head) > > } > > } > > > > +static int parse_buffer_size(const struct option *opt, > > + const char *str, int unset) > > +{ > > + unsigned long *s = (unsigned long *)opt->value; > > + static struct parse_tag tags_size[] = { > > + { .tag = 'B', .mult = 1 }, > > + { .tag = 'K', .mult = 1 << 10 }, > > + { .tag = 'M', .mult = 1 << 20 }, > > + { .tag = 'G', .mult = 1 << 30 }, > > + { .tag = 0 }, > > + }; > > + unsigned long val; > > + > > + if (unset) { > > + *s = 0; > > + return 0; > > + } > > + > > + val = parse_tag_value(str, tags_size); > > + if (val != (unsigned long) -1) { > > + if (val < 1024) { > > + pr_err("buffer size too small, must larger than 1KB."); > > + return -1; > > + } > > + *s = val; > > + return 0; > > + } > > + > > + return -1; > > +} > > + > > static void select_tracer(struct perf_ftrace *ftrace) > > { > > bool graph = !list_empty(&ftrace->graph_funcs) || > > @@ -560,6 +613,8 @@ int cmd_ftrace(int argc, const char **argv) > > "Set nograph filter on given functions", parse_filter_func), > > OPT_INTEGER('D', "graph-depth", &ftrace.graph_depth, > > "Max depth for function graph tracer"), > > + OPT_CALLBACK('m', "buffer-size", &ftrace.percpu_buffer_size, "size", > > + "size of per cpu buffer", parse_buffer_size), > > OPT_END() > > }; > > > > -- > > 2.25.1 > > > > -- > > - Arnaldo -- - Arnaldo