Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp462078pxa; Fri, 14 Aug 2020 08:45:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx/dKfJcJYGFJ3FD2c573AGZa9pCCQGiSI235vWuwJgS9JSHfq9yTor7NHTpKmjs/aiXM14 X-Received: by 2002:a17:906:3816:: with SMTP id v22mr2911232ejc.105.1597419906217; Fri, 14 Aug 2020 08:45:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597419906; cv=none; d=google.com; s=arc-20160816; b=nvX5/7kePVPP6N6oH/kFw5A0dN/luyPIAd7vSrMrCMdOGVaW2wvAfk2u0MSCBViuy+ BWW1Qe1gHyWi5iks4wRMleTvYC7rMhR+4xa3InMgTsdO3X1sGAnNdEmHaSsqICxxd5X5 Sv1ilPyXUVSbCCpf74gGpGWrvGc0FzbKCA1nfxrWO+oqjTFd1nL5+X+j3IznkeGsqj5I 98sjJa8W3t9it+N5ojM+G7AtpHAk7sJQnQ0QQY7oioS8ujVD2H6OXhQLMZP84Ze051Q1 7W0ls25tc2P+CFK2sTTRk6Ybb9uxAu8dCUbJN6t6HHynwChL0w7TIF3eeU6SKJk2Xk5i FAWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=ggMXgX7RUq22IK8MLaR6J65bRRwoutct0090dW6uEgw=; b=Dwbmklh2nZ32z4BQp7VGTVd8kGlDr22A9pP3a+IfJmHu/8ZM926WW9TBycrp9VBRxc R/IeDPWG0P7iHaB4aZehspK/RqAFdl3rFdIFGCeTeqn2uQ+EjtatlAUmwDeaxUnc4EqY N0UNKqG0xUj599squkqE97YrhIBnjl1xkWQ58sjrQlbgnnPrtB52ri2Lj+IlnIe1C/IU BDmmokAihebnE2RgND+ubt/6410BUCOkG5uQHiHGdF64uk8Zh0eYTutjg/ese4nWKA/s Cht0W8ojjzxQ7GFkQZcDz4LvtaY3JNjgbJr4t73d6Jm/K2bG7L5BBT9tybM7yk+jndEZ 1A5Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=IKlqOFJn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l7si3172579edv.594.2020.08.14.08.44.42; Fri, 14 Aug 2020 08:45:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=IKlqOFJn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728641AbgHNOYx (ORCPT + 99 others); Fri, 14 Aug 2020 10:24:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36976 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728012AbgHNOYw (ORCPT ); Fri, 14 Aug 2020 10:24:52 -0400 Received: from mail-il1-x143.google.com (mail-il1-x143.google.com [IPv6:2607:f8b0:4864:20::143]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5EA93C061384; Fri, 14 Aug 2020 07:24:52 -0700 (PDT) Received: by mail-il1-x143.google.com with SMTP id e11so598282ils.10; Fri, 14 Aug 2020 07:24:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=ggMXgX7RUq22IK8MLaR6J65bRRwoutct0090dW6uEgw=; b=IKlqOFJnaBfJOoWsHY8UwOXQ4vWIVHOQ9cHFWJ/Yj4+Q5myA06cA4pxzNHWNeVCEuj K1C032wALPmBsr7wXqR/sGzkjo5MIplBaBt2+o6hjwJ0YMNuF8k4L0vg0kgsop05Wq3t 1VPqZHYz7U8Z2wT0h9HCgJkMoErzCNAPVxywOh5UNZ9D9tFVpSwIRLutCICVJ1At1Mx2 DnKIzOxQ23bC10EPBpdpg91/wXpp3J9vh4lJWRJwnkNB15+DpCOAKHNafy3tRm7gQN3F FFRvxr8Sx/x1/7TrM1jkphLoqhfetY5yu8AE0VRah+1AJ0g/+jsjiTLSaIShPAV3qBVr 8/xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=ggMXgX7RUq22IK8MLaR6J65bRRwoutct0090dW6uEgw=; b=nv9tyzgnLvOfZZNHl3tBW63smTKZBhppHtwjlFUBbuxuF1DHbFmEEw+nXweWPUWVu/ RZ8te5UdGfOV9hWSKrSDMfBpij3SmVdcdBbOV7Qb2NFOXOD86UTBrY3dW1m6Q+PiZHhy T0takF1y3jfvsNjreEj5diSQFJqqo7CiBIlT6pElt/jGwHT7Jgqh/tTTwaXRnNgXj3A+ Wcqh2SvzQ9QVipPORh9ozKXkjQpc4GvPtXDu8uM9HhM3hkAT7lFdDk/eNzakOAsdOjdX 2PsT/8KUin7OP9D8wnJzsbDRHEen8ujZJDFM5oZnis8xgaYQebacZbY8+dITrHGLiR3g Z9WA== X-Gm-Message-State: AOAM5301PBgfEhVoXEioQf0y9WLJ7jALLUP/EL4Ta/uG2PXC5I+QDsPG mp6N22gVXTWJ4K4zdx7eFHRa0kXpGIt4LpJ8fs4= X-Received: by 2002:a05:6e02:143:: with SMTP id j3mr2472545ilr.97.1597415091428; Fri, 14 Aug 2020 07:24:51 -0700 (PDT) MIME-Version: 1.0 References: <20200813035100.13054.25671.stgit@localhost.localdomain> <20200813040232.13054.82417.stgit@localhost.localdomain> <6c072332-ff16-757d-99dd-b8fbae131a0c@linux.alibaba.com> In-Reply-To: <6c072332-ff16-757d-99dd-b8fbae131a0c@linux.alibaba.com> From: Alexander Duyck Date: Fri, 14 Aug 2020 07:24:40 -0700 Message-ID: Subject: Re: [RFC PATCH 2/3] mm: Drop use of test_and_set_skip in favor of just setting skip To: Alex Shi Cc: Yang Shi , kbuild test robot , Rong Chen , Konstantin Khlebnikov , "Kirill A. Shutemov" , Hugh Dickins , LKML , Daniel Jordan , linux-mm , Shakeel Butt , Matthew Wilcox , Johannes Weiner , Tejun Heo , cgroups@vger.kernel.org, Andrew Morton , Wei Yang , Mel Gorman , Joonsoo Kim Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 14, 2020 at 12:19 AM Alex Shi wrot= e: > > > > =E5=9C=A8 2020/8/13 =E4=B8=8B=E5=8D=8812:02, Alexander Duyck =E5=86=99=E9= =81=93: > > > > Since we have dropped the late abort case we can drop the code that was > > clearing the LRU flag and calling page_put since the abort case will no= w > > not be holding a reference to a page. > > > > Signed-off-by: Alexander Duyck > > seems the case-lru-file-mmap-read case drop about 3% on this patch in a r= ough testing. > on my 80 core machine. I'm not sure how it could have that much impact on the performance since the total effect would just be dropping what should be a redundant test since we tested the skip bit before we took the LRU bit, so we shouldn't need to test it again after. I finally got my test setup working last night. I'll have to do some testing in my environment and I can start trying to see what is going on. Thanks. - Alex