Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp547363pxa; Fri, 14 Aug 2020 10:58:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyyfzZmHYvsamVMhRWYe6WmfmJLpWZYU0U6baWLVzqIVyTLczehr0egTWifQ0HZcrvcraC5 X-Received: by 2002:a17:906:f9d7:: with SMTP id lj23mr3751515ejb.500.1597427895206; Fri, 14 Aug 2020 10:58:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597427895; cv=none; d=google.com; s=arc-20160816; b=hylGXBnTKsZ+aa+Ndld18RR7a/G7NQwqYx5nLdpoy0HSdawwiAT5732hdyTfPUeCly 3wndpSywRvs4fhqCesF1m5hfHrn0EAKMJvafnD58OLW1fiO1CYfzI3QhZ/DcocjS4MQS /c8e4bBI0kxcGGHt5jGmLd/aeU9JF5zGtkwRNkxiSjLuphuURTnlShi6DUGXek8JxYPF SmNNsGu31DpZKSdzdBEcboKqjYpqP+LFHl2hm5YZusSZ7PaejPk4Jp55L09ukpSTzCOu uuoCmlCL5LM1GXwDj7VuMc0oD75pN1yGW5mL2YGL7YQBWTtY6+kgyTZlkQnmFPg+JVun P+hQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:organization:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:ironport-sdr:ironport-sdr; bh=tq7Ghyh6BGt/x1Q65r2pMU89qIZVmuXI0xIBfj7B87E=; b=qHduTJydexuYInMTpYOhtKsqEMnMxCyogYmSZu1xf0f8ZCIryDLG22FXi84s1fAhzt c9JMxmjMM5Ki4sYwm87KtoIyChbJXt5AbQlvtwk3SvkfXZXalyxKuPlYSkGyehTf0S+E EeDnYFVqzoO3Lm9gY9i6wNxq9J8x8mzlwQoSxUJE92QtnldI9ItXLcEmZM5+P7Y0gcW+ WVXD1UTY9Zv6WSLUHClb30Kui6Rf9JJXINz3qqTej/tgOpv95zv3D4I+8Uas8gYoSpOT NdOTAwjmqftQ2Vq8GzsjTUIdRwiqIDxDK44iSsaq0BXWTNZ0Rd7sqqJFmOtJrGXqRSmu nK2g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l14si5966932ejz.730.2020.08.14.10.57.51; Fri, 14 Aug 2020 10:58:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727081AbgHNPko (ORCPT + 99 others); Fri, 14 Aug 2020 11:40:44 -0400 Received: from mga04.intel.com ([192.55.52.120]:56432 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726596AbgHNPkm (ORCPT ); Fri, 14 Aug 2020 11:40:42 -0400 IronPort-SDR: DcPcegE9sBRsyuDENPq7NanjR5TLCnTpi0WtEZgq5mVoMhhYLC0xt9pBylOv04oRvQ3BxzJ6Bd iUckvrwWkxow== X-IronPort-AV: E=McAfee;i="6000,8403,9713"; a="151841353" X-IronPort-AV: E=Sophos;i="5.76,312,1592895600"; d="scan'208";a="151841353" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Aug 2020 08:40:42 -0700 IronPort-SDR: 2n8Dv52TQCnaJMSaXNHBD7I/V/ERIxy0eV4qjA+xlPnn/ZAln4dQwa5NB5A/1Wj5sITFH+8o86 XJ2xTSMdEK5Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,312,1592895600"; d="scan'208";a="325755433" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga008.jf.intel.com with ESMTP; 14 Aug 2020 08:40:39 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1k6bor-008g8v-SY; Fri, 14 Aug 2020 18:40:37 +0300 Date: Fri, 14 Aug 2020 18:40:37 +0300 From: Andy Shevchenko To: Sergey Senozhatsky Cc: Greg KH , Guenter Roeck , Tony Lindgren , Kurt Kanzenbach , Raul Rangel , Petr Mladek , Steven Rostedt , John Ogness , linux-kernel , linux-serial@vger.kernel.org Subject: Re: [PATCH] uart:8250: change lock order in serial8250_do_startup() Message-ID: <20200814154037.GU1891694@smile.fi.intel.com> References: <20200814013802.357412-1-sergey.senozhatsky@gmail.com> <20200814095928.GK1891694@smile.fi.intel.com> <20200814112940.GB582@jagdpanzerIV.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200814112940.GB582@jagdpanzerIV.localdomain> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 14, 2020 at 08:29:40PM +0900, Sergey Senozhatsky wrote: > On (20/08/14 12:59), Andy Shevchenko wrote: ... > > I think we can stick with newer: > > > > if (port->irqflags & IRQF_SHARED) > > I'll take a look. Thanks! One more thing, perhaps update prefix to be 'serial: 8250:'. -- With Best Regards, Andy Shevchenko