Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 14 Aug 2020 21:52:13 +0200 (CEST)
From:   Julia Lawall <julia.lawall@inria.fr>
To:     Thomas Gleixner <tglx@linutronix.de>
cc:     kernel test robot <lkp@intel.com>, kbuild-all@lists.01.org,
        linux-kernel@vger.kernel.org, Theodore Ts'o <tytso@mit.edu>,
        Jan Kara <jack@suse.cz>, Nicolas Palix <nicolas.palix@imag.fr>
Subject: Re: fs/ocfs2/suballoc.c:2430:2-8: preceding lock on line 2413
In-Reply-To: <87364pkock.fsf@nanos.tec.linutronix.de>
Message-ID: <alpine.DEB.2.22.394.2008142148180.2441@hadrien>
References: <202008141412.mP88ccpD%lkp@intel.com> <878sehl5e4.fsf@nanos.tec.linutronix.de> <alpine.DEB.2.22.394.2008142059190.2441@hadrien> <87364pkock.fsf@nanos.tec.linutronix.de>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On Fri, 14 Aug 2020, Thomas Gleixner wrote:

> Julia,
>
> On Fri, Aug 14 2020 at 21:00, Julia Lawall wrote:
> > On Fri, 14 Aug 2020, Thomas Gleixner wrote:
> >> That's clearly a false positive. Is there anything what can be done to
> >> help that cocci script here?
> >
> > I have a better version that needs to get pushed.
> >
> > But normally these pass through me.  Did you get it directly from kbuild?
>
> Yes, because I touched the affected lines last :)

Actually, that's not the point.  Normally, I get all the reports on this
case, and then I forward them if they look ok.  If I forwarded something
incorrect, then sorry about that.  If the policy has changed for this rule
to be sending the reports out directlty to the recipients, then I think it
should be changed back.  There are a lot of real bugs with lock usage, but
there are alot of false positives too.  Specifically, the rule looks for
the case with identical if tests, but only when the branches are identical
too.

Kbuild people, can this be adjusted?  Or have I misunderstood the
situation?

thanks,
julia