Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp1300159pxa; Sat, 15 Aug 2020 15:00:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxY2qUelDVpIWsXWAMEn9S1HdO7hhLdgVDN3C5MI78CJ5S0K0pKNYjoOLAdaPNKEInkEIdU X-Received: by 2002:a50:ba8c:: with SMTP id x12mr8671969ede.319.1597528805651; Sat, 15 Aug 2020 15:00:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597528805; cv=none; d=google.com; s=arc-20160816; b=ucygL8VYcE0N0b7cNXUosxi8i4AE/Nnqt7YVdo/jRrkek/Q/weqU91UERYZAEiHv6J +z4mRozFZkn41JIFgJGm7G9ReDaqKaDv+cd7lTOz+yjQXp36anzN1qdY9c6AXkG9okc/ u5cWLHtPzQQgGk3fYZvzuQGzxsO72mCqmkcYC5pNGW79F2ey1tE9zm/iJveHrUrmHz89 XF59VSyvOx8j0GxmKVkunQYlX/zEcaBeEGThZEBnjW1Nw36xdLnrdyRfajgmXCV9ap/F ffXJ6DR+ry35PlnVkryk1jfat5olr8xBPCg0ePaIoZl7Tlg7ADBSzFxJrG1qNoXUAq19 WnLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=1m/YguZxj6AkoCmXEKP4B7t8uP7/c1T/6fMSQDFqceU=; b=o1GK03l0i4djOAeijzF4bzQFvPvLys5bmQGcqNMVur5Ciaz+DzMmGxOadyG1A4VxQ2 9k8B0dnqBvw26ut5pi6DzNbpQPrs4EZXauuzU1hIcXmbR3valuDVaiPgdDiaArKqK2D+ T6q41GuMceI8qm0T3JFJdCmaDP0Eg8foA/vHy/fbpf01/bzu2hEaimjiKLkRHnWZ/35o JdNlNgAy6jzZdAwVSfxadmHYIVXdzB0sdikp0bE4cpFfjrWiH+/lBJKK0YZ6H+7YgTbQ XMtJJAyoVgiZO7RMSyreQXB9DdSHIo77NrV09Q56KKcxu7WRDoKOeYHYAp438wibNRMI 8fLA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=nt0alZa5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f1si4622218ejc.311.2020.08.15.14.59.42; Sat, 15 Aug 2020 15:00:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=nt0alZa5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729527AbgHOV6M (ORCPT + 99 others); Sat, 15 Aug 2020 17:58:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45652 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728949AbgHOVv6 (ORCPT ); Sat, 15 Aug 2020 17:51:58 -0400 Received: from mail-ej1-x643.google.com (mail-ej1-x643.google.com [IPv6:2a00:1450:4864:20::643]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 381F2C02B8E7 for ; Sat, 15 Aug 2020 04:48:30 -0700 (PDT) Received: by mail-ej1-x643.google.com with SMTP id bo3so12567388ejb.11 for ; Sat, 15 Aug 2020 04:48:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=1m/YguZxj6AkoCmXEKP4B7t8uP7/c1T/6fMSQDFqceU=; b=nt0alZa5zu359g1uqNvpfQxEkzUzwcnXmATTJ9r6eeoMp+jE/fOZXoQAFuJene9+jj waJfslxi/nQ+im8IRI4n8v8fq5IEYUGKkxLoBtU6KpC++23dLYbUha1NHhDJnFl2zvg/ pdb+g7+8PqobjhtwQGMhMxUrkzEc1TJ0XKx1nWhH7fdzfsZXk9tPDToJ1iakPetynnMh uNbmZ751y66uejuiw7Skh17lcqxCjpzptvHTa7dGtg2+UaDvU6N6mjAcpAwe5XrqNXHq QHXlLmr57FgzVTFiDRumDwU9JHBvdv9lYnfR7s2JcUE0zaICWjuSkYi4Jl38J1cDdSb2 /L+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=1m/YguZxj6AkoCmXEKP4B7t8uP7/c1T/6fMSQDFqceU=; b=GHDHtVzUXUU/JFMeJvfWBnOpHcCiifS0ZeXrox3mAG9RW40690xfOo0fHcsVl+0YQv OvBvxFDqhE8QkrGnfB2+WYEZpclYdsYmEvnpJZIS16ySoGCQA5pYJQHSiy1daQ63fQFl +sbqPfbBqyMb+UxSxC1l6ip5HJT7NUlpny2xJv2PI05G5WPdAHbnbqnd+cS6vHNGenXA OJHcxPRPSV3MD72wh5Wb8oOKqKIvykHsD5Dl34XPGJqBROebb0n/7sNzGJxDWoLakcoW 4iTOPlfbYDdTlwGgfIcu/JcDF9F3iAtugTItd5TVCKZbaSSqmxDVpgEx9S35Sv32iN74 /aDQ== X-Gm-Message-State: AOAM5328/jMUvBgQmJgMWoPMAQbq4CwmLmbpEe3s7MxFTBgokKxDOSpR TXy33qIG7aKngQV0jXAHvIo= X-Received: by 2002:a17:906:e289:: with SMTP id gg9mr6970538ejb.448.1597492108245; Sat, 15 Aug 2020 04:48:28 -0700 (PDT) Received: from gmail.com (54033286.catv.pool.telekom.hu. [84.3.50.134]) by smtp.gmail.com with ESMTPSA id n25sm8963089ejr.21.2020.08.15.04.48.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Aug 2020 04:48:27 -0700 (PDT) Date: Sat, 15 Aug 2020 13:48:25 +0200 From: Ingo Molnar To: Eric Dumazet Cc: linux-kernel , Eric Dumazet , Jann Horn , syzbot , Andy Lutomirski , "Chang S . Bae" , Andy Lutomirski , Borislav Petkov , Brian Gerst , Dave Hansen , Denys Vlasenko , "H . Peter Anvin" , Linus Torvalds , Markus T Metzger , Peter Zijlstra , Ravi Shankar , Rik van Riel , Thomas Gleixner Subject: Re: [PATCH] x86/fsgsbase/64: Fix NULL deref in 86_fsgsbase_read_task Message-ID: <20200815114825.GA2685004@gmail.com> References: <20200814181617.442787-1-edumazet@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200814181617.442787-1-edumazet@google.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Eric Dumazet wrote: > syzbot found its way in 86_fsgsbase_read_task() [1] > > Fix is to make sure ldt pointer is not NULL. Thanks for this fix. Linus has picked it up (inclusive the typos to the x86_fsgsbase_read_task() function name ;-), it's now upstream under: 8ab49526b53d: ("x86/fsgsbase/64: Fix NULL deref in 86_fsgsbase_read_task") By the fixes tag it looks like this should probably be backported all the way back to ~v4.20 or so? Thanks, Ingo