Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp1319695pxa; Sat, 15 Aug 2020 15:51:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwFARYQPI2GstxLiSRNtjcRTKs2EiHmNXxpkonvkGtNwC4sASjUO2B+ccAc9ea2E0b9bMDa X-Received: by 2002:a05:6402:1846:: with SMTP id v6mr8634298edy.179.1597531878406; Sat, 15 Aug 2020 15:51:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597531878; cv=none; d=google.com; s=arc-20160816; b=Zq9Rnk+fMXcLJsF26QBNB8as0KwHLvzXyMe8FIh9sVngDAjgYjWANYipRQGjHFnFFZ L8lQVtms0FEOnCmEwz6DCWx3iN16gMpi9g1Z6HlBAHDbr4AreqT8pj3vUx2Xa/ruv5a2 nCf4eoPSYIpJFWyavGrRfjf5oQIUAEV1iTYoGXB8fAb+1xFJqPfuBX5x7aLsxY8+pIwn pRY/woBFKF32uTLQVA9I3RHugkekDjVPi/xXt2r7IuTzcjMOlAzPkEIyVIy10pE+OGvX 3RWLT8+GhXhCK4V3Xa8rq7DqgNcmFeFOThqxGWEWf4BWB48YEPz6dRiJaNHjDT/PkNqr x/Dw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=e/PEP2fPGVJZDvYBhPIz0dgd1WlwbhRiAk/AoGfsIco=; b=fj6P2ZB4DU5c8kBzK66lIaeds1t0YC0lUDFTJ+yW8pBl4O3T+/dGqIMzdMmFN1h1cn qrGBQnvo5o6i+6nGVAEy4Cu5mMBJhBDzpg1KoH9KzLyA/pwAywpknRNBYYNWeXFmtLF3 2+fHbJnCpMPwKYJ+xWNCRskFm/plmgS9yii59FXDeuJRbKdC7JaWbMHWgQRpwpAb4crV puKKRUOBUMyhHSYm64W6ZT4bDflCmeRVaYEAhEyKelpJMbW1LZFQgY10MRESmLySQLI2 9YK0YZmHT35eX3xo43uKhYd3BQaaV3RBIoNuwsdk3XNLPvzc7feRZSBUAGm0jP5XLAwc 9GzQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j14si7556041ejd.406.2020.08.15.15.50.56; Sat, 15 Aug 2020 15:51:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728830AbgHOWuO (ORCPT + 99 others); Sat, 15 Aug 2020 18:50:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55290 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726729AbgHOWuN (ORCPT ); Sat, 15 Aug 2020 18:50:13 -0400 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:12e:520::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4B0FEC061786; Sat, 15 Aug 2020 15:50:13 -0700 (PDT) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1k74zw-0005Tr-N6; Sun, 16 Aug 2020 00:50:01 +0200 Date: Sun, 16 Aug 2020 00:50:00 +0200 From: Florian Westphal To: Tong Zhang Cc: pablo@netfilter.org, kadlec@netfilter.org, fw@strlen.de, davem@davemloft.net, kuba@kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] netfilter: nf_conntrack_sip: fix parsing error Message-ID: <20200815225000.GI1660@breakpoint.cc> References: <20200815165030.5849-1-ztong0001@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200815165030.5849-1-ztong0001@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Tong Zhang wrote: > ct_sip_parse_numerical_param can only return 0 or 1, but the caller is > checking parsing error using < 0 Reviewed-by: Florian Westphal