Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sun, 16 Aug 2020 09:50:47 +0200
Message-ID: <s5hh7t3qbag.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Brent Lu <brent.lu@intel.com>
Cc:     alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
        Amadeusz =?UTF-8?B?U8WCYXdpxYRz?= =?UTF-8?B?a2k=?= 
        <amadeuszx.slawinski@linux.intel.com>,
        Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>,
        Kai Vehmanen <kai.vehmanen@linux.intel.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: hdac_hdmi: support 'ELD' mixer
In-Reply-To: <20200814083436.19845-1-brent.lu@intel.com>
References: <20200814083436.19845-1-brent.lu@intel.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, 14 Aug 2020 10:34:36 +0200,
Brent Lu wrote:
> @@ -1784,6 +1913,16 @@ int hdac_hdmi_jack_init(struct snd_soc_dai *dai, int device,
>  		}
>  	}
>  
> +	/* add control for ELD Bytes */
> +	err = hdac_hdmi_create_eld_ctl(component, pcm);
> +	if (err < 0) {
> +		dev_err(&hdev->dev,
> +			"eld control add failed with err: %d for pcm: %d\n",
> +			err, device);
> +		kfree(pcm);

pcm is allocated vida devm_kzalloc(), hence you shoudn't free it
explicitly.


thanks,

Takashi