Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp1531644pxa; Sun, 16 Aug 2020 01:47:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzIjkn4iW8O/56WuIwWYE9wYaZ0HCmqssrHO0qntE+iQvH6o6CheqGA480Gul3REK/FJDv5 X-Received: by 2002:aa7:c1ca:: with SMTP id d10mr10379221edp.261.1597567652358; Sun, 16 Aug 2020 01:47:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597567652; cv=none; d=google.com; s=arc-20160816; b=nt8z8uDkcvccQQNpoyMbwIdEdekEQD+FjqMheXe72ZIDmJOHyQu+iJMhbsPuwJ3Rke NTPvFYhg9M6oH/irRS1OFtEMIVtO7MBqqfHqR54ZpYvVbxHZHqeoJ4+xER/JmTH1JpKN 6IEhA1QNTjwdOIruRYjsfmrEBnt7GmptLdk3+Z6AZ1MTz9vyv8awDBWGNF4cwcxBKQd/ gqPvIfZQhZ02m5x3LaI2v4LeEq+Tpbxz/BhU4814ueflB42qj4Izplo7JZpdJ7Vjq8fP yWurGRiIHBZkbcnpNcHXT+8y34srxbsPrYLDG+tDAkS4bA7/fKHRr26Gsu4Xp8Z+PrxO esmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=pRWlFqSXyBMqW4W+HoorwhwVNTD8oOLA4egybfb7lrY=; b=b/pfZE13NQ4CtEMUbL2vQs7E0FSp3WKNe8vxVh+BcGm1qMm7f0WZhcfr8n1LvZn+EE aR/dkLjeYv3oHwjNTn5aaGwD562rlpnq2PbUUhFF/7vRVmx7WKmd0tHgXXSzXymUjtHZ Cf8ClkEU1ut4UmwvqU/p6/W4TwwUXDy8Kqr9lF7ONCfMXfi186TJGvPqG+wtLagqGN6W /3B/Y9pz6TcFjGuyO8MiszQCEPWaLehwiDGLrKVwFMVMJVGkpOP01iUXzTFHbPa+1WuI l95wedzzvsy1y3Zr8EP9iJk5Wur7vgALl2a17ItabwNBXFei+VNCW6AwTPqz61UwLQzd DJyA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Y3Z2ilzQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f24si8458602edm.305.2020.08.16.01.47.09; Sun, 16 Aug 2020 01:47:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Y3Z2ilzQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726208AbgHPH4I (ORCPT + 99 others); Sun, 16 Aug 2020 03:56:08 -0400 Received: from mail.kernel.org ([198.145.29.99]:58490 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725986AbgHPH4H (ORCPT ); Sun, 16 Aug 2020 03:56:07 -0400 Received: from pali.im (pali.im [31.31.79.79]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0072F2065C; Sun, 16 Aug 2020 07:56:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597564567; bh=WBoK5fgAJLyzBGCPs2ZM73uEvs9Y4AnzIU1vghJTqvA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Y3Z2ilzQuS9+MNNMUvFYwb4DdOAsh2dR6Kldq4ez4/qBX2pBUYOv/bA+voMZpnaA9 MooFmMorP1YSsum1MX1PuYoC/gsQ0nFG93G4bV2ijWzS6gSoZw+BNSV1dQCD+1U1QQ dXrXun6sIQTpMEezw0j/hSPvrlI0WvFjSmQY1uO4= Received: by pali.im (Postfix) id 677667BC; Sun, 16 Aug 2020 09:56:04 +0200 (CEST) Date: Sun, 16 Aug 2020 09:56:04 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Konstantin Komarov Cc: "viro@zeniv.linux.org.uk" , "linux-kernel@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" Subject: Re: [PATCH] fs: NTFS read-write driver GPL implementation by Paragon Software. Message-ID: <20200816075604.nx62kg5qz6ddp6gl@pali> References: <2911ac5cd20b46e397be506268718d74@paragon-software.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2911ac5cd20b46e397be506268718d74@paragon-software.com> User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 14 August 2020 12:29:01 Konstantin Komarov wrote: > This patch adds NTFS Read-Write driver to fs/ntfs3. > > Having decades of expertise in commercial file systems development and huge > test coverage, we at Paragon Software GmbH want to make our contribution to > the Open Source Community by providing implementation of NTFS Read-Write > driver for the Linux Kernel. > > This is fully functional NTFS Read-Write driver. Current version works with > NTFS(including v3.1) normal/compressed/sparse files and supports journal replaying. > > We plan to support this version after the codebase once merged, and add new > features and fix bugs. For example, full journaling support over JBD will be > added in later updates. > > The patch is too big to handle it within an e-mail body, so it is available to download > on our server: https://dl.paragon-software.com/ntfs3/ntfs3.patch > > Signed-off-by: Konstantin Komarov Hello Konstantin! I agree with David that patch is big and could be split into smaller patches per file, like exfat driver was reviewed. When you send a new version of ntfs driver, please add me to CC and I will try to find some time to do code review. Thanks!