Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp1667064pxa; Sun, 16 Aug 2020 06:54:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz+WIv2b0OC+oWAS9htr6dIvoBYbIeh8G0vCGXEiaid4hLN2GwBoS0xEKiMQm7kUc+Y45UB X-Received: by 2002:a17:906:6d54:: with SMTP id a20mr11471382ejt.501.1597586091901; Sun, 16 Aug 2020 06:54:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597586091; cv=none; d=google.com; s=arc-20160816; b=kYfa3g303lTFqL98p+y5v6JPkbjcC+8RxYXF0FzuiaBhx8115/WpHZLYqSpJlmPPnN uI1r8rAzIjeB/qINo92mAKM1aMUhYsM0LP3lmHOFa/ixIzx7gYgwIM/yNaQ/przDrW2B IP49r/BosFsRVA9Oiwt+TcBzRWxpUYpVQ2Ryhf/SUFb3GM/oZyigiF320fpwgIOkToJe 2TW7XEmooCQv4qatnvGBqOQMO6nu2cQUunMjPfsBMbGIHK7UMkiD2W+y0iRTnR5qkAjS fRlKhjznfxn+hEp1iUcOYeL8azLXyRMtRgr1MM4YI+/0MQbnKHZOzPcemCstBo7SFida TAGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=XGLoJ7O+V6ZZmFm5YMkauKx8SWaJ05qtX0s9I5/GzsQ=; b=oJDfeKNsxTkbEL4d1E2cEUNghUdcBvXAnVdP2yq1tOsYTHCPZOw71/9EVf535FcDJl AQHVAJp0E/RXD8VH8HofhLPT/8aTcj11bg3+k3jRlokzIHjsTvmwPw2f9839ageAdrWA 3n+8XLVNgHyTDlcB5PzyN75Shl7ILs6+G+ydMAAwpvugjlpP9m2pWuOBBU0owZ9fsOBd 5CGSnW1ZbzD04BFZfPYVV2j/aCjFhy5SvJrwWePaKFvRHOF1DvAgr7l9WxjXLIAF93DU A28Riflk7YLadJ/Uf+BxA+hmpZ3cgp++AMRN3F8kgBdyXissvHeZaOncxlO8kjxHz2H0 +lsw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="Zj4/69PM"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o3si9166227ejm.346.2020.08.16.06.53.59; Sun, 16 Aug 2020 06:54:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="Zj4/69PM"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728670AbgHPMx6 (ORCPT + 99 others); Sun, 16 Aug 2020 08:53:58 -0400 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:50842 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725843AbgHPMxv (ORCPT ); Sun, 16 Aug 2020 08:53:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1597582429; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=XGLoJ7O+V6ZZmFm5YMkauKx8SWaJ05qtX0s9I5/GzsQ=; b=Zj4/69PM/ok61cQD9hxaj0fZzbu3dunDN6+5bE4XK5eMJdoRZFJcNjamcUPCN4mqa3OPZL Yyz9k+48w+w+YvlLhhvzhrY8mu3DS3+NxD8i8ruQfKxeztvCNd4EYpcdBk2IQNxLDp/ItO GZouSiwmkd2Lkglx5oQsG4AxCLZHEBY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-103-kB4Cn_1BNAaaJmFGj8OAbg-1; Sun, 16 Aug 2020 08:53:44 -0400 X-MC-Unique: kB4Cn_1BNAaaJmFGj8OAbg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 36802801A9D; Sun, 16 Aug 2020 12:53:43 +0000 (UTC) Received: from t480s.redhat.com (ovpn-112-43.ams2.redhat.com [10.36.112.43]) by smtp.corp.redhat.com (Postfix) with ESMTP id 108476E72F; Sun, 16 Aug 2020 12:53:33 +0000 (UTC) From: David Hildenbrand To: linux-kernel@vger.kernel.org Cc: virtualization@lists.linux-foundation.org, linux-mm@kvack.org, David Hildenbrand , Andrew Morton , Baoquan He , Jason Wang , "Michael S. Tsirkin" , Michal Hocko , Mike Kravetz , Mike Rapoport , Mike Rapoport , Pankaj Gupta , Qian Cai Subject: [PATCH v5 0/6] mm / virtio-mem: support ZONE_MOVABLE Date: Sun, 16 Aug 2020 14:53:27 +0200 Message-Id: <20200816125333.7434-1-david@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org For 5.10. Patch #1-#4,#6 have RBs or ACKs, patch #5 is virtio-mem stuff maintained by me. This should go via the -mm tree. --- When introducing virtio-mem, the semantics of ZONE_MOVABLE were rather unclear, which is why we special-cased ZONE_MOVABLE such that partially plugged blocks would never end up in ZONE_MOVABLE. Now that the semantics are much clearer (and are documented in patch #6), let's support partially plugged memory blocks in ZONE_MOVABLE, allowing partially plugged memory blocks to be online to ZONE_MOVABLE and also unplugging from such memory blocks. This avoids surprises when onlining of memory blocks suddenly fails, just because they are not completely populated by virtio-mem (yet). This is especially helpful for testing, but also paves the way for virtio-mem optimizations, allowing more memory to get reliably unplugged. Cleanup has_unmovable_pages() and set_migratetype_isolate(), providing better documentation of how ZONE_MOVABLE interacts with different kind of unmovable pages (memory offlining vs. alloc_contig_range()). v4 -> v5: - Rename "mm/page_isolation: don't dump_page(NULL) in set_migratetype_isolate()" to "mm/page_isolation: exit early when pageblock is isolated in set_migratetype_isolate()" as I was messing up things while reshuffling patches (dump_page(NULL) could never happen, only the WARN_ON_ONCE()) -- Clarify in the description that this is currently a cleanup only - "mm: document semantics of ZONE_MOVABLE" -- Clarified in the memory hole case, that kernelcore/movablecore is required to create such rare special cases v3 -> v4: - "mm/page_isolation: drop WARN_ON_ONCE() in set_migratetype_isolate()" -- Fix typo in description - "virtio-mem: don't special-case ZONE_MOVABLE" -- Add more details why we initialli special-cased ZONE_MOVABLE (via MST) - "mm: document semantics of ZONE_MOVABLE" -- Rephrase some parts of documentation (via Mike) v2 -> v3: - "mm: document semantics of ZONE_MOVABLE" -- Fix a typo v1 -> v2: - "mm/page_isolation: don't dump_page(NULL) in set_migratetype_isolate()" -- Move to position 1, add Fixes: tag -- Drop unused "out:" label - "mm/page_isolation: drop WARN_ON_ONCE() in set_migratetype_isolate()" -- Keep curly braces on "else" case - Replace "[PATCH v1 5/6] mm/page_alloc: restrict ZONE_MOVABLE optimization in has_unmovable_pages() to memory offlining" by "mm: document semantics of ZONE_MOVABLE" -- Brain dump of what I know about ZONE_MOVABLE David Hildenbrand (6): mm/page_alloc: tweak comments in has_unmovable_pages() mm/page_isolation: exit early when pageblock is isolated in set_migratetype_isolate() mm/page_isolation: drop WARN_ON_ONCE() in set_migratetype_isolate() mm/page_isolation: cleanup set_migratetype_isolate() virtio-mem: don't special-case ZONE_MOVABLE mm: document semantics of ZONE_MOVABLE drivers/virtio/virtio_mem.c | 47 +++++++------------------------------ include/linux/mmzone.h | 35 +++++++++++++++++++++++++++ mm/page_alloc.c | 22 +++++------------ mm/page_isolation.c | 39 ++++++++++++++---------------- 4 files changed, 66 insertions(+), 77 deletions(-) -- 2.26.2