Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp1712396pxa;
        Sun, 16 Aug 2020 08:24:33 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJzeeiSLingGlJTqYRxhK3UB7QAIHb9s2JKyRzn1Dcjm8cKuwm0Jt9IYDs+5wYFYpUQwSPf/
X-Received: by 2002:a17:907:2067:: with SMTP id qp7mr10959608ejb.378.1597591473782;
        Sun, 16 Aug 2020 08:24:33 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1597591473; cv=none;
        d=google.com; s=arc-20160816;
        b=RqjJZkTeC4hDFWwgZT48eEca26KNS8G41tQ7agRA4Pj1zoVwDzsFiW55aUnRvBzIuP
         EJm2SkjF6zOChjjlL7tNljOCUHKoQgqKZo7uIX19FukdAzqnFGlUVkB4KiWLu4F3zXeS
         4ztGAlL2eDQMrv7Jrk0rpCeMUJrplxGQrz6bx7FE1ymoa1jCzXJYwI2TroZuMaHmkjzY
         9VDcoOLV5tVtIWgcJTsi8l8aHo1uMJ9OCZ1fMegQRbYGNjGKM8quJMr9rk0x6zk1v9OJ
         iaYDZFbsUE9f2k4yNBtHYborrMc9QrCZqpbBSfcZG2S/0kdo9AtWu3i2gGtogaxU5lUK
         xDHg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:cc:to:subject:message-id:date:from
         :in-reply-to:references:mime-version:dkim-signature;
        bh=5JJqt1APXPHxbtVoU6OKZdS8Pw8Z7UXTRp846o51gBs=;
        b=fsuXZBX6Qi4ILaK2DXrchNFZ/rKvWq8fmX9ri0yQ9nvURe9kYfPsA378H8vFJ4QeAV
         +bynOYsjRbJAdj6/AK1VOsNw67potBV+0Sy+XzFjJuEIoDZbj7u85+BK6RvvAvXXCV+3
         hsbYh+8rP7cJvOgR/oabkhEPmlDez4/wLFIHm2gyozH1oQAmnvZM8oDDXZxPWnotFeAG
         6BgV47BMeomUoh0iVSlEc6YmVe+MBKE209WzsYE7rW2ZL4SzbUXpLnuxAjiHVlaDFQf4
         FLj0+yp3CmzclveuUi0qXxaXTpZ6y+axoY5RnaNLl3HUvRNGK2cGcr640Rn5wcqO7dxl
         diEA==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=16o+su7N;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id x7si9134862eds.105.2020.08.16.08.24.10;
        Sun, 16 Aug 2020 08:24:33 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=16o+su7N;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1728555AbgHPO6J (ORCPT <rfc822;kkoh.linux@gmail.com>
        + 99 others); Sun, 16 Aug 2020 10:58:09 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33386 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1727950AbgHPO6E (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 16 Aug 2020 10:58:04 -0400
Received: from mail-qt1-x843.google.com (mail-qt1-x843.google.com [IPv6:2607:f8b0:4864:20::843])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3DA0AC061385
        for <linux-kernel@vger.kernel.org>; Sun, 16 Aug 2020 07:58:03 -0700 (PDT)
Received: by mail-qt1-x843.google.com with SMTP id x12so10619850qtp.1
        for <linux-kernel@vger.kernel.org>; Sun, 16 Aug 2020 07:58:03 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=baylibre-com.20150623.gappssmtp.com; s=20150623;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=5JJqt1APXPHxbtVoU6OKZdS8Pw8Z7UXTRp846o51gBs=;
        b=16o+su7NJwI6TUCXIeseG3eoCdstKxdg/xp9hg5LxSCRLM0KuKRs5sFTgTnohECrBU
         X3YaXEBUUucPQ2XF602mJ8MgtUkuBGLDo/Z8ZHQRylzHvcvTmoZVlA5wDugnWaniZT4p
         Ej54DVgjZB5WQgPquRfZ7vayxaTpJO7dub5u8xV05SEPVxyi3cvGrrnIi2NlbjEoqGjo
         dtnJtBXG5eD28eajaod3WF8Z1ScJqIDk80jP8/3ILoVCmAQro8aaW/FCpIv6BfcB68nj
         oR00WuFuznFCSuDeU5SssNrfmdM1Ll39goEqnCcIL1N9RX/+1VTmCkUk9zwiaBOtwMWj
         sQFA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=5JJqt1APXPHxbtVoU6OKZdS8Pw8Z7UXTRp846o51gBs=;
        b=Do1Ez4Mll4vZjT83PJdmmviFEJ6E8vrGwhOP581PQnlfTk8b2zsWHKYXzmcjMHs8WS
         sO4dWutTAUTTTbz/QGf1HOJbjdXRC16mgmhAn4TqMqXZ73vEhiTZjBPPuBika7V7JCGt
         mLwWbeXELkc8g8AUO7+HSnMYDPjJHCHTmHkZKqpyVn4iUsLus9VmTKMSDFmw57PDoQTV
         +vdI3Erc+Y+VfOhknzfNjmU2AE4LzVHavoKbJ7TkUep0/OYzRH0DO2wlbvt+JgldiaNi
         KKn/VTEtsxaVxhHUtSPJJaKNKm94zAJpWs4pyZuJ8KhI3vILhgXJew+hJQ+BYVlbQdUY
         pfFA==
X-Gm-Message-State: AOAM531EBNUdgeQoO8ocp2Zj3dZxmja8kR8fVb59L2kiC7sakl3quNR4
        FfbhLGR6X7wrDPsTu9ihT9OxLDdHPJ69p/emqjSgl0NwvaI=
X-Received: by 2002:ac8:6952:: with SMTP id n18mr9620818qtr.27.1597589883110;
 Sun, 16 Aug 2020 07:58:03 -0700 (PDT)
MIME-Version: 1.0
References: <20200814030257.135463-1-warthog618@gmail.com> <20200814030257.135463-12-warthog618@gmail.com>
In-Reply-To: <20200814030257.135463-12-warthog618@gmail.com>
From:   Bartosz Golaszewski <bgolaszewski@baylibre.com>
Date:   Sun, 16 Aug 2020 16:57:52 +0200
Message-ID: <CAMpxmJVFJBGDwLB3+8y9dk4pQkf=T+9igdMdAbvYnY8jT4df8Q@mail.gmail.com>
Subject: Re: [PATCH v4 11/20] gpiolib: cdev: support GPIO_V2_LINE_SET_VALUES_IOCTL
To:     Kent Gibson <warthog618@gmail.com>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        linux-gpio <linux-gpio@vger.kernel.org>,
        Linus Walleij <linus.walleij@linaro.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Aug 14, 2020 at 5:04 AM Kent Gibson <warthog618@gmail.com> wrote:
>
> Add support for the GPIO_V2_LINE_SET_VALUES_IOCTL.
>
> Signed-off-by: Kent Gibson <warthog618@gmail.com>
> ---

Just the same thing as with patch 10/20 regarding the
_locked/_unlocked suffix. I don't have other comments, looks good to
me.

Bart

[snip]