Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp1713512pxa; Sun, 16 Aug 2020 08:26:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyjWqivfMoNes4tC++11pPG7Ce+I0Yo+ohFG8FMio+dj/G6F+0jetsHS4ZqbYibkmen/xwc X-Received: by 2002:aa7:dbd9:: with SMTP id v25mr11603113edt.137.1597591617549; Sun, 16 Aug 2020 08:26:57 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1597591617; cv=pass; d=google.com; s=arc-20160816; b=XxhjsPXVTWj30P4/batQNPNs0sMysgVrCgI+2zt3KoKMo0uXggzxtnYgk6Kv/9MAV2 UQKD9agtrj4b+MMNWTUtogRjSpB7IISe7aw0ztPoQ+HyeEa5oxgz4giKmJ5zefA9ecxo cLCt7W89UE4jGpWMNmBMUYg2Z7kSuLN9JiE1bltWo2lo2RKKFiyHU5fmMUa2+b2fqsFc /U1B9l89Y3qlAbFcZ8IuO0iFVPIE0gX3WMBfvrGjLSCz4VsqOElyqAKs6dCuijfrpVD6 KCOfm9Cd1Uaf+20I17cZgqGrKPLUUAW0hDhx7MinPjE7DxuXEMn1odJYzFFriDtOXkfH 2PUw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :content-language:accept-language:in-reply-to:references:message-id :date:thread-index:thread-topic:subject:to:from:dkim-signature; bh=AlCHmLFM6R31COdLu1T9g94az2qqp4D67Jcd9oSWWSg=; b=e50CfHkZFem/vDoQ48Dszdywx3rG7bm6X3lVM8VV0iBOaiKHOAJWv/iEgyMDmc6rr9 aE+gZ87FTXBMnGvdUBrQM0hf9f50XU90gyDmv4CR8pD/joBZo39wfmxaBXpdbX6k/NCq JcyD4BunT/YEEZiydDXDflejvOlwAFVt+OVfTpUKuJCVN1THpDOE6zV//7R3i9rfZ7Ii sqzic2Rbdx4JBcRZFjocre4ddypQic/zLyMF8Z3q7NYXz7ptOjfKfHQ+gDGdn9+Fl+RF pf8G8NEEl/KoADJkQJCNZ9GMhPgylNinn7z+l0n6Bs49U5/zfQR4vhkROpBqgmPrwCq1 MIvg== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@habanalabs.onmicrosoft.com header.s=selector2-habanalabs-onmicrosoft-com header.b=cD2JhdXL; arc=pass (i=1 spf=pass spfdomain=habana.ai dkim=pass dkdomain=habana.ai dmarc=pass fromdomain=habana.ai); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=habana.ai Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h1si9405650edv.192.2020.08.16.08.26.34; Sun, 16 Aug 2020 08:26:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@habanalabs.onmicrosoft.com header.s=selector2-habanalabs-onmicrosoft-com header.b=cD2JhdXL; arc=pass (i=1 spf=pass spfdomain=habana.ai dkim=pass dkdomain=habana.ai dmarc=pass fromdomain=habana.ai); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=habana.ai Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729079AbgHPPYx (ORCPT + 99 others); Sun, 16 Aug 2020 11:24:53 -0400 Received: from mail-db8eur05on2099.outbound.protection.outlook.com ([40.107.20.99]:13792 "EHLO EUR05-DB8-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728346AbgHPPYt (ORCPT ); Sun, 16 Aug 2020 11:24:49 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DheZQYolNl2J9PZ+bbjilZU2es5YxBIZR0nI34OGko9GaF88LLr4gEIuFnQOfQih9nu3YdwvOIdPHtwz//CG3z6kxN/YmOp9hEgfuTz7usR19MraO8Os4Txax8QGGj8c3BkaksbVwsIiuInAYj9bmkem9Umol8cdOFQEFnmw4PuylWpf11ppqpGb43JcLfbyQwCt9PjBlDNbHRXcgShrnXY/GmFqMImxw8n7no0WscoLiUpQKlM9hdqQZw/GuQFui9MQcx40VeVwkZJnSmesiVoAKEKEusYGj4jJbnOoGcN9C5VrRVGD3kFuyMs+8nwngd+pmBS6GkovJn9cXCvaWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AlCHmLFM6R31COdLu1T9g94az2qqp4D67Jcd9oSWWSg=; b=noMRqrKa9ttyb//21bv1BbuKO3yWp+gi06i8T9HBehPAZaYlTYApn2npEvsh+334LVzHUwMwQ27w9AZOyi6+47C+3SbmpayZ6A+BUy/Yq+CNCcD1lPKzTMQwQ+ZK/dQprKlDaKoV4gREOqX6hgPeh7rs5vRmI5U6KQw3s3AlSz4XU02pO7nC9kYXZNaILOtogabi5mDQgaCDy8ymJzcerTL0tWKp40MQRZfweY45CZs+X1OtUfVcrNLX7NzEd6v3L6vyK8+1/48Jw7XOCkdQGe0AZf7LJJel552KkimsfOOGMLRILkdnBm+eYZ4waBIV9hQjIWD+QSPq4vo2pEDzOg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=habana.ai; dmarc=pass action=none header.from=habana.ai; dkim=pass header.d=habana.ai; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=habanalabs.onmicrosoft.com; s=selector2-habanalabs-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AlCHmLFM6R31COdLu1T9g94az2qqp4D67Jcd9oSWWSg=; b=cD2JhdXLqmDWoY8uFqeJxArMxdeYYXjzm5G+Q85+Hb7lyE04Cqt2gKLm3gubkd5BHY3sbB5ecshxkoHKspLSYyrb33g6mV8f0buJnHHt0F21aCBXA6gHEheeMj0Dux5Vn4M145iFHhC/nZMJpuwIhP+l60EqReZtUFM4MNW+BFc= Received: from DB8PR02MB5468.eurprd02.prod.outlook.com (2603:10a6:10:ef::22) by DB3PR0202MB3547.eurprd02.prod.outlook.com (2603:10a6:8:11::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3283.18; Sun, 16 Aug 2020 15:24:28 +0000 Received: from DB8PR02MB5468.eurprd02.prod.outlook.com ([fe80::68d4:6b:d077:19a9]) by DB8PR02MB5468.eurprd02.prod.outlook.com ([fe80::68d4:6b:d077:19a9%4]) with mapi id 15.20.3283.027; Sun, 16 Aug 2020 15:24:28 +0000 From: Tomer Tayar To: Oded Gabbay , "linux-kernel@vger.kernel.org" , SW_Drivers Subject: RE: [PATCH 6/9] habanalabs: remove redundant assignment to variable Thread-Topic: [PATCH 6/9] habanalabs: remove redundant assignment to variable Thread-Index: AQHWcy3gitgkETMvJEyKANWQb1c/Pak6uhXQ Date: Sun, 16 Aug 2020 15:24:28 +0000 Message-ID: References: <20200815175938.16619-1-oded.gabbay@gmail.com> <20200815175938.16619-6-oded.gabbay@gmail.com> In-Reply-To: <20200815175938.16619-6-oded.gabbay@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=habana.ai; x-originating-ip: [46.116.96.176] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e1cf95fd-be58-4144-26fc-08d841f87763 x-ms-traffictypediagnostic: DB3PR0202MB3547: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1091; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: z18mdCTWFgVbot392B39nH8dGjLUKB33sIeWkoxbtw9Ja3wQOXJokcm6HVdvug1wEPghAfalYi7CTqihWTnQARP92G7jC4KBVeleF5NzyBJNUECHc3yoH4UIytmccf8KXAum48cVAXQJffz7ZPhsgtVW3CnbPvKwo4H+87akSFuHJOh71FqspZQX+0nzk5sSY4iC8rmSF15xKtduTmhAOtD02bVBTALN4WuqxaBePafW0eM5s8g8W04U/HYfa1yP2pzVgJc/sK65Yt0FrKeEoEadjikJ2YNbzFXEvamCBixWdqa7ChVwfy401H/i1e94xF8Fga2L5Tcf1mPSxHbO6A== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB8PR02MB5468.eurprd02.prod.outlook.com;PTR:;CAT:NONE;SFS:(136003)(376002)(346002)(366004)(396003)(39850400004)(7696005)(86362001)(110136005)(52536014)(76116006)(55016002)(6636002)(8676002)(316002)(9686003)(5660300002)(53546011)(6506007)(8936002)(66556008)(558084003)(33656002)(2906002)(66476007)(66446008)(26005)(64756008)(478600001)(66946007)(186003)(71200400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: UaLvNLSD9Y24+QgYsezXBZEd80mp/URsi55WFnmXAjE+yuFzz44hv1f/urWP0LyYk1OOEKcPCu1KvmF5YmFgYwJF1bUjOSZeMiSXin7SETYMOyMYrsI3gBmtgOhxqgJ0DAFmxugp8f3vtb7ximtBj1kXfVaxJz9n/MpK/H03yXIXH5fSaX16Et5usE5D2gufHEhEXCO73rFqD+M4UjYF2+2Z97GqS2pwD+wHlt9w+T8noDb+hAbOYm4ek6O8EGNwQ/6cQ/iH/8q7pXfaaBNXmcufXxR2u86EHURD/8PMnIDcN/i0cwJ8xfbi7o6WCMCVHhC0x3H16V5/RiUKFCrhYnoXQcv/Qkl9tt+onn/It0NRwmH/iKwjfCn/N1kGjTFuhf9pV38pTng2ULMl84I6yK1L1b6zazP5zAx68DSdtnu5/iH5QvcCFIdbXE20RKDwnzKLB1uv1D39GGU3gTTLJQ8NbO+qq5fNNxcZAjOWmGVEHzzfMEonTxSi9nDVTC95noipnP5LQF3ICKU1chzrrnVJLpEZhWsOB52TPlY6vyMhGAxYX98eVWkVDtNmnnVFBIKvzIhq+pAxrkwIQXC9ICbKLkvJkPGkbsmYX6daAwhVPojJuneOQmRX0iyKrTbDE7O6OyT+mCoReKUMLelKSw== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: habana.ai X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DB8PR02MB5468.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e1cf95fd-be58-4144-26fc-08d841f87763 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Aug 2020 15:24:28.1787 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 0d4d4539-213c-4ed8-a251-dc9766ba127a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: eXN5SQ2vi4336UuhcmFUQC69OSkW8kUnLLs7qMI7FRSBQ+EsA8ZWmLYuWtOm6XNYfwfyoaqczcdAHAgCSF1bmQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0202MB3547 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Aug 15, 2020 at 21:00 Oded Gabbay wrote: > new_dma_pkt->ctl is assigned a value and then is reassigned a new value > without the first value ever being used. >=20 > Reported-by: kernel test robot > Signed-off-by: Oded Gabbay Reviewed-by: Tomer Tayar