Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp1748185pxa; Sun, 16 Aug 2020 09:39:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwr1QFi2klnNQVFw46qRL+WC4+1LuRnYBJfZfpz7p/8CkQA8zEkYfpr8BpLQeKFIhGB1O44 X-Received: by 2002:a17:906:4c97:: with SMTP id q23mr11906225eju.11.1597595958369; Sun, 16 Aug 2020 09:39:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597595958; cv=none; d=google.com; s=arc-20160816; b=CODDJXWFUa+ad5rmmRpcq8Wx6pKToqxv/ZSAAFNwW3m2tXv+uPg/iP5RQQZjeLmUL5 XRXCSPoLgQrtb5gir3m/0EKJ0FzQOZgjlAqA/CwSh6IGL5FnXMN93GLiStStVZe2RgJE q4/qDYEoMpuW5U33gqmi4LlIuCe6VjDD4yU+qBqbhU3m2fOtOZ++CbnE0+EOTnkkgXfj IvQA7rPWi9e8XENaNZkgE3DG7nSY/7zJ+zOGFdBOtwJMsQF9m4PuctN2ISkpIE2DCr/P iD68jFJLwLXtIGzaczXklkZJHjFVRfO8l9PVWGliUteBQdEr/pZSxMKIpDudjz5slwBm nu6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :ironport-sdr:ironport-sdr; bh=1JjLNjAfKquXtYFbxf/SWID8X/y5sEUgq337HCcn5RU=; b=EzXvz7GXSBl2RZgB7PMT89pFacoAgPxyF+GUtNfswvohy6qvn3cwlAXJ94k67ZnEAE 9IMdol/R8qIeh5H+eRn+m+tcZpmD2Hs3R3G2hRh+BYlGmHkfvCtSEtCRg7OqZ54iLwJk 7+TnoACrPoSdvb6CGFHNFmouGHur6KyqmJebGxLT4Wv4uFSIGVRuoOaHW4Vp4MMNMe1d cdnXyJlh5/WBOLefUVj4qor3Fhpq+HzEMmgO4k/QB/vXYdiPJ+tPJulFtvLPia9Pa+PJ /0Y//KBJJvkTeJe7/Ju/J3tdANMliAcx60CMqi8PTjkyZjeMPeKHc2Cf1LdR9bcxPRvY W6ag== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g22si9224107edm.555.2020.08.16.09.38.55; Sun, 16 Aug 2020 09:39:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729124AbgHPQhY (ORCPT + 99 others); Sun, 16 Aug 2020 12:37:24 -0400 Received: from mga01.intel.com ([192.55.52.88]:39833 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728521AbgHPQhW (ORCPT ); Sun, 16 Aug 2020 12:37:22 -0400 IronPort-SDR: xUlgCDdBHjk3LZtCP/c+eIgOgg51rwAh91EVV/UMHoE16DceQSnEFyfPEHoSC3B7QM3GkOVoN+ iJQJdmYO76aw== X-IronPort-AV: E=McAfee;i="6000,8403,9715"; a="172649512" X-IronPort-AV: E=Sophos;i="5.76,321,1592895600"; d="scan'208";a="172649512" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Aug 2020 09:37:21 -0700 IronPort-SDR: JcU+Vw3unFudUkfQBfxRi0UJLyHutaheNeeeEkbdGjNqrfmnE9ajNKyG8pYghBtui63z/CHaKi OEtLFn8U88WA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,321,1592895600"; d="scan'208";a="326194330" Received: from tassilo.jf.intel.com (HELO tassilo.localdomain) ([10.7.201.21]) by orsmga008.jf.intel.com with ESMTP; 16 Aug 2020 09:37:21 -0700 Received: by tassilo.localdomain (Postfix, from userid 1000) id AD204301C4D; Sun, 16 Aug 2020 09:35:21 -0700 (PDT) Date: Sun, 16 Aug 2020 09:35:21 -0700 From: Andi Kleen To: Kajol Jain Cc: acme@kernel.org, peterz@infradead.org, mingo@redhat.com, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, pc@us.ibm.com, jolsa@redhat.com, namhyung@kernel.org, yao.jin@linux.intel.com, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, irogers@google.com, maddy@linux.ibm.com, ravi.bangoria@linux.ibm.com, anju@linux.vnet.ibm.com, kan.liang@linux.intel.com, nasastry@in.ibm.com Subject: Re: [PATCH v5 1/3] perf jevents: Add support for parsing perchip/percore events Message-ID: <20200816163521.GF1486171@tassilo.jf.intel.com> References: <20200816090719.72018-1-kjain@linux.ibm.com> <20200816090719.72018-2-kjain@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200816090719.72018-2-kjain@linux.ibm.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > @@ -321,7 +331,7 @@ static void print_events_table_prefix(FILE *fp, const char *tblname) > static int print_events_table_entry(void *data, char *name, char *event, > char *desc, char *long_desc, > char *pmu, char *unit, char *perpkg, > - char *metric_expr, > + char *metric_expr, char *aggr_mode, > char *metric_name, char *metric_group, > char *deprecated, char *metric_constraint) We should really define a struct now to pass the parameters, the callback prototype is getting ridiculous. I know it's my fault originally, but sorry you probably have to do it because you are touching it last. -Andi