Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp1870448pxa; Sun, 16 Aug 2020 14:15:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwlkfkNp35d5JNt8Eru0PKrIikucxjlXG3rdhtsY0AsHoKUUhu7nc20K73FZQehs99ZpAge X-Received: by 2002:a05:6402:33c:: with SMTP id q28mr11928773edw.275.1597612559113; Sun, 16 Aug 2020 14:15:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597612559; cv=none; d=google.com; s=arc-20160816; b=gG6IuqmZfyRlNYaTNRq72alVTCLbMapJX4nyevTRT1sj6co+QsASMPv5WpxUKyUKxM S60utzjHTX0TXnUQIcYDJ4TR+JHp0hxqFANp8x1J76J2XuCD1Yd0UwoKsEP3rcdON96s epY5YYBFJrB0xrvra9s3Qv0yZaIqFs6tfu3aIonbz65C7FpoLshTHH2ogowjb6muqViu 9zPMyTooiwyHlVBNHwCXvwXhKAFEmo44AqY2OB7l/303T+EUdzFFX7+2uWTM6t3nmmoS 2OF2MOy1JUVc7yhsLG4SHBAfv/L7/z2q+MfWh8VpnNdtYR6Za/GYU+xkxkeATbdkFr5g +JYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=KKeK5zAQAJzpxIpo0sqKBhAZOCFuqIRggBT87jL7VdY=; b=H/SEybh6jsJBCig/pB91QlRXU6/Ut7AZoFWNhATWPtyXTBlErI4NO3oSiZG/6sYYJf bSZeAUANVkFMWFfbjSjCn6K9yeFrlhW5Aqp5QyRkNVkDuX8LhEThzLHq7SYCbQxl5RHZ 069T7j23uNUbz3aaGBoyuiaR1pzHgb326DaF0H6OsW4ydmaA1pkttl2CaDpJ7Vj5dozD Np/GPE+gWTryMw7zvZWwj+corilXOr4poQUKLJK0Pz3xpozpHAcQ49IqcBbagJoAM3Q6 +LLY+OXEbAHEol2GXHFfmfy5WkApiZ9Rz3VdywXPX+R//8zcQZYFcPlnIerDoLvPDyLK 588g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g2si9373238edv.36.2020.08.16.14.15.35; Sun, 16 Aug 2020 14:15:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729833AbgHPUQM (ORCPT + 99 others); Sun, 16 Aug 2020 16:16:12 -0400 Received: from asavdk3.altibox.net ([109.247.116.14]:59988 "EHLO asavdk3.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728758AbgHPUQJ (ORCPT ); Sun, 16 Aug 2020 16:16:09 -0400 Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id 6259F20027; Sun, 16 Aug 2020 22:16:02 +0200 (CEST) Date: Sun, 16 Aug 2020 22:16:01 +0200 From: Sam Ravnborg To: Vaibhav Gupta Cc: Bjorn Helgaas , Bjorn Helgaas , Bjorn Helgaas , Vaibhav Gupta , Bartlomiej Zolnierkiewicz , Paul Mackerras , Russell King , Andres Salomon , Antonino Daplas , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-geode@lists.infradead.org, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, Shuah Khan Subject: Re: [PATCH v2 01/12] fbdev: gxfb: use generic power management Message-ID: <20200816201601.GA1426650@ravnborg.org> References: <20200810165458.GA292825@ravnborg.org> <20200810185723.15540-1-vaibhavgupta40@gmail.com> <20200810185723.15540-2-vaibhavgupta40@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200810185723.15540-2-vaibhavgupta40@gmail.com> X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=f+hm+t6M c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=kj9zAlcOel0A:10 a=pGLkceISAAAA:8 a=Q4VJyNBwd-cc_6aBFL8A:9 a=CjuIK1q_8ugA:10 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Vaibhav On Tue, Aug 11, 2020 at 12:27:12AM +0530, Vaibhav Gupta wrote: > Drivers should do only device-specific jobs. But in general, drivers using > legacy PCI PM framework for .suspend()/.resume() have to manage many PCI > PM-related tasks themselves which can be done by PCI Core itself. This > brings extra load on the driver and it directly calls PCI helper functions > to handle them. > > Although the gxfb driver does not have that extra load, Sorry, but I am lost here. If this drivers does not have the extra load that you describe here then I really cannot see why it is relevant for this driver to describe it. This is a seldomly touched driver - so it helps if the changelog when we finally touch the code is easy to parse. > we should switch to > the new generic framework by updating function signatures and define a > "struct dev_pm_ops" variable to bind PM callbacks so that we can remove > the legacy .suspend & .resume bindings. This part matches the patch - good. > Additionally, this helps us to > remove the unnecessary call to gxfb_suspend() in the event of Freeze and > Hibernate, as the function does nothing in their case. What I think you are explaining above is that the pci pm support will only call the suspend operation in case of suspend, so the state.event == PM_EVENT_SUSPEND can be dropped in gxfb_suspend(). For reference later I would prefer that this is explained a bit more explicit - not that the changelog needs update anyway. > > Signed-off-by: Vaibhav Gupta Patch looks good, but please give the changelog one more go. I have not checked other patches - but I assume they would benefit from a similar clarification. Sam > --- > drivers/video/fbdev/geode/gxfb.h | 5 ---- > drivers/video/fbdev/geode/gxfb_core.c | 36 ++++++++++++++------------ > drivers/video/fbdev/geode/suspend_gx.c | 4 --- > 3 files changed, 20 insertions(+), 25 deletions(-) > > diff --git a/drivers/video/fbdev/geode/gxfb.h b/drivers/video/fbdev/geode/gxfb.h > index d2e9c5c8e294..792c111c21e4 100644 > --- a/drivers/video/fbdev/geode/gxfb.h > +++ b/drivers/video/fbdev/geode/gxfb.h > @@ -21,7 +21,6 @@ struct gxfb_par { > void __iomem *dc_regs; > void __iomem *vid_regs; > void __iomem *gp_regs; > -#ifdef CONFIG_PM > int powered_down; > > /* register state, for power management functionality */ > @@ -36,7 +35,6 @@ struct gxfb_par { > uint64_t fp[FP_REG_COUNT]; > > uint32_t pal[DC_PAL_COUNT]; > -#endif > }; > > unsigned int gx_frame_buffer_size(void); > @@ -49,11 +47,8 @@ void gx_set_dclk_frequency(struct fb_info *info); > void gx_configure_display(struct fb_info *info); > int gx_blank_display(struct fb_info *info, int blank_mode); > > -#ifdef CONFIG_PM > int gx_powerdown(struct fb_info *info); > int gx_powerup(struct fb_info *info); > -#endif > - > > /* Graphics Processor registers (table 6-23 from the data book) */ > enum gp_registers { > diff --git a/drivers/video/fbdev/geode/gxfb_core.c b/drivers/video/fbdev/geode/gxfb_core.c > index d38a148d4746..44089b331f91 100644 > --- a/drivers/video/fbdev/geode/gxfb_core.c > +++ b/drivers/video/fbdev/geode/gxfb_core.c > @@ -322,17 +322,14 @@ static struct fb_info *gxfb_init_fbinfo(struct device *dev) > return info; > } > > -#ifdef CONFIG_PM > -static int gxfb_suspend(struct pci_dev *pdev, pm_message_t state) > +static int __maybe_unused gxfb_suspend(struct device *dev) > { > - struct fb_info *info = pci_get_drvdata(pdev); > + struct fb_info *info = dev_get_drvdata(dev); > > - if (state.event == PM_EVENT_SUSPEND) { > - console_lock(); > - gx_powerdown(info); > - fb_set_suspend(info, 1); > - console_unlock(); > - } > + console_lock(); > + gx_powerdown(info); > + fb_set_suspend(info, 1); > + console_unlock(); > > /* there's no point in setting PCI states; we emulate PCI, so > * we don't end up getting power savings anyways */ > @@ -340,9 +337,9 @@ static int gxfb_suspend(struct pci_dev *pdev, pm_message_t state) > return 0; > } > > -static int gxfb_resume(struct pci_dev *pdev) > +static int __maybe_unused gxfb_resume(struct device *dev) > { > - struct fb_info *info = pci_get_drvdata(pdev); > + struct fb_info *info = dev_get_drvdata(dev); > int ret; > > console_lock(); > @@ -356,7 +353,6 @@ static int gxfb_resume(struct pci_dev *pdev) > console_unlock(); > return 0; > } > -#endif > > static int gxfb_probe(struct pci_dev *pdev, const struct pci_device_id *id) > { > @@ -467,15 +463,23 @@ static const struct pci_device_id gxfb_id_table[] = { > > MODULE_DEVICE_TABLE(pci, gxfb_id_table); > > +static const struct dev_pm_ops gxfb_pm_ops = { > +#ifdef CONFIG_PM_SLEEP > + .suspend = gxfb_suspend, > + .resume = gxfb_resume, > + .freeze = NULL, > + .thaw = gxfb_resume, > + .poweroff = NULL, > + .restore = gxfb_resume, > +#endif > +}; > + > static struct pci_driver gxfb_driver = { > .name = "gxfb", > .id_table = gxfb_id_table, > .probe = gxfb_probe, > .remove = gxfb_remove, > -#ifdef CONFIG_PM > - .suspend = gxfb_suspend, > - .resume = gxfb_resume, > -#endif > + .driver.pm = &gxfb_pm_ops, > }; > > #ifndef MODULE > diff --git a/drivers/video/fbdev/geode/suspend_gx.c b/drivers/video/fbdev/geode/suspend_gx.c > index 1110a527c35c..8c49d4e98772 100644 > --- a/drivers/video/fbdev/geode/suspend_gx.c > +++ b/drivers/video/fbdev/geode/suspend_gx.c > @@ -11,8 +11,6 @@ > > #include "gxfb.h" > > -#ifdef CONFIG_PM > - > static void gx_save_regs(struct gxfb_par *par) > { > int i; > @@ -259,5 +257,3 @@ int gx_powerup(struct fb_info *info) > par->powered_down = 0; > return 0; > } > - > -#endif > -- > 2.27.0