Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp1929695pxa; Sun, 16 Aug 2020 16:39:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwuIdT2q4wLYaqO06SNXTtgJwfScUxyAOvTHX2UQBDChMhQC0hyWOyW59Wl2xk8cDnzMOD4 X-Received: by 2002:a17:906:e118:: with SMTP id gj24mr12240690ejb.219.1597621160656; Sun, 16 Aug 2020 16:39:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597621160; cv=none; d=google.com; s=arc-20160816; b=lzhEabKjESQ7buuyeF885MaUjU3Njl+kAKcmvWE+7HssIcwXxS4q4zy0NO5L77j3cU w1NE2EtYuLXFCeG3eOkFHlF97CH1m9ipZVVxAhOe9FqYWc1QMVWaJYUZoEY1ZJ1kIFJR nDNq0RbWOvJaGDJfrEJlTa7ctHsKZHwldWgF8MDdJ0PJPPIksBx+AH1ewjQkQ9a9QVM4 MwAMr9yG/wDMgWWNZvKF7jZEup9rKTcEzI8P+cAucqBMMjgKJzyIvYALM807UjQY67iU u6mK66GwfpPOPFJrsHIsVJaH3Pt7ED1Z/hi1YMSoKPZTaZUEojXeU4rIbx3Pz5fzE/2o 1CFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=bdd6W0wjQY4twkrWmtbJVXisCwlRs5bWGrujUBo8Nwk=; b=cvwhnz/Gpy7GAXG8VZT4Jfl05jBtrcXy1jMeAw8IwSLDalzO5aAKk6micNzQtDDM4Y Ebyi/OH4P0NFEPT1bwbMOUf3xzSlJXSUyxuJGg6QM0gwWAELOWqIbdfSnLZJ3Hd+pBmx Ap26x2qVesO9WJ2FERJfecyuQcL9CF5GsRxRMFrAHeUZ+HVXTN6ni5PT7/RLHH7g1Cni 14BzsSLayGLSqwx113Arv+GerIL+qftPFnTIWVDz4xXmhL0ZfWZa4Bw/t9yMeznzXFk5 TFrk5JHN7lBGmKzyShllsyW0OmKST40mThoDK0H8Zwg0QYgoh+ohTduTxfzRq3QRuZbT DNew== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@networkplumber-org.20150623.gappssmtp.com header.s=20150623 header.b=0PeI6Z1e; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z11si10036256ejm.102.2020.08.16.16.38.49; Sun, 16 Aug 2020 16:39:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@networkplumber-org.20150623.gappssmtp.com header.s=20150623 header.b=0PeI6Z1e; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729615AbgHPWqU (ORCPT + 99 others); Sun, 16 Aug 2020 18:46:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48384 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726127AbgHPWqR (ORCPT ); Sun, 16 Aug 2020 18:46:17 -0400 Received: from mail-pj1-x1042.google.com (mail-pj1-x1042.google.com [IPv6:2607:f8b0:4864:20::1042]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BA4D9C061786 for ; Sun, 16 Aug 2020 15:46:17 -0700 (PDT) Received: by mail-pj1-x1042.google.com with SMTP id d4so6772182pjx.5 for ; Sun, 16 Aug 2020 15:46:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=bdd6W0wjQY4twkrWmtbJVXisCwlRs5bWGrujUBo8Nwk=; b=0PeI6Z1ecW8efJzLFC+P8s1OAkzNy/oopjAlpwdzDP3uBqFkzuM0LC7h2EtUvfrtXA H+KPQMbotMmqQMr8P1MNXZgncjh6panXS2zxueg/UQK8u55yimqp19q2O1qmJlMboUES wLW9x5yYq18B2w7E+DUwjH6CG1fyL99VmUoHlERhAv6vJWsbsCoT7gU0ueR+003bhM/9 6BxU2M/y03cfgbvMrygaTCwgmXWcO/G1oRsWk6wGeZnbQEYF1aoqZUxh36DXDIGlGGkp xE8zJPR6Qzexcme83X93JWu1z7YWUiNLMlNDemL2M7hWnVysRVEhUhC1johnNvKiSW/P G34A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=bdd6W0wjQY4twkrWmtbJVXisCwlRs5bWGrujUBo8Nwk=; b=SbTgxPjkRb1zHkU6Xa4RIXLpZ4QesljFJ1HTCRFGWrWlxZXsSC5WDsum38St1n5E32 5RGBv19rE3XFgeWaympcx7v4a9puekSTQzaC4DTjS66aRVTk0eymoZkTdVscrsqOMbYF 3uDCZpvgbaSsLcECJcdCVmgLwiwiAF7fm9DrsNapbm4zDOiULi5JWhe0e4t4DtDSlimv Lss0QfwMJ5l70Riug1UlfdNfRVGxbmCzB84fkGWxNH5pd3LyjtKfPa+5yf9FF082L6gd jdw94K+U36qYo1/J4R03RosBXNLHPi6dSgC3iPILA/OGAb9PN3dmHyzXnToBiNLfuJgk WvJQ== X-Gm-Message-State: AOAM531GBV03r+Ld6EaOivEqiipEh2QtWq+MnrseMYSPbqs5KBPLsSpz 5/rXFu+sIo2IhFjN/5XOfwJR/w== X-Received: by 2002:a17:90a:24e9:: with SMTP id i96mr10393612pje.148.1597617977195; Sun, 16 Aug 2020 15:46:17 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id a24sm16311197pfg.113.2020.08.16.15.46.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Aug 2020 15:46:16 -0700 (PDT) Date: Sun, 16 Aug 2020 15:46:08 -0700 From: Stephen Hemminger To: Murali Karicheri Cc: , , , , , , , Subject: Re: [net-next iproute2 PATCH v4 1/2] iplink: hsr: add support for creating PRP device similar to HSR Message-ID: <20200816154608.0fe0917b@hermes.lan> In-Reply-To: <20200806203712.2712-2-m-karicheri2@ti.com> References: <20200806203712.2712-1-m-karicheri2@ti.com> <20200806203712.2712-2-m-karicheri2@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 6 Aug 2020 16:37:11 -0400 Murali Karicheri wrote: > + > + print_int(PRINT_ANY, > + "proto", > + "proto %d ", > + rta_getattr_u8(tb[IFLA_HSR_PROTOCOL])); Since this unsigned value, you probably want to use print_uint, or print_hhu. Also please put as many arguments on one line that will fit in 80 (to 90) characters. if (tb[IFLA_HSR_PROTOCOL]) print_hhu(PRINT_ANY, "proto", "proto %hhu ", rta_getattr_u8(tb[IFLA_HSR_PROTOCOL]));