Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] ata: ahci: use ata_link_info() instead of
 ata_link_printk()
To:     Xu Wang <vulab@iscas.ac.cn>, linux-ide@vger.kernel.org
Cc:     linux-kernel@vger.kernel.org
References: <20200817011854.9668-1-vulab@iscas.ac.cn>
From:   Jens Axboe <axboe@kernel.dk>
Message-ID: <e64e363a-55e5-7a71-ced7-fd28fc32aaa8@kernel.dk>
Date:   Sun, 16 Aug 2020 20:09:06 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20200817011854.9668-1-vulab@iscas.ac.cn>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 8/16/20 6:18 PM, Xu Wang wrote:
> Using ata_link_info() instead of ata_link_printk().
> 
> Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
> ---
>  drivers/ata/ahci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
> index 0c0a736eb861..9d72d907b4ee 100644
> --- a/drivers/ata/ahci.c
> +++ b/drivers/ata/ahci.c
> @@ -807,7 +807,7 @@ static int ahci_avn_hardreset(struct ata_link *link, unsigned int *class,
>  				(sstatus & 0xf) != 1)
>  			break;
>  
> -		ata_link_printk(link, KERN_INFO, "avn bounce port%d\n",
> +		ata_link_info(link,  "avn bounce port%d\n",
>  				port);

Why not collapse that into one line as well when making that change, as
it now fits just fine?

Apart from that, looks fine to me.

-- 
Jens Axboe