Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp2069951pxa; Sun, 16 Aug 2020 22:47:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyDTxRlextPWewRHHNWdypGU8C/NbE1c+J8xJvMVjlCLo+a5vYPw/i30Jd9tWbyuoXjq62y X-Received: by 2002:a50:fb14:: with SMTP id d20mr12936489edq.191.1597643275151; Sun, 16 Aug 2020 22:47:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597643275; cv=none; d=google.com; s=arc-20160816; b=slEZlkX2dMnufG/MWX0e3OQ00OirYaPlQCJr9pqeCtw1AIkZ/cbuqh6+vcXpbKATFn 5cF4D7DyHudRIHXLYoIF89lMnLNoCsRP1S3coXm5d3KrwfyaxJzhOoNCKwCVoVtQnFN6 rnzxMuINS8mKuWQkZUQgHkMoMD8QL5y9vRBJC4KuE33cHPXU74H8q+a8K+xAF6uxbw9m 3X8LwOM9tQEnjci8Py44mRhrjTPQVgSJi87pXz2QwQxRDTMx1ehgFF/Ym3z8s3Ad5OB+ QVPtJCPQj0jWYB6PYTGOhj1JgSy6WQ9zoo7AR42VCHnigAVtSGD/1pBPmiR2Bzwvlwet rDRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:cc:to:subject:from:message-id; bh=qTKKtppKrNXnUjuol8hW8jodkKMnUFz2YaJiAG+ZmMU=; b=hBszzo7dT5OpPIRJymbFgbH4CuVDXqjjrwQUb/jrXo2QoBW6gIlyOZISODeOVnco6/ ttxNJC4NTbwu2SrB8+WVmEHFzAihovZcqrPw0acOOksiI1dW2F1JvTWSgrGj1TDooVwE W0afq4BuxoAqmagw7UoQCv+iTmvpDvEUaRCuMvIIWv1WnjkDL68jRsPHDd/BVjhb0xK9 Wn7l6WVlsMOeKYSf/Ixto6lLfFoGtm8BEgSQ8Fxf74vWvPKfuYYVhHgTUDWHhOW8DW+X 74PN4uUCDyD5PV1bbYCXpgOAPczWJ9wmKUAplTlb/VLjHUtJEi5xH2iQTNsBNoqyf0QZ 6KgQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y18si10573769edu.518.2020.08.16.22.47.32; Sun, 16 Aug 2020 22:47:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726759AbgHQFqq (ORCPT + 99 others); Mon, 17 Aug 2020 01:46:46 -0400 Received: from pegase1.c-s.fr ([93.17.236.30]:2279 "EHLO pegase1.c-s.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726336AbgHQFqo (ORCPT ); Mon, 17 Aug 2020 01:46:44 -0400 Received: from localhost (mailhub1-int [192.168.12.234]) by localhost (Postfix) with ESMTP id 4BVNMb4NNFz9tytm; Mon, 17 Aug 2020 07:46:35 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024) with ESMTP id BF9zu5YcO0s8; Mon, 17 Aug 2020 07:46:35 +0200 (CEST) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 4BVNMb30Ryz9tytl; Mon, 17 Aug 2020 07:46:35 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 3DA2C8B772; Mon, 17 Aug 2020 07:46:40 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id H2O5bNNzOIr4; Mon, 17 Aug 2020 07:46:40 +0200 (CEST) Received: from po17688vm.idsi0.si.c-s.fr (po15451.idsi0.si.c-s.fr [172.25.230.104]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 1F1498B75B; Mon, 17 Aug 2020 07:46:40 +0200 (CEST) Received: by po17688vm.idsi0.si.c-s.fr (Postfix, from userid 0) id 0451D65CDD; Mon, 17 Aug 2020 05:46:39 +0000 (UTC) Message-Id: <9d11143d4e27ba8274369a926968756917584868.1597643153.git.christophe.leroy@csgroup.eu> From: Christophe Leroy Subject: [PATCH v1] powerpc/process: Remove unnecessary #ifdef CONFIG_FUNCTION_GRAPH_TRACER To: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Date: Mon, 17 Aug 2020 05:46:39 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ftrace_graph_ret_addr() is always defined and returns 'ip' when CONFIG_FUNCTION GRAPH_TRACER is not set. So the #ifdef is not needed, remove it. Signed-off-by: Christophe Leroy --- arch/powerpc/kernel/process.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/arch/powerpc/kernel/process.c b/arch/powerpc/kernel/process.c index ffbe79960c73..e86e28c28259 100644 --- a/arch/powerpc/kernel/process.c +++ b/arch/powerpc/kernel/process.c @@ -2096,10 +2096,8 @@ void show_stack(struct task_struct *tsk, unsigned long *stack, unsigned long sp, ip, lr, newsp; int count = 0; int firstframe = 1; -#ifdef CONFIG_FUNCTION_GRAPH_TRACER unsigned long ret_addr; int ftrace_idx = 0; -#endif if (tsk == NULL) tsk = current; @@ -2127,12 +2125,10 @@ void show_stack(struct task_struct *tsk, unsigned long *stack, if (!firstframe || ip != lr) { printk("%s["REG"] ["REG"] %pS", loglvl, sp, ip, (void *)ip); -#ifdef CONFIG_FUNCTION_GRAPH_TRACER ret_addr = ftrace_graph_ret_addr(current, &ftrace_idx, ip, stack); if (ret_addr != ip) pr_cont(" (%pS)", (void *)ret_addr); -#endif if (firstframe) pr_cont(" (unreliable)"); pr_cont("\n"); -- 2.25.0