Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751175AbWERFOz (ORCPT ); Thu, 18 May 2006 01:14:55 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751192AbWERFOz (ORCPT ); Thu, 18 May 2006 01:14:55 -0400 Received: from mx.pathscale.com ([64.160.42.68]:25760 "EHLO mx.pathscale.com") by vger.kernel.org with ESMTP id S1751175AbWERFOy (ORCPT ); Thu, 18 May 2006 01:14:54 -0400 Subject: Re: [openib-general] Re: [PATCH 35 of 53] ipath - some interrelated stability and cleanliness fixes From: "Bryan O'Sullivan" To: Roland Dreier Cc: Dave Olson , linux-kernel@vger.kernel.org, openib-general@openib.org In-Reply-To: References: Content-Type: text/plain Date: Wed, 17 May 2006 22:15:11 -0700 Message-Id: <1147929311.3094.16.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.6.1 (2.6.1-1.fc5.2) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 607 Lines: 16 On Wed, 2006-05-17 at 21:55 -0700, Roland Dreier wrote: > So with the "goto bail" you skip the code which does something with > the work you allocate, which means that you leak not only the work > structure but also the reference to the task's mm that you took. Wow. I have no idea where that extra "goto bail" came from. It's not supposed to be there.