Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v3] ata: use generic power management
To:     Vaibhav Gupta <vaibhavgupta40@gmail.com>,
        Bjorn Helgaas <helgaas@kernel.org>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Bjorn Helgaas <bjorn@helgaas.com>,
        Vaibhav Gupta <vaibhav.varodek@gmail.com>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
        Kai-Heng Feng <kai.heng.feng@canonical.com>,
        Christoph Hellwig <hch@lst.de>,
        "Gustavo A . R . Silva" <gustavoars@kernel.org>,
        Hans de Goede <hdegoede@redhat.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Prabhakar Kushwaha <pkushwaha@marvell.com>,
        Alex Shi <alex.shi@linux.alibaba.com>,
        =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= <mirq-linux@rere.qmqm.pl>,
        Thomas Gleixner <tglx@linutronix.de>,
        Jiri Slaby <jslaby@suse.cz>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Paul Gortmaker <paul.gortmaker@windriver.com>,
        Jia-Ju Bai <baijiaju1990@gmail.com>,
        Javier Martinez Canillas <javier@osg.samsung.com>,
        Zhang Rui <rui.zhang@intel.com>
Cc:     linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-kernel-mentees@lists.linuxfoundation.org,
        Shuah Khan <skhan@linuxfoundation.org>
References: <20200817092245.10478-1-vaibhavgupta40@gmail.com>
 <20200817092511.GA10566@gmail.com>
From:   Jens Axboe <axboe@kernel.dk>
Message-ID: <11190a0b-1009-caf8-9cbe-6cf296b614bf@kernel.dk>
Date:   Mon, 17 Aug 2020 07:06:03 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20200817092511.GA10566@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 8/17/20 2:25 AM, Vaibhav Gupta wrote:
> Hello,
> 
> I am working to upgrade power management framework support for PCI drivers, as
> my project under the Linux Kernel Mentorship Program.
> 
> The ultimate goal is to completely remove the legacy framework. And for this we
> need to remove ".suspend" and ".resume" pointers from "struct pci_driver".
> 
> The patch is doing the change for the same. The actual suspend() and
> resume() callbacks are defined in drivers/ata/libata-core.c and are exported.
> Which are then used by other files.
> 
> Thus removing those pointers, included 54 files in this patch. Although, the
> actual changes are done in few files only. The changes should work fine as I
> have done similar changes for other drivers too which made their way into the
> kernel. Still, tests on few ata devices are necessary.

Didn't we agree to split this up into separate patches??

> I tried but unfortunately, I couldn't find or arrange devices to test upon. I
> have added the authors of the previous commit(s) for respective drivers as
> recipients. It would be very helpful if someone can test it on a device.

Does qemu support any of the affected drivers?

-- 
Jens Axboe