Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp2552480pxa; Mon, 17 Aug 2020 12:32:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzvsAo7+7VL/QH8gs5ZkBoMtACqlo5ZSI9j7VVwiZxL6uF4qJYJPTUrpV16YUU9TXVwl7O7 X-Received: by 2002:a50:e809:: with SMTP id e9mr16731022edn.133.1597692764524; Mon, 17 Aug 2020 12:32:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597692764; cv=none; d=google.com; s=arc-20160816; b=Xkums1zj7zqlif5QySuYMUmQEizQ1r8BzxhHUJ7SPXYh2X1tXnrunmd3NYukVUCnyS haa3rHpmoQcfOVjlHaJwilYwr6EVdNlp6HoTgtFjhZ8jHsTD0DSanrLz/LaPhesVOm3e DW+xpsYA0Hpq1QWxwEjbWqsLIl0h/9ajZJrS57Wb1KCe1gBJ38f0tl+e8Lu9SuUwG67q y1WhvEpc9TROg3Oo8mj2sGy2Poqur5O+R2mCTgdf85w2JOnSE3QP8kXPN7pSo0JLXTca odmvSQRoSIeLH64NtIOmRywZft+m0xXcI5urgxR2J96jthF0+XeJh/jIMuFf92GDpRtn 0qXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=mHfXz7hBV1Ho6xEZtlBiMsuAZe/p0ge6BcHaOkJSrI0=; b=fy48EvP2zxEu1JnOSCxtWRWKlzhTYJ5QP6D6PvoVXd3oUMSunxmCExIYSiATyXU0OH UylGEzwzty+hUiI+F7ei1NdJ8j0ZQnIeeQXzENPguNsvqQshBFY7fKkXtudwEvfYbLO6 qz+D1tpuBTIQDhpwq38neaD7h54fDH5TiAPZGuz7nrZI35L/fQ4LeSatfyszB8URAX/R HIBfKFr4oEKT73NgKIa4ihkbAknVIH3tqV/jQdEWKNQ68Ba9NAlF8gVy77HjcjfUwpQC ramcgKADhhwBrlIcUQpzs16NQ/Xh9r1iviFGjTqTVOnyb+l71p+Yjd6KC94O6yUcfO4i 9aSg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=PqJ4AUhN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ly18si11632955ejb.247.2020.08.17.12.32.21; Mon, 17 Aug 2020 12:32:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=PqJ4AUhN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732253AbgHQT31 (ORCPT + 99 others); Mon, 17 Aug 2020 15:29:27 -0400 Received: from mail.kernel.org ([198.145.29.99]:59370 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730315AbgHQPcT (ORCPT ); Mon, 17 Aug 2020 11:32:19 -0400 Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AC03B207FF; Mon, 17 Aug 2020 15:32:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597678339; bh=2c4Yh95xvolsVljCfBjOgUgBnpWZevsxHtYN4hwUUuQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=PqJ4AUhNCRXS/VC9OkD2uAmeo4aNAyZFhtAwYnKIWQMQg4HzuxJiPNeQAvPUunzxL vszsyooQh67yVwKcN2epBRLBbjuWuZCRBZX1do/00btQNQEi18MWMihYss83LaZXfH JZrLi1BvTDV+8rUaibFK/+EgCNKN/gzQ0u1Bd7vo= Date: Mon, 17 Aug 2020 08:32:16 -0700 From: Jakub Kicinski To: Allen Pais Cc: jes@trained-monkey.org, davem@davemloft.net, kda@linux-powerpc.org, dougmill@linux.ibm.com, cooldavid@cooldavid.org, mlindner@marvell.com, borisp@mellanox.com, keescook@chromium.org, linux-acenic@sunsite.dk, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-rdma@vger.kernel.org, oss-drivers@netronome.com, Romain Perier Subject: Re: [PATCH 06/20] ethernet: chelsio: convert tasklets to use new tasklet_setup() API Message-ID: <20200817083216.5367f56a@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20200817082434.21176-8-allen.lkml@gmail.com> References: <20200817082434.21176-1-allen.lkml@gmail.com> <20200817082434.21176-8-allen.lkml@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 17 Aug 2020 13:54:20 +0530 Allen Pais wrote: > In preparation for unconditionally passing the > struct tasklet_struct pointer to all tasklet > callbacks, switch to using the new tasklet_setup() > and from_tasklet() to pass the tasklet pointer explicitly. > > Signed-off-by: Romain Perier > Signed-off-by: Allen Pais You need to adjust kdoc when you change functions: drivers/net/ethernet/chelsio/cxgb4/sge.c:2664: warning: Function parameter or member 't' not described in 'restart_ctrlq' drivers/net/ethernet/chelsio/cxgb4/sge.c:2664: warning: Excess function parameter 'data' description in 'restart_ctrlq' drivers/net/ethernet/chelsio/cxgb4/sge.c:2965: warning: Function parameter or member 't' not described in 'restart_ofldq' drivers/net/ethernet/chelsio/cxgb4/sge.c:2965: warning: Excess function parameter 'data' description in 'restart_ofldq'