Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: F5tImus1N4GBNkLglbn4Ctg0jpjMPxiUOoorL/f6LNyq2DNoR0/i2HMYRMSEPhTsMtRCemkfNo
 8f8eXV9S2lfA==
IronPort-SDR: bHApQlytgHJ6jq4V5bD6qw1c6k+ZY506s+KQj12iysHBxz7oQMzh1q8f6HPp17WTGF6XLOWLww
 Z9NOH4giSXgA==
Date:   Mon, 17 Aug 2020 14:44:41 +0300
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Joe Perches <joe@perches.com>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        Petr Mladek <pmladek@suse.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
        Rasmus Villemoes <linux@rasmusvillemoes.dk>
Subject: Re: [RFC PATCH] vsprintf: Add %pv extension replacement for
 print_vma_addr
Message-ID: <20200817114441.GK1891694@smile.fi.intel.com>
References: <09f11651f0e913e159b955ac447cd8cadf36cb0d.camel@perches.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <09f11651f0e913e159b955ac447cd8cadf36cb0d.camel@perches.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Aug 14, 2020 at 10:53:03AM -0700, Joe Perches wrote:
> There is a print_vma_addr function used several places
> that requires KERN_CONT use.
> 
> Add a %pv mechanism to avoid the need for KERN_CONT.

I like the idea, but I would accent the selling point to make code
(in the user call sites) nicer.

> An example conversion is arch/x86/kernel/signal.c
> 
> from:
> 	if (show_unhandled_signals && printk_ratelimit()) {
> 		printk("%s"
> 		       "%s[%d] bad frame in %s frame:%p ip:%lx sp:%lx orax:%lx",
> 		       task_pid_nr(current) > 1 ? KERN_INFO : KERN_EMERG,
> 		       me->comm, me->pid, where, frame,
> 		       regs->ip, regs->sp, regs->orig_ax);
> 		print_vma_addr(KERN_CONT " in ", regs->ip);
> 		pr_cont("\n");
> to:
> 		printk("%s"
> 		       "%s[%d] bad frame in %s frame:%p ip:%lx sp:%lx orax:%lx in %pv\n",
> 		       task_pid_nr(current) > 1 ? KERN_INFO : KERN_EMERG,
> 		       me->comm, me->pid, where, frame,
> 		       regs->ip, regs->sp, regs->orig_ax, (void *)regs->ip);

...

> +#else
> +	buf = string_nocheck(buf, end, "CONFIG_MMU=n", default_str_spec);
> +#endif

Can we avoid this spammy message? Really it's quite long and fills valuable
space in kernel buffer. I would rather print the hashed pointer as it's done
for the rest of %pXXX.

-- 
With Best Regards,
Andy Shevchenko