Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp2611598pxa; Mon, 17 Aug 2020 14:19:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzPl2RQOwhevstlj2dh70K5uUmttSPZFfTQU7ZC7HNkJnoc95sqfgTE0oWXDdOFJ8fMYVGR X-Received: by 2002:a50:954d:: with SMTP id v13mr17108268eda.337.1597699159023; Mon, 17 Aug 2020 14:19:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597699159; cv=none; d=google.com; s=arc-20160816; b=tIyJhkMhVuisDTtgeRSimbNbTIYU/qFeP4qJcV2bT0djNSzv3HcvDu7J8E0da2qsWh 49g1sZu2ynj6SUpo/z35QBvKKTtnx4refu0IbByZUOQWTBSNv0tMwG8976JNGFyhTrK+ wiIplI04wyvw9axqAoPEK2FMVoYPgWBkieEvTih93WMcyoAvdbReOV2eR/XNc3ApzUbk qRFW1yGihb6L3r7EGpXq9ajE7OoawPD467/9Rhg6WmYL1FnWHeL2itJyPZxBMvqqOPxY CPsZCLh1uUIdFzfULz404greX3Gr/xYE9Zkw7Uw+T3/N7irB73QfJO3HQeE9uMRGewAY okCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=njqeGiWtXLg5+jOB3X5A+tJKa5oFt5uNxmm5GwqrJhw=; b=AL6BRY1KAcKGOWDoZdD4j5L4BdchZaYAtSuWVOR807694f32mortcYJ8vgtfWNMdxa kYJbNWKAzp1d9diYgcinc3uge0P/4abUH9FjA7l1kNLrQ2sYYHj2fD6c2lXh77qp+pOS 1aepjAjUjqK0wxhjpvbsO6IR8DRtyvuoKdm2z3XasQfKVZbdJwoWIVChTUVtjPa3S2kt dwihiIrt9BCJpSTCNnBDipKXMYB8sjdAlT5HUSiU48pgkH2pTHDikPKeoyKCswo+tzhI xypBN4WH0vFoyatMHxO4sDEPStbFSauk+8Ols9IdGQNK3HQMOulyN4UDcHSZCmDF4H+T OBXQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chrisdown.name header.s=google header.b=qMjHrx7t; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chrisdown.name Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y23si11435684ejf.672.2020.08.17.14.18.55; Mon, 17 Aug 2020 14:19:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chrisdown.name header.s=google header.b=qMjHrx7t; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chrisdown.name Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728990AbgHQOau (ORCPT + 99 others); Mon, 17 Aug 2020 10:30:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52930 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729012AbgHQOar (ORCPT ); Mon, 17 Aug 2020 10:30:47 -0400 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B423EC061343 for ; Mon, 17 Aug 2020 07:30:46 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id z18so15216774wrm.12 for ; Mon, 17 Aug 2020 07:30:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chrisdown.name; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=njqeGiWtXLg5+jOB3X5A+tJKa5oFt5uNxmm5GwqrJhw=; b=qMjHrx7t7+r44ug3VoLGOer7utNoQQG6VakgF8M2r1F1bVok4SFkN/vtuqLMQN/+jq in9MgdaZlN/g1nheeMXL0M1J7mEy0Ben0ZovQ/Es3wg1c8xsOXS9Z6p1XfiOBl273060 R5XLxrqxPBXuoAlHrseGf5+k0UeOXGw1BjnIQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=njqeGiWtXLg5+jOB3X5A+tJKa5oFt5uNxmm5GwqrJhw=; b=VX9cICJjM7O58a1tGT5ZgF22xE966RBRsC+EJcYeBZL1cxxuVIY3XAVWYchVidIQmM 6jmtVscTrqoLuu9rOcDLTAn1GRiXx3+DQlUQjocTQHaxeUeopjXAmx7TOiQVspxbxshn 4tbWMT8POmsYpglfX5pi6d3UBU2EuI/H98KTHXOf5UHGDTbCKE6+ZTmvsNl9gLSm8lvU 2sqhxc6PukWD1JMftEuUO1elmORteZbKZ93tM/z+DjCye4RxJtzLWgPHYmII1M/5Kfbu obynf36KhpZUUCyU1bEYQCmLtWyIEE0cTv9V78Pb4vcgueRCq3kJTfHlykk4sFWrzff5 0DCw== X-Gm-Message-State: AOAM530yU+QmIaQbxWkGpLYmk4PwtcdLMx7Mwqn6AtujYdlSGtXNW1Cw S/LzBt2yrEjf8ECMMMYEKP/Q/w== X-Received: by 2002:a5d:4d87:: with SMTP id b7mr16755889wru.170.1597674645277; Mon, 17 Aug 2020 07:30:45 -0700 (PDT) Received: from localhost ([2a01:4b00:8432:8a00:63de:dd93:20be:f460]) by smtp.gmail.com with ESMTPSA id z12sm31397694wrp.20.2020.08.17.07.30.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Aug 2020 07:30:44 -0700 (PDT) Date: Mon, 17 Aug 2020 15:30:44 +0100 From: Chris Down To: Waiman Long Cc: Andrew Morton , Johannes Weiner , Michal Hocko , Vladimir Davydov , Jonathan Corbet , Alexey Dobriyan , Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org Subject: Re: [RFC PATCH 1/8] memcg: Enable fine-grained control of over memory.high action Message-ID: <20200817143044.GA1987@chrisdown.name> References: <20200817140831.30260-1-longman@redhat.com> <20200817140831.30260-2-longman@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20200817140831.30260-2-longman@redhat.com> User-Agent: Mutt/1.14.6 (2020-07-11) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Astractly, I think this really overcomplicates the API a lot. If these are truly generally useful (and I think that remains to be demonstrated), they should be additions to the existing API, rather than a sidestep with prctl. I also worry about some other more concrete things: 1. Doesn't this allow unprivileged applications to potentially bypass memory.high constraints set by a system administrator? 2. What's the purpose of PR_MEMACT_KILL, compared to memory.max? 3. Why add this entirely separate signal delivery path when we already have eventfd/poll/inotify support, which makes a lot more sense for modern applications?