Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp2630749pxa; Mon, 17 Aug 2020 14:56:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw+2Z1OmdP7LGrm8aAyOsrDDOPgnGjzv1AHXQvCDxviH5Dx/DoQxxJVvDT0pSM6PjT4fyzm X-Received: by 2002:a05:6402:1591:: with SMTP id c17mr17261182edv.240.1597701377918; Mon, 17 Aug 2020 14:56:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597701377; cv=none; d=google.com; s=arc-20160816; b=BumkNOuoQ75aoDGxbY5XvydKhFIyFmYuDV4t20PYhto4cDZue9mkS6eS8yyQydy2xw a2+QD+xsJu9HtEvlpgHOhjeDkt45zbyq2qw8A8gF5wuM75Sq/w1WUn1ABzsDH0RDgqOP jWiB1XWLAngmn+NzczxX0x99CxY2hwa429cM4aqMad4zzoPNVkAwqwKPjW1J84tQoePk 4dd6pvv1s2J7ekYn52YpZSnp/axgkCyD4CwnUR/ByqFoNeFsdEcLZ9SATM/sXYWLsyJ5 0LSWR+jOiWT1ks2S7OH+KOmKSsvKTa3GATKNRvNZIJt1Nl+TcK/K6xPnJyt2Mfu+mgBT ENCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=QbRst2ePc9HnT2YDVsN/pKImkWuILQlpUz30yJLXa2Y=; b=T7nrBTKc6+5wKdRI0LzgBYnGGF7SLq5dZPP00frGwjFGdElb2M23RN4bFsv7XeA4oX 50sf5tNyjja6e3SyWkU7CbdqwntSbZurD/vRmNSBEi+lgQyiXxa3o8EiEQLSO2fHn409 JF/2EVzYkKvSrxt9E5wHHrZ5/wbm5Hj1RqqHpxba0xXK8OAxg+rVZNiD1EesEX7sVTS6 puCQZydv2JzzMcZlPAhRt6/gOlWLESVd4oRYZNnCF013T9fsL7b8sb56TwcOpUhydzbu Tg9NtWd/tjEUGQkiFi0RvvWv3NPbZyYk8RA0CuXeWgoRlXo6q1cEdFmGoFVJPheibv7i Yogw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=KdF8tRhU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x2si12950403ejy.84.2020.08.17.14.55.54; Mon, 17 Aug 2020 14:56:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=KdF8tRhU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730155AbgHQPaA (ORCPT + 99 others); Mon, 17 Aug 2020 11:30:00 -0400 Received: from mail.kernel.org ([198.145.29.99]:40724 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729977AbgHQP1y (ORCPT ); Mon, 17 Aug 2020 11:27:54 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8C07F23B29; Mon, 17 Aug 2020 15:27:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597678074; bh=C8r8mALl/7ZEMq5jWAreO2rJacfW0xTMtM7RPgVBCDI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KdF8tRhUZOARJBysnLA7oH5l1gLxqNX4fT204s8h2dDeN8sXYz+VakdEzxG5SrjZL yLxXWLQv5F5VTpGgp9iBeSmTWh7xplRkxDuWcWAaOvLNhO4EShlaUKnSzqOPnXE/TF C1DlhZLjWc5HNuWOSqqZHgqeWl0Ni/6BreqtvJ9k= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Chuhong Yuan , Hans Verkuil , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH 5.8 209/464] media: exynos4-is: Add missed check for pinctrl_lookup_state() Date: Mon, 17 Aug 2020 17:12:42 +0200 Message-Id: <20200817143843.826599488@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200817143833.737102804@linuxfoundation.org> References: <20200817143833.737102804@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Chuhong Yuan [ Upstream commit 18ffec750578f7447c288647d7282c7d12b1d969 ] fimc_md_get_pinctrl() misses a check for pinctrl_lookup_state(). Add the missed check to fix it. Fixes: 4163851f7b99 ("[media] s5p-fimc: Use pinctrl API for camera ports configuration]") Signed-off-by: Chuhong Yuan Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/platform/exynos4-is/media-dev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/platform/exynos4-is/media-dev.c b/drivers/media/platform/exynos4-is/media-dev.c index 9aaf3b8060d50..9c31d950cddf7 100644 --- a/drivers/media/platform/exynos4-is/media-dev.c +++ b/drivers/media/platform/exynos4-is/media-dev.c @@ -1270,6 +1270,9 @@ static int fimc_md_get_pinctrl(struct fimc_md *fmd) pctl->state_idle = pinctrl_lookup_state(pctl->pinctrl, PINCTRL_STATE_IDLE); + if (IS_ERR(pctl->state_idle)) + return PTR_ERR(pctl->state_idle); + return 0; } -- 2.25.1