Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp2635200pxa; Mon, 17 Aug 2020 15:03:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxQPlRM2eHj3/j/d1uQWgLJ9VqzQ+n5uk6Jc1FMpbOOBu6AmydOOT2+31p7oVptCIkrux8/ X-Received: by 2002:a17:906:33d1:: with SMTP id w17mr18426511eja.68.1597701833151; Mon, 17 Aug 2020 15:03:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597701833; cv=none; d=google.com; s=arc-20160816; b=U8o+VvZPd+0V6klghxnz4jf6HATvrm4/DAT9IMKdHmWy8YrzKXVoqT3zyhUwY1pA86 rIyPDlSGe9fp0ec35Da3l9UXYcmFbMR9S7fhkUkXaKdamWjMKwRZnXu0zhcKK6oLmTP9 EdkG6w0ib7A9BKrepKPEjB1vh/qDr4TYc3aTIHcgyU9FyY9tYLEEmC/KIs0+R6lHtQQy S7Rp/5EzQEDt0tMJFwhxhZVlNaNLTgOapr555AbSekbyX+QF1NRis0LfqhQJr8mwOwYL UDGBJ400X0p0tEALs/vab0q0ELCwss/fPRuR9SuykN3YfegklfUPgY5LSK0otj0G9YmT mBug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=p4LFNurERsBCaRa1qvax8L2o3oMUsk59/SPbjBZZuw4=; b=HJ8LCcia+J/X23F/dBeD779NhGifMojrIDHJgdsl+nqKrTCJTnXJFClCSi7/kTipqC jw5ZLBtAjtSSix/+hXo0nBpkfxqp2y56HA2MFzKFx+jxKmlTpiByuT6Euo4fz8hTYKae sI+Q6T9jjRZcZEdjIjQP4B7+LrKuPy57k1zt5799/PJyQVm8Tg5AfoGo8KryZfnwgITE 75CtQjt+c8FejQIPPfXu1UGbQ435Frl+TOQHMuF2oYrpx7+90TqzKrEyQMu9eFtgLgcI xCKyb+IyHJfwtAGnGBbb3qmZJ0O3zvky1JxVWSYvCZhSwjIs9UEQfagGWmqU+xFI74gv pKbg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=JtlyLVw9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id rh7si12306151ejb.101.2020.08.17.15.03.29; Mon, 17 Aug 2020 15:03:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=JtlyLVw9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387466AbgHQPl4 (ORCPT + 99 others); Mon, 17 Aug 2020 11:41:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:39474 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730440AbgHQPeq (ORCPT ); Mon, 17 Aug 2020 11:34:46 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E604522E00; Mon, 17 Aug 2020 15:34:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597678486; bh=4CFGfsTcuLmf6c/2l3yQniiMu66wdLCJlBLj0T632xw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JtlyLVw90c8qH6B7mwXuCTeFjdBGiE7kDe+7tmS1UPN7xuFVgF2ugu/85DSfxOF1e ZxnX1nEMLQ5GocVfiD1rmwfAUy7RWciNyq7+qODDjWabfaerivbiHWFukk3xScT2wj TIGlz7tdKNOBijfdAbFSuzAL+hvIGfkmDrwb+vvs= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hulk Robot , Wang Hai , Kalle Valo , Sasha Levin Subject: [PATCH 5.8 349/464] wl1251: fix always return 0 error Date: Mon, 17 Aug 2020 17:15:02 +0200 Message-Id: <20200817143850.488290042@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200817143833.737102804@linuxfoundation.org> References: <20200817143833.737102804@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Wang Hai [ Upstream commit 20e6421344b5bc2f97b8e2db47b6994368417904 ] wl1251_event_ps_report() should not always return 0 because wl1251_ps_set_mode() may fail. Change it to return 'ret'. Fixes: f7ad1eed4d4b ("wl1251: retry power save entry") Reported-by: Hulk Robot Signed-off-by: Wang Hai Signed-off-by: Kalle Valo Link: https://lore.kernel.org/r/20200730073939.33704-1-wanghai38@huawei.com Signed-off-by: Sasha Levin --- drivers/net/wireless/ti/wl1251/event.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ti/wl1251/event.c b/drivers/net/wireless/ti/wl1251/event.c index 850864dbafa11..e6d426edab56b 100644 --- a/drivers/net/wireless/ti/wl1251/event.c +++ b/drivers/net/wireless/ti/wl1251/event.c @@ -70,7 +70,7 @@ static int wl1251_event_ps_report(struct wl1251 *wl, break; } - return 0; + return ret; } static void wl1251_event_mbox_dump(struct event_mailbox *mbox) -- 2.25.1