Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp2664589pxa; Mon, 17 Aug 2020 15:57:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyyDPg2N+5x9yLpJyPxwhkQMl8ro0vIF4NEkHUhpDL6mvkwl69kb+3iPLqg8huYDYwwiGje X-Received: by 2002:a17:906:d8f:: with SMTP id m15mr17145763eji.494.1597705070133; Mon, 17 Aug 2020 15:57:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597705070; cv=none; d=google.com; s=arc-20160816; b=QuUgGQ8UcsbRckBhRKYLx0/ihj2WCriUVpvC2VhEEZMkgFB8cuXsKVaGAd6HeA6FqO HY1+Ig9mQCCLmhU5e7UwefoOpokld7+60qRMCg7vSKE92s/JQWgp25yK8KHQN5swKSb8 yrGn+RFn09ywe7srunjXsD1BgYZYoM34jDr7q+Whq8OC1Xdu0P38TaDwg6rA2x1s9e3a wOjEEQ0pFaLO71UAWEduRaejsnC/aBiMZC2fvOvmG/L0t9mjZUOZNsBlvyhPiUNjC0of 46RhmN7OxdWQkzRH/1/EEeKL/GqfAOoIiCBvg/pEN3B/fA2A4i9yw78JpmADu2mQpiHW xsHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=NHIC6rNBgIMP8ZTvGvNfaXVgBSISGahihT3cutQZYtA=; b=F4B7RakbB+xW2wgkq5DzX2AkUpbKbE0tNFltTcHOt+pqb6QdeCDEk/CYCbfUTMEZ7e BOcTAitpvn5MS/t7qBRqQshMCYIuSiNBopyo1zivwTBYIpEOA0l2vn1Quv2/1ktpG+mn 0kz6etY1bTa0KLU3iHZbtQtWlP1fSy9EjMsaq728MJTkrXM8y/QaYwLKyAFekufSRl54 E60zRngqnnJphdw6Lp78QMwrIGImLktM68JWjw7UrGmuKMU1jQbLmAF9LZt2GUjqw9Rv zRo30ruPQ5JCTdsLOkTX2y6s0nA/FLrEb/XghjYMTlscNTUebbb5X/xKCTzEZWm7CPhv 5XSw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=SbipTi1s; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t26si12007685ejb.695.2020.08.17.15.57.26; Mon, 17 Aug 2020 15:57:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=SbipTi1s; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732561AbgHQTmb (ORCPT + 99 others); Mon, 17 Aug 2020 15:42:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:54510 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729647AbgHQPYW (ORCPT ); Mon, 17 Aug 2020 11:24:22 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B733F20729; Mon, 17 Aug 2020 15:24:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597677861; bh=g+Wy7iCnNpmyB5BLU7r9saNvxQus1BUEvV7pAy8bNcg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SbipTi1suBZrHXbHfa4RmiuL/MVnesFGcwU+dpUeItplV5MuV3ptTvhQ7GfiP25hu jUVFxnp+JHsxJIOtZyLf2wjPMzy1Ho3nmQFb+Iy4Dr9rqZvTFsljMV57hqK0bMYxkQ FfapcDwOP3RNpk1q+NoZOLJcjisfKMCjKXQlMnew= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Erik Kaneda , Bob Moore , "Rafael J. Wysocki" , Sasha Levin Subject: [PATCH 5.8 135/464] ACPICA: Do not increment operation_region reference counts for field units Date: Mon, 17 Aug 2020 17:11:28 +0200 Message-Id: <20200817143840.281479058@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200817143833.737102804@linuxfoundation.org> References: <20200817143833.737102804@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Erik Kaneda [ Upstream commit 6a54ebae6d047c988a31f5ac5a64ab5cf83797a2 ] ACPICA commit e17b28cfcc31918d0db9547b6b274b09c413eb70 Object reference counts are used as a part of ACPICA's garbage collection mechanism. This mechanism keeps track of references to heap-allocated structures such as the ACPI operand objects. Recent server firmware has revealed that this reference count can overflow on large servers that declare many field units under the same operation_region. This occurs because each field unit declaration will add a reference count to the source operation_region. This change solves the reference count overflow for operation_regions objects by preventing fieldunits from incrementing their operation_region's reference count. Each operation_region's reference count will not be changed by named objects declared under the Field operator. During namespace deletion, the operation_region namespace node will be deleted and each fieldunit will be deleted without touching the deleted operation_region object. Link: https://github.com/acpica/acpica/commit/e17b28cf Signed-off-by: Erik Kaneda Signed-off-by: Bob Moore Signed-off-by: Rafael J. Wysocki Signed-off-by: Sasha Levin --- drivers/acpi/acpica/exprep.c | 4 ---- drivers/acpi/acpica/utdelete.c | 6 +----- 2 files changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/acpi/acpica/exprep.c b/drivers/acpi/acpica/exprep.c index a4e306690a21b..4a0f03157e082 100644 --- a/drivers/acpi/acpica/exprep.c +++ b/drivers/acpi/acpica/exprep.c @@ -473,10 +473,6 @@ acpi_status acpi_ex_prep_field_value(struct acpi_create_field_info *info) (u8)access_byte_width; } } - /* An additional reference for the container */ - - acpi_ut_add_reference(obj_desc->field.region_obj); - ACPI_DEBUG_PRINT((ACPI_DB_BFIELD, "RegionField: BitOff %X, Off %X, Gran %X, Region %p\n", obj_desc->field.start_field_bit_offset, diff --git a/drivers/acpi/acpica/utdelete.c b/drivers/acpi/acpica/utdelete.c index c365faf4e6cd4..4c0d4e4341961 100644 --- a/drivers/acpi/acpica/utdelete.c +++ b/drivers/acpi/acpica/utdelete.c @@ -568,11 +568,6 @@ acpi_ut_update_object_reference(union acpi_operand_object *object, u16 action) next_object = object->buffer_field.buffer_obj; break; - case ACPI_TYPE_LOCAL_REGION_FIELD: - - next_object = object->field.region_obj; - break; - case ACPI_TYPE_LOCAL_BANK_FIELD: next_object = object->bank_field.bank_obj; @@ -613,6 +608,7 @@ acpi_ut_update_object_reference(union acpi_operand_object *object, u16 action) } break; + case ACPI_TYPE_LOCAL_REGION_FIELD: case ACPI_TYPE_REGION: default: -- 2.25.1