Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp2672989pxa; Mon, 17 Aug 2020 16:12:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxphcP7YnMCGmdC3c5/cRwT00EV4w/Gh2xnc+s+TZMmISY413MvP1z4Rv6AJWPWm/PUm1hA X-Received: by 2002:a17:907:9e7:: with SMTP id ce7mr17292696ejc.12.1597705975763; Mon, 17 Aug 2020 16:12:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597705975; cv=none; d=google.com; s=arc-20160816; b=dIqjETcTPJYiZPrLUOVKsR2oBLJAiEUOFXo1CZVb0zhpzI4WMKIbtvuWh1OyOczRxP qSGLviVhUuoMWr+r5Hdvh44lTK8FKCzQmzptxm4S251k1G4KaHIB6zBpD/Gk2pSf2cbS TG9by0OimoZZD2M2JRudc2fOG9jtG58D3ENmztqGYYLIIF1hyoA2hGQxq1K57xT1Qinp 2np794SrSPNCewVwBt0yABPCddoHMZ3Q1CzE3go3jIE0ahFREOGU6JA16HeANWGM0Vx+ JP0rqdOhX7Rb+Jvqy9MZ6iRTIHS/h6k9EsX8OFe1Wyp27Op0E90bHURRXZ2KGuRH16IM ZvwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=XlvftYH14kv2HALrsicZ8Q52jWcwzeep5y+/UU5oRFw=; b=ikNlQ95GxcPlZdlvDPHoXitqbVkt0XYfdDJwmPo2j/lWd80rumdv//UX6FE85EykK3 +8r0jASl0MlHrQ4nakyYXB4/HwGZfeeU5PNyDmYxtXTOwVLG2P5MIuTELPr2818d3Htz UQEu2SrdV7mMypCQjjpAxED9yIcAGdtbGUL6geVx2uJdmSC4b2ES/y5lKrx38I4HNbel ujWUqLZFh4C7IdR4GmHFHTKOCYdjE3Q16C9Sj/u08ZjHaAA3GSDAs7cS9iDNN6vlMkZf W/VC+4J0shSO1GmjJu2Oy++n0lQVI9fhN6OAxpY/LPnl02pu6j9lhzJ8ty8BVjxbfQ7R RrfA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b19si5834922ejk.429.2020.08.17.16.12.32; Mon, 17 Aug 2020 16:12:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729088AbgHQV6r (ORCPT + 99 others); Mon, 17 Aug 2020 17:58:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38166 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726596AbgHQV6q (ORCPT ); Mon, 17 Aug 2020 17:58:46 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1AF57C061389; Mon, 17 Aug 2020 14:58:46 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id BD60E15D695B5; Mon, 17 Aug 2020 14:41:59 -0700 (PDT) Date: Mon, 17 Aug 2020 14:58:45 -0700 (PDT) Message-Id: <20200817.145845.337622311570874890.davem@davemloft.net> To: min.li.xe@renesas.com Cc: richardcochran@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net] ptp: ptp_clockmatrix: use i2c_master_send for i2c write From: David Miller In-Reply-To: <1597678655-842-1-git-send-email-min.li.xe@renesas.com> References: <1597678655-842-1-git-send-email-min.li.xe@renesas.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 17 Aug 2020 14:41:59 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Date: Mon, 17 Aug 2020 11:37:35 -0400 > @@ -53,7 +53,9 @@ > > #define OUTPUT_MODULE_FROM_INDEX(index) (OUTPUT_0 + (index) * 0x10) > > -#define PEROUT_ENABLE_OUTPUT_MASK (0xdeadbeef) > +#define PEROUT_ENABLE_OUTPUT_MASK (0xdeadbeef) > + > +#define IDTCM_MAX_WRITE_COUNT (512) Why adjust the indentation of the value of PEROUT_ENABLE_OUTPUT_MASK? It is meant to line up with OUTPUT_MODULE_FROM_INDEX. Please do not make unrelated changes like this and follow existing style and indentation. Thank you.