Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <VI1PR0402MB334219C2EDDB25D1493DEC7EE35F0@VI1PR0402MB3342.eurprd04.prod.outlook.com>
In-Reply-To: <VI1PR0402MB334219C2EDDB25D1493DEC7EE35F0@VI1PR0402MB3342.eurprd04.prod.outlook.com>
From:   Fabio Estevam <festevam@gmail.com>
Date:   Mon, 17 Aug 2020 21:38:01 -0300
Message-ID: <CAOMZO5A6w96XOes-FUfLuGbV=-o9FVh4UWN8vX1M=aWh=Gg3Qw@mail.gmail.com>
Subject: Re: [PATCH] ARM: dts: imx6sx-sdb: Add headphone detection for sound card
To:     "S.j. Wang" <shengjiu.wang@nxp.com>
Cc:     Rob Herring <robh+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Sascha Hauer <kernel@pengutronix.de>,
        dl-linux-imx <linux-imx@nxp.com>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@lists.infradead.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Aug 17, 2020 at 10:57 AM S.j. Wang <shengjiu.wang@nxp.com> wrote:

> I didn't put headphone detect GPIO in audmux group in imx6sl-evk patch,
> Still in hog group.

Ok, sorry. You grouped it with MX6SL_PAD_AUD_MCLK__AUDIO_CLK_OUT,
which I also think should not be part of the hog group.

> And I think headphone detect GPIO is not belong to audmux group, it should
> Be in hog group.

The hog group is better suited when there is no driver that can be
associated with that particular pin.

For the headphone GPIO detect, I think it makes sense to group it with
the other audio-related pinctrl pins.