Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp2718440pxa; Mon, 17 Aug 2020 17:41:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw/xHhjh73krB28ikEp9HJlp7AJN5nSJOzxwOIRekoRhzy2+ffrMfEhZzEblKgPxZgAZ6Ff X-Received: by 2002:a05:6402:1e2:: with SMTP id i2mr17180717edy.70.1597711268144; Mon, 17 Aug 2020 17:41:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597711268; cv=none; d=google.com; s=arc-20160816; b=jm7fzwr2BaNf5gkS57PAvjfA8QvzCX2RC339t//ifseDVpQ3PZWATTN0zT35LMIB0v QG1EJ+3Pe+xhecN51Ig9laZpVqi9F4TSDhB/bGLrUKcNSRxmEiXtFST5nBmAeBgRPAOL pKSxAIsk6OEVe3xsZAUoMBCIYaUyIzRHxYznvbOBUialW2lk3n9vHROiLuggDh96kjMp dnqApdA67Mg+NLaOoSMS9DEC86Le3j3+kLWH0tmDT7hbiJ/yOHztOwAiLpjsaPMRXH0u LWDh5oKeY3GlEaJAFFKj+WwJY5yLDTbaT1ZaQcmKCHPeZ8ZW9VNJctFMevBuFcxC02nA 2Bdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=IJPXrsCipqi0H0PMMRI1mohpgVa4NcRS8gKWHziQUus=; b=fV56hKf8lePvfSINZ52zdQGouXgFzMblYiI5nAGglUnYW6bP1IofXXX7pXiuU5i87n 5698TxJyhz+bNZl38XXL7i5O9Nu8cILbyMV/KbrwtySqs+2uH31p18P1HH8xLKE4e53h Lg+Qm2dIV6mCWHtdKhKaJO8BRl7Y+yoc9m1BJCA3qr/TcQXVfAG+DazHvATW4zPLK9Ax Tju9ykRAOCPq0RyTup1x0rDZ8G7pkwYWBgpyc576MKzByv3Xio4BL2fYFgEQmpQRWRap VcYYD/V8ojIoCgI3iFJVfTsK2XugJDyGcn0HSaDgEX6Tyf0XmpvQTGpV10ziF0j5XPSs N86g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@paul-moore-com.20150623.gappssmtp.com header.s=20150623 header.b=2Mz9RlRk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b6si13275457eja.559.2020.08.17.17.40.44; Mon, 17 Aug 2020 17:41:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@paul-moore-com.20150623.gappssmtp.com header.s=20150623 header.b=2Mz9RlRk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726634AbgHRAjL (ORCPT + 99 others); Mon, 17 Aug 2020 20:39:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34762 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726314AbgHRAjJ (ORCPT ); Mon, 17 Aug 2020 20:39:09 -0400 Received: from mail-ej1-x643.google.com (mail-ej1-x643.google.com [IPv6:2a00:1450:4864:20::643]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9F9AAC061389 for ; Mon, 17 Aug 2020 17:39:09 -0700 (PDT) Received: by mail-ej1-x643.google.com with SMTP id t10so19978181ejs.8 for ; Mon, 17 Aug 2020 17:39:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=IJPXrsCipqi0H0PMMRI1mohpgVa4NcRS8gKWHziQUus=; b=2Mz9RlRkj29ledDMtSWh51eLVitvz0DsI0HaqJpwfCtxuH9I/GzqIVZd7NF8tELvC8 yAA+JT3UTuVemnDfMtUk5SNXzLty3O2c75k9cDxf5uvz9Y7s0u0lCWl4nJxE9R6nMbY1 c5OJg2MHD7+Mp6Tq1x3nii/KjvBvEoc4HuhJJavue27MB8A1A5SiXqEw5/9xlPdpNyby ksSlV5KeDuRRcZ1R6HEIhGjfGKC9UTkVPKUW9HihAaDMLhdOUzvRROQY0xHBQQYvrMpB C7OCNxAXkz1r1caQNf1B2oDR2Gx9Yzdlm6rcjTqnRS20DHQN9LXtv2DuFeEAxe1OWYMo Zqzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=IJPXrsCipqi0H0PMMRI1mohpgVa4NcRS8gKWHziQUus=; b=R0p5aioLsKrIV3Ac7fPcyYChObeu7o2FTlVYDnTvb9QYboKnmsd7c5T1lz+dExG4aS LbutQZczis0gCDs6qcbYWiQDOMJOYMSPXm5gCTKidKYm8A0jxes3QpIT6OyxRvRbeatB Ol8TMUMwQOGG5iL+XjnX9xs8VDNrR9x/tivwWTS1tYv8otMX47I5TMYYbZuPohINITKb OCGLC0My6ckppevVYH6tf4PMQD6dUESd9jIycaijfezOO8whhJFGvjzlPtsDgZPefzsm dkRrY/iwSbJynoB8wmM6DKEqDG+OhR7K0e82svq2avikIRKPl45XnqBzN95UZhOds/7P HGjg== X-Gm-Message-State: AOAM5339ugbJH7RnTumyIeClWAYdB7vTwXtA2yludFkFzcMWbSqPbmhn AvBgnGF9vrY7C4cJ+Oe2nWxzSakFG4jzB/bvTo8O X-Received: by 2002:a17:906:7c86:: with SMTP id w6mr17381043ejo.178.1597711148230; Mon, 17 Aug 2020 17:39:08 -0700 (PDT) MIME-Version: 1.0 References: <20200803123439.83400-1-jbi.octave@gmail.com> <20200803123439.83400-3-jbi.octave@gmail.com> In-Reply-To: From: Paul Moore Date: Mon, 17 Aug 2020 20:38:57 -0400 Message-ID: Subject: Re: [RESEND PATCH 2/2] audit: uninitialize variable audit_sig_sid To: Jules Irenge Cc: linux-kernel@vger.kernel.org, Eric Paris , "moderated list:AUDIT SUBSYSTEM" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 6, 2020 at 2:35 PM Paul Moore wrote: > > On Mon, Aug 3, 2020 at 8:35 AM Jules Irenge wrote: > > > > Checkpatch tool reports > > > > "ERROR: do not initialise globals/statics to 0" > > > > To fix this, audit_sig_sid is uninitialized > > As this is stored in the .bss section, > > the compiler can initialize the variable automatically. > > > > Signed-off-by: Jules Irenge > > --- > > kernel/audit.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > Similar to patch 1/2, this will need to wait until after the merge > window closes. ... also merged this patch into audit/next. Thanks again. -- paul moore www.paul-moore.com