Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: l5inDPIqLywGBiC2onxxXGt0TuEQnE2aBsQnN9vc0Eam1hEb3Hd6M2/8jbjEN/iF07P9q0MwnR
 TRF+wYQvca4w==
IronPort-SDR: mupB0hZ6tOkcr2+Qy/L/Wi/2FO9WGhIbB+Ir/jA+k9yT+HqkFJ72G8RLSLeS0dJwdo8T61azuK
 RjkbzgtmvaEQ==
From:   "Xia, Hui" <hui.xia@intel.com>
To:     Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        lkp <lkp@intel.com>
CC:     Hyun Kwon <hyun.kwon@xilinx.com>,
        "kbuild-all@lists.01.org" <kbuild-all@lists.01.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Vinod Koul <vkoul@kernel.org>,
        Tejas Upadhyay <tejasu@xilinx.com>,
        Michal Simek <monstr@monstr.eu>
Subject: RE: [kbuild-all] Re: drivers/dma/xilinx/xilinx_dpdma.c:1172
 xilinx_dpdma_synchronize() error: double unlocked 'chan->vchan.lock' (orig
 line 1170)
Thread-Topic: [kbuild-all] Re: drivers/dma/xilinx/xilinx_dpdma.c:1172
 xilinx_dpdma_synchronize() error: double unlocked 'chan->vchan.lock' (orig
 line 1170)
Thread-Index: AQHWcDHV3z0s7FSfcUeuCnrdc6Vs7qk9eLEQ
Date:   Tue, 18 Aug 2020 06:55:23 +0000
Message-ID: <MWHPR11MB161363A9420049706DEBB450E55C0@MWHPR11MB1613.namprd11.prod.outlook.com>
References: <202008120657.drkFgIsC%lkp@intel.com>
 <20200811225006.GF17446@pendragon.ideasonboard.com>
In-Reply-To: <20200811225006.GF17446@pendragon.ideasonboard.com>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-reaction: no-action
dlp-version: 11.5.1.3
Content-Type: text/plain; charset="iso-2022-jp"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: e3ba7835-856a-43f0-1722-08d84343ae1b
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Aug 2020 06:55:23.4626
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Z2xDQwhV+09fka3H+Rqb8wbw4RZXLjNM4FtQoFcy0BUKoM7gdXH0il/v+bTFW9MMmV90fPiEk+8pM8tXkK6rqw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1101MB2077
X-OriginatorOrg: intel.com
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


>-----Original Message-----
>From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>Sent: 2020=1B$BG/=1B(B8=1B$B7n=1B(B12=1B$BF|=1B(B 6:50
>To: kernel test robot <lkp@intel.com>
>Cc: Hyun Kwon <hyun.kwon@xilinx.com>; kbuild-all@lists.01.org; linux-
>kernel@vger.kernel.org; Vinod Koul <vkoul@kernel.org>; Tejas Upadhyay
><tejasu@xilinx.com>; Michal Simek <monstr@monstr.eu>
>Subject: [kbuild-all] Re: drivers/dma/xilinx/xilinx_dpdma.c:1172
>xilinx_dpdma_synchronize() error: double unlocked 'chan->vchan.lock' (orig=
 line
>1170)
>
>On Wed, Aug 12, 2020 at 06:37:59AM +0800, kernel test robot wrote:
>> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.g=
it master
>> head:   c636eef2ee3696f261a35f34989842701a107895
>> commit: 7cbb0c63de3fc218fd06ecfedb477772a4d12f76 dmaengine: xilinx:
>dpdma: Add the Xilinx DisplayPort DMA engine driver
>> date:   4 weeks ago
>> config: h8300-randconfig-m031-20200811 (attached as .config)
>> compiler: h8300-linux-gcc (GCC) 9.3.0
>>
>> If you fix the issue, kindly add following tag as appropriate
>> Reported-by: kernel test robot <lkp@intel.com>
>>
>> smatch warnings:
>> drivers/dma/xilinx/xilinx_dpdma.c:1172 xilinx_dpdma_synchronize()
>> error: double unlocked 'chan->vchan.lock' (orig line 1170)
>
>Unless I'm mistaken, this is a false positive. I'd appreciate if someone c=
ould check
>if I'm missing something obvious.

Please ignore this report. It is a false positive.=20
We have changed the rule to avoid send out this warning type directly. Sorr=
y for inconvenient.

Best Regards,
Hui

>
>> vim +1172 drivers/dma/xilinx/xilinx_dpdma.c
>>
>>   1140
>>   1141	/**
>>   1142	 * xilinx_dpdma_synchronize - Synchronize callback execution
>>   1143	 * @dchan: DMA channel
>>   1144	 *
>>   1145	 * Synchronizing callback execution ensures that all previously i=
ssued
>>   1146	 * transfers have completed and all associated callbacks have bee=
n called
>and
>>   1147	 * have returned.
>>   1148	 *
>>   1149	 * This function waits for the DMA channel to stop. It assumes it=
 has been
>>   1150	 * paused by a previous call to dmaengine_terminate_async(), and =
that
>no new
>>   1151	 * pending descriptors have been issued with dma_async_issue_pend=
ing().
>The
>>   1152	 * behaviour is undefined otherwise.
>>   1153	 */
>>   1154	static void xilinx_dpdma_synchronize(struct dma_chan *dchan)
>>   1155	{
>>   1156		struct xilinx_dpdma_chan *chan =3D to_xilinx_chan(dchan);
>>   1157		unsigned long flags;
>>   1158
>>   1159		xilinx_dpdma_chan_stop(chan);
>>   1160
>>   1161		spin_lock_irqsave(&chan->vchan.lock, flags);
>>   1162		if (chan->desc.pending) {
>>   1163			vchan_terminate_vdesc(&chan->desc.pending->vdesc);
>>   1164			chan->desc.pending =3D NULL;
>>   1165		}
>>   1166		if (chan->desc.active) {
>>   1167			vchan_terminate_vdesc(&chan->desc.active->vdesc);
>>   1168			chan->desc.active =3D NULL;
>>   1169		}
>> > 1170		spin_unlock_irqrestore(&chan->vchan.lock, flags);
>>   1171
>> > 1172		vchan_synchronize(&chan->vchan);
>>   1173	}
>>   1174
>>
>
>--
>Regards,
>
>Laurent Pinchart
>_______________________________________________
>kbuild-all mailing list -- kbuild-all@lists.01.org To unsubscribe send an =
email to
>kbuild-all-leave@lists.01.org