Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp2883686pxa; Mon, 17 Aug 2020 23:58:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy+hBvUXQN5MvuSwDzyBmTcImeaqHcNTaoc1opS46b6JHzcxt5+pnsL+3iD6O0noB3w09MM X-Received: by 2002:a17:906:d78c:: with SMTP id pj12mr18320478ejb.179.1597733899132; Mon, 17 Aug 2020 23:58:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597733899; cv=none; d=google.com; s=arc-20160816; b=qT43tUO0+dqVt89PQivicMYV5w8NLz3kONs18ebJYNVFvy2tjkrJq2we3p8kXTrcQm jvJep+l1lA4PGHd+5c3oPbTvYOrp4e0k8/EpPLc88a9LvrRO1XAA1Nz/rH4BxD6jhMBz gh8lRt/fsKSFxEq37kDd6Y4qwb01UbP78fiX3mpdwp4J98d4NuRjBUXsntVnbLacjKUv +G4zY8eGSkRMmoj8RCK1DvlfMsWwxWZSM6WBWcgFBheqWWDp3h47vlTknzkJHc82XYhN 8PRO1L2U7vNCsp8J3PL+n2n7mH1k4QWLAwpOTjxJ9Ap5fCojnyJGe+s26N1PjscbSP8X MC0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from; bh=2okjQp7qij/p6biy+YpVa7rx45i8qZiXVr1E8rwkq0k=; b=IVH536gfIxR/assg8MeB7W8Lx4Ur65iSp2EgKQiD4CGtN+/N351XdrkOTJuu6w+91b N8xALJVGIqPM5lPRxOC7fmz8CwAo4JI8yrxzOB9y6uHa5Tajr3zgNs+1IiQN1g37/Joy KNjzP9AvmMI6r+gWdHH7aQH8r9lCRnAGFDpoxsU6jO4n++wXqM08q5aunyzP1F/CsE6f 9WksYRQ2587qBrGG2XtTVHKKzJuDLq8Ocgp+eQlMu03uWbj4DjL+4EPpz1YjjTIJhfck maLPsZVt8vyNi0f4RHj7puejTru6vdGLkiIOjx5W/zgw4dXV+DLJO8h1NNwHquRn1RB9 4Wdg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bm20si11939247edb.583.2020.08.17.23.57.55; Mon, 17 Aug 2020 23:58:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726591AbgHRGyS (ORCPT + 99 others); Tue, 18 Aug 2020 02:54:18 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:9831 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726353AbgHRGyP (ORCPT ); Tue, 18 Aug 2020 02:54:15 -0400 Received: from DGGEMS407-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 39D586B58F610C2A31E8; Tue, 18 Aug 2020 14:53:56 +0800 (CST) Received: from localhost.localdomain (10.69.192.56) by DGGEMS407-HUB.china.huawei.com (10.3.19.207) with Microsoft SMTP Server id 14.3.487.0; Tue, 18 Aug 2020 14:53:49 +0800 From: Tian Tao To: , , , , , , , , CC: Subject: [PATCH drm/hisilicon 3/4] drm/hisilicon: Use drv_err instead of DRM_ERROR in hibmc_drm_de Date: Tue, 18 Aug 2020 14:51:43 +0800 Message-ID: <1597733504-30812-4-git-send-email-tiantao6@hisilicon.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1597733504-30812-1-git-send-email-tiantao6@hisilicon.com> References: <1597733504-30812-1-git-send-email-tiantao6@hisilicon.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.69.192.56] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use drv_err instead of DRM_ERROR in hibmc_drm_de Signed-off-by: Tian Tao --- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c index d9062a3..4d57ec6 100644 --- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c +++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c @@ -71,12 +71,12 @@ static int hibmc_plane_atomic_check(struct drm_plane *plane, return PTR_ERR(crtc_state); if (src_w != state->crtc_w || src_h != state->crtc_h) { - DRM_DEBUG_ATOMIC("scale not support\n"); + drm_dbg_atomic(plane->dev, "scale not support\n"); return -EINVAL; } if (state->crtc_x < 0 || state->crtc_y < 0) { - DRM_DEBUG_ATOMIC("crtc_x/y of drm_plane state is invalid\n"); + drm_dbg_atomic(plane->dev, "crtc_x/y of drm_plane state is invalid\n"); return -EINVAL; } @@ -87,12 +87,12 @@ static int hibmc_plane_atomic_check(struct drm_plane *plane, crtc_state->adjusted_mode.hdisplay || state->crtc_y + state->crtc_h > crtc_state->adjusted_mode.vdisplay) { - DRM_DEBUG_ATOMIC("visible portion of plane is invalid\n"); + drm_dbg_atomic(plane->dev, "visible portion of plane is invalid\n"); return -EINVAL; } if (state->fb->pitches[0] % 128 != 0) { - DRM_DEBUG_ATOMIC("wrong stride with 128-byte aligned\n"); + drm_dbg_atomic(plane->dev, "wrong stride with 128-byte aligned\n"); return -EINVAL; } return 0; @@ -515,7 +515,7 @@ int hibmc_de_init(struct hibmc_drm_private *priv) NULL); if (ret) { - DRM_ERROR("failed to init plane: %d\n", ret); + drm_err(dev, "failed to init plane: %d\n", ret); return ret; } @@ -524,13 +524,13 @@ int hibmc_de_init(struct hibmc_drm_private *priv) ret = drm_crtc_init_with_planes(dev, crtc, plane, NULL, &hibmc_crtc_funcs, NULL); if (ret) { - DRM_ERROR("failed to init crtc: %d\n", ret); + drm_err(dev, "failed to init crtc: %d\n", ret); return ret; } ret = drm_mode_crtc_set_gamma_size(crtc, 256); if (ret) { - DRM_ERROR("failed to set gamma size: %d\n", ret); + drm_err(dev, "failed to set gamma size: %d\n", ret); return ret; } drm_crtc_helper_add(crtc, &hibmc_crtc_helper_funcs); -- 2.7.4