Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp2885635pxa; Tue, 18 Aug 2020 00:02:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyiL8KQYhXRXBaRY4yd8V/OopWFPnl8oyeWMZctfyjmcxesB8MaHAiYndA+SJuNCeMAeGk5 X-Received: by 2002:a17:906:1f15:: with SMTP id w21mr18133672ejj.152.1597734143409; Tue, 18 Aug 2020 00:02:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597734143; cv=none; d=google.com; s=arc-20160816; b=gWS8/5SRJT6ez6yyajHO7IVXI2IFS6W4/HCANq+CRna+3EgeFjHfuB7H4oY5VH76Gh TTtqpcgNkWgcNjE8t9BnztzhSIxBmy/yn5dgzxZrHJNfuOUMo2TKm2VaC7qX1dBJff9H WwQM2pjxWUugehHfjBGMT+kC5AgrPXjeZovtsVeCWl+4aF1TipHdQco7tx3zfRB2KbCA 6PHHIGoW2JXnMCe/jirEwR5uBZzkqgRPE2dLbZfZnu33jF6nFOnrwpk7mfnLmkolfpKx xY2/kPGZl5N0uKx9NcG/hZdiOfykjQ0byIUgcCANyt9fEACc/aCfEPt6WPC4PWmr9ZUo S8qw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=/rNGlcSji0NnsURcKAebhJcddxeLh6ey3OYdSSakMFM=; b=jg+WjHpOYJbYsw594zxzwfKdrEbzGQqxbXtqdhnSJJLhzAz+OA13Pp1DEVBTHSrCCI oOUNZflimmeiT3ghJHuaxG6fV+MdUE/0ZhAhQgBXyq94xh6c1bcxZqEkFGFQoJR73ddN b0MKIl1LR/LQ69pltrXXSlXxOFqK7KF+h0K/jyIDNogBwXTlgNHe1VNfpGmydcLq9iwE ZpxCifuEWShVL+9KrzyPgnLdelKZmvj/gQB7lHHfUZ+QXdi0qEY7v7MY4PzO+DCfYbOP CVaA3N96sumKp6Wwe6OpumGMmH1uRT5ry61TRgM3/c/pwZ+mk9ysfWzFicYeQeS0MyoQ w0ZQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d13si12782155ejd.721.2020.08.18.00.02.00; Tue, 18 Aug 2020 00:02:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726588AbgHRHBF (ORCPT + 99 others); Tue, 18 Aug 2020 03:01:05 -0400 Received: from verein.lst.de ([213.95.11.211]:60417 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726429AbgHRHAo (ORCPT ); Tue, 18 Aug 2020 03:00:44 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 20B3A68B02; Tue, 18 Aug 2020 09:00:11 +0200 (CEST) Date: Tue, 18 Aug 2020 09:00:10 +0200 From: Christoph Hellwig To: Cong Wang Cc: Christoph Hellwig , Coly Li , linux-block@vger.kernel.org, linux-nvme@lists.infradead.org, Linux Kernel Network Developers , stable , LKML , Chaitanya Kulkarni , Hannes Reinecke , Jan Kara , Jens Axboe , Mikhail Skorzhinskii , Philipp Reisner , Sagi Grimberg , Vlastimil Babka Subject: Re: [PATCH v5 1/3] net: introduce helper sendpage_ok() in include/linux/net.h Message-ID: <20200818070010.GA2365@lst.de> References: <20200816071518.6964-1-colyli@suse.de> <20200817054538.GA11705@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 17, 2020 at 12:12:12PM -0700, Cong Wang wrote: > > So netdev people will have to understand and support PageSlab() or > page_count()? Yes. As they came up with that contrived rule what is acceptable for sendpage. No one else really knows and other subsystems like the block layer are perfectly fine with it. > > If it is unusual even for mm people, how could netdev people suppose > to understand this unusual mm bug? At least not any better. It is not a mm bug, it is a networking quirk.