Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 18 Aug 2020 17:22:33 +1000
From:   Nicholas Piggin <npiggin@gmail.com>
Subject: Re: [PATCH 1/2] lockdep: improve current->(hard|soft)irqs_enabled
 synchronisation with actual irq state
To:     peterz@infradead.org
Cc:     Alexey Kardashevskiy <aik@ozlabs.ru>, linux-arch@vger.kernel.org,
        linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
        Ingo Molnar <mingo@redhat.com>, Will Deacon <will@kernel.org>
References: <20200723105615.1268126-1-npiggin@gmail.com>
        <20200807111126.GI2674@hirez.programming.kicks-ass.net>
        <1597220073.mbvcty6ghk.astroid@bobo.none>
        <20200812103530.GL2674@hirez.programming.kicks-ass.net>
In-Reply-To: <20200812103530.GL2674@hirez.programming.kicks-ass.net>
MIME-Version: 1.0
Message-Id: <1597735273.s0usqkrlsk.astroid@bobo.none>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Excerpts from peterz@infradead.org's message of August 12, 2020 8:35 pm:
> On Wed, Aug 12, 2020 at 06:18:28PM +1000, Nicholas Piggin wrote:
>> Excerpts from peterz@infradead.org's message of August 7, 2020 9:11 pm:
>> >=20
>> > What's wrong with something like this?
>> >=20
>> > AFAICT there's no reason to actually try and add IRQ tracing here, it'=
s
>> > just a hand full of instructions at the most.
>>=20
>> Because we may want to use that in other places as well, so it would
>> be nice to have tracing.
>>=20
>> Hmm... also, I thought NMI context was free to call local_irq_save/resto=
re
>> anyway so the bug would still be there in those cases?
>=20
> NMI code has in_nmi() true, in which case the IRQ tracing is disabled
> (except for x86 which has CONFIG_TRACE_IRQFLAGS_NMI).
>=20

That doesn't help. It doesn't fix the lockdep irq state going out of
synch with the actual irq state. The code which triggered this with the
special powerpc irq disable has in_nmi() true as well.

Thanks,
Nick