Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp2932647pxa; Tue, 18 Aug 2020 01:47:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxy2g1CWyNOHsHNlwaE607+VVa2mBjZU5kI+aV1S3WSDG1cmkHpP/xsBTuwZ3fE6BctHHzz X-Received: by 2002:a17:906:6055:: with SMTP id p21mr19766943ejj.173.1597740461144; Tue, 18 Aug 2020 01:47:41 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1597740461; cv=pass; d=google.com; s=arc-20160816; b=paAqFa2HdRKBI1+h4vnrvZJpXZWTGwVMWtzN5mK6/1SNieqVLJJyZ9b3cgYXkNKOSE PZ9vDcFitm1sirAIB8LYX+H8p6UtcF0QuY7rFQy/ST6QBScpkHOaX0z/UeHuqeKnKJXc csxRkLxrDnuKjHHRjE8MYuwd8I3FjW4KZrImJzfoIuf5VvxhsFSyexydmuZKBdNn409y QtnWOPRzO88kobIl2JDvxbFNw57xNQqp9qy25/rozsyPbNgkDFX9TVBgBS4tEuu708UA VUNprsZF6+LIMQpnipxxdbozNs6oHKPG96NxACICTkXV/qKzO5XVhW6zwp4yOi7qo/hp DNOw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :content-id:content-language:accept-language:in-reply-to:references :message-id:date:thread-index:thread-topic:subject:cc:to:from :dkim-signature; bh=6kJpPpb2tM1i8t/9DA6GQ8XakZOuNv6Yw9EJoONomGY=; b=v752FiBrM6i/Kp24qkCvh+11RtOU/MMuv/m0jV7e8fKGG8HQulRRdrFz3lKYhR74tG vzv4LE9bGC7x4v727wYeSmSj8QGu9vxZtepM7me47lYuGaA45Z+4fbPLbz96dj034GMj HxUDn/XSnluE3l6vBhjIznxNlQMta6sBpXBqJTMiKt+iORtE5wTU3WfJmiK8FmgBohpn z3DPnjBWrnUHlJcGIcBLyrfKOqpBfRPBg7V0lqn+uOd6YOhJ1MaMG54FlJGKq/V5L6va EhJHdRrwNtHMty+7vRt5TL52UmIMciQWl649BLVlq92Zds8IU9OV1aWosBR6qpKmIVJ7 u+HQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@necglobal.onmicrosoft.com header.s=selector1-necglobal-onmicrosoft-com header.b=Uu4IsC2+; arc=pass (i=1 spf=pass spfdomain=nec.com dkim=pass dkdomain=nec.com dmarc=pass fromdomain=nec.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k21si13388903eja.290.2020.08.18.01.47.17; Tue, 18 Aug 2020 01:47:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@necglobal.onmicrosoft.com header.s=selector1-necglobal-onmicrosoft-com header.b=Uu4IsC2+; arc=pass (i=1 spf=pass spfdomain=nec.com dkim=pass dkdomain=nec.com dmarc=pass fromdomain=nec.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726474AbgHRIq3 (ORCPT + 99 others); Tue, 18 Aug 2020 04:46:29 -0400 Received: from mail-eopbgr1400075.outbound.protection.outlook.com ([40.107.140.75]:2272 "EHLO JPN01-TY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726145AbgHRIq1 (ORCPT ); Tue, 18 Aug 2020 04:46:27 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cWFT6Op+r4L8el/5sVj1GASuqvnDrS3wn67qgIJGo3RTTep5oPfoSs5PZ796DCA1nmmaHIWbR+8+6uJCE8nE5bRMo7QCEaGA/tPB1dbLLKutzlt0a7xraNSRLYtkecV2as5JJ7uL3npcLLVt6Lt+GDeSJEBYU9nxQADXK/sCjjdNcM6KWHQAxmw00ThfjeGxBJlQ32eH9KQpWVIr4WvtlAuHZQnFoOkHDpcBFoFewscQkxVvDyGNB9ZLl8mHGHkvGZbBfSffpS/nMW/2ZqbynHuNLVOIELUmAcYYP8LiBc2bCCak6jI40FU1pGZIjKieZr8/E0QJwex+UL+wcui4jQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6kJpPpb2tM1i8t/9DA6GQ8XakZOuNv6Yw9EJoONomGY=; b=STfg2koqpF3yUVlnYRcXKT711fwZpEODYxK+UzNljH0YvUnmjr/96Zd0MWzNQjbGjdqmX5jR313OrNvPX7jvHh6AAU8Z64xZPoQH0WLPoxz9f9XybMzZPFQuwkLqX1NTZTx7jwE5+sBfad2tmmgzPAKIHodGkTMzPSeevy0veFXhvsYmT3KFgB+i/cqlYSbXhm+WpGI5aYEMUwWvQla6UXpKalckiK+qIwU1VHOK4EckyUIDAQJT9D4KrBqZqLP5AmRC6jtot3QxEWPVUAF9LkpeMUvFQJQbNVETN5tqtsIG3vvtJACtmtHfN7n6e5KgjrkXxX/GXlgsS2khiLRKAA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nec.com; dmarc=pass action=none header.from=nec.com; dkim=pass header.d=nec.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=necglobal.onmicrosoft.com; s=selector1-necglobal-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6kJpPpb2tM1i8t/9DA6GQ8XakZOuNv6Yw9EJoONomGY=; b=Uu4IsC2+4porSLh3dq7O3sQ1GLLCJGF/LY58M8XqmNLKZekOYU9EZodiraAmVk4DSuWHFhwCWAdBVOF1Ubo3YsGwT97+UyRyTv3da9N03I6JKUZJao9yWAKii3JeZXm2pjnmcJaXDHBMRplDNWsIRt26R/6Tcw60BUrRz/sYoq0= Received: from TY2PR01MB3210.jpnprd01.prod.outlook.com (2603:1096:404:74::14) by TYAPR01MB3584.jpnprd01.prod.outlook.com (2603:1096:404:c4::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3283.15; Tue, 18 Aug 2020 08:46:23 +0000 Received: from TY2PR01MB3210.jpnprd01.prod.outlook.com ([fe80::21d2:e51a:a880:2042]) by TY2PR01MB3210.jpnprd01.prod.outlook.com ([fe80::21d2:e51a:a880:2042%7]) with mapi id 15.20.3283.023; Tue, 18 Aug 2020 08:46:23 +0000 From: =?iso-2022-jp?B?SE9SSUdVQ0hJIE5BT1lBKBskQktZOH0hIUQ+TGkbKEIp?= To: Xianting Tian CC: "akpm@linux-foundation.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] mm/memory-failure: do pgoff calculation before for_each_process() Thread-Topic: [PATCH] mm/memory-failure: do pgoff calculation before for_each_process() Thread-Index: AQHWdTpfy+qolaFA5Ee6XfcA6pvtAak9jaWA Date: Tue, 18 Aug 2020 08:46:23 +0000 Message-ID: <20200818084623.GA30688@hori.linux.bs1.fc.nec.co.jp> References: <20200818082647.34322-1-tian.xianting@h3c.com> In-Reply-To: <20200818082647.34322-1-tian.xianting@h3c.com> Accept-Language: ja-JP, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: h3c.com; dkim=none (message not signed) header.d=none;h3c.com; dmarc=none action=none header.from=nec.com; x-originating-ip: [165.225.110.205] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 46053f29-ef1c-4347-605c-08d843532ff6 x-ms-traffictypediagnostic: TYAPR01MB3584: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: v0ppkKxcv6QncxoCUoK5m9kp1Pu+IdKSAggkjhrTFj5SFzO1Gb6dc9rhGohFHsDf/CoQ+Zi2v062IDGfYc4/jKrKLQe5zTB1X030rlxN5R+ZXrKqVX4XwWDUNSoO3EppI7NMintfMvjouZNM/13QQhqfnv/b7SE2P4OvrvnMPuT9bk70HxRdfW7aVaXPzO2WrJJTBLaZYIsmLrxOKSxoUtdAJKFwSFCJQD4kl6HvM5TXwMhK+6hbF6t2eJLC6wHFtS76OAxXJVqagwdWT508Id1/iqk8GqEgjrks2ajqcyp/ki7Im/y+6kjb9Y/lPHHOtcgVjTWuPQDoWu3omtQoOA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TY2PR01MB3210.jpnprd01.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(396003)(136003)(366004)(346002)(39860400002)(71200400001)(33656002)(6486002)(6916009)(66476007)(1076003)(5660300002)(186003)(66946007)(64756008)(478600001)(54906003)(76116006)(66446008)(2906002)(66556008)(85182001)(316002)(26005)(9686003)(4326008)(6512007)(8676002)(6506007)(4744005)(8936002)(55236004)(86362001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: QJi2jZ/1kTErR+PSIim98l3/Uh8ayxCFx2JCWXaZ3ny5kdAGdsFCL1Wqb3HtYNWRnDGHoUIEdNwSN/Z949Jqs1LQYyDbKvTIYr1DEYvnbdzPd74H4Q3Gdck4rQK1RmRFW49sBKr3WYkj/NRd2iSDPAnh+Xuc0G0wM4pbrOM+blb7DTawuzDe8BytFLcoIewEMUrKxTHvuOitlgG+/Y6lxdq2YqJUJG9oRC2P/7y1EicCV49F56bDeL55BI/XgGXCCwtb7mrwHHtkpaONB5S+7TJb+eDY5upSU+T0z7RfcpnmUKNfSCZAPm81LBE6dVXWjMxbT3kLeWdD23qQImY+0rHVI7tshRJi6AnbHjygugHU8alN6IuBxKA1CkARGlFz5nLyk//e0iTZXr/NHRkEiktL3h+iJApdfu9w0Yon2SXyWT33v1dqmde2dU5sjgSTHZbvrVZABWvpWyLKXQzVQNJy70adKNWVqEdAt73c5t6dWfqQQar9DnvWIBKjkbcVI6pUQrmL9HEHdpOhi5yEiiT4NUXwFiNbQWtAhd/QPTbTzd+O7onFia3xFWVdvEXJ25uEk/fuuOpMZOa1EL6z5ic68H3jnG6WwjDIEwC+AHVHqdDbMP3IQwsfEXVxJo7tkHO/EcQgd2SSCj1yV6Ibdg== Content-Type: text/plain; charset="iso-2022-jp" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nec.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TY2PR01MB3210.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 46053f29-ef1c-4347-605c-08d843532ff6 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Aug 2020 08:46:23.7888 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: e67df547-9d0d-4f4d-9161-51c6ed1f7d11 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: hIKIvPCGeBQTr6gmTzxVu5ZQpWZYTcqn+Uo+CLS5GW2YG2GnF/CEuDjMYRie7/6rfsrNEZxK2cSc8Y/TWuJdKA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYAPR01MB3584 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 18, 2020 at 04:26:47PM +0800, Xianting Tian wrote: > There is no need to calcaulate pgoff in each loop of for_each_process(), > so move it to the place before for_each_process(), which can save some > CPU cycles. >=20 > Signed-off-by: Xianting Tian Looks good to me. Thank you. Acked-by: Naoya Horiguchi =