Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 18 Aug 2020 17:09:18 +0800
From:   Wei Yang <richard.weiyang@linux.alibaba.com>
To:     Wei Yang <richard.weiyang@linux.alibaba.com>
Cc:     alexander.h.duyck@linux.intel.com, akpm@linux-foundation.org,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org, david@redhat.com
Subject: Re: [Patch v2] mm/page_reporting: drop stale list head check in
 page_reporting_cycle
Message-ID: <20200818090917.GA34355@L-31X9LVDL-1304.local>
Reply-To: Wei Yang <richard.weiyang@linux.alibaba.com>
References: <20200818084448.33969-1-richard.weiyang@linux.alibaba.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200818084448.33969-1-richard.weiyang@linux.alibaba.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Aug 18, 2020 at 04:44:48PM +0800, Wei Yang wrote:
>list_for_each_entry_safe() guarantees that we will never stumble over
>the list head; "&page->lru != list" will always evaluate to true. Let's
>simplify.

[david@redhat.com: Changelog refine.]

>
>Signed-off-by: Wei Yang <richard.weiyang@linux.alibaba.com>
>Reviewed-by: David Hildenbrand <david@redhat.com>
>---
> mm/page_reporting.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/mm/page_reporting.c b/mm/page_reporting.c
>index 3bbd471cfc81..aaaa3605123d 100644
>--- a/mm/page_reporting.c
>+++ b/mm/page_reporting.c
>@@ -178,7 +178,7 @@ page_reporting_cycle(struct page_reporting_dev_info *prdev, struct zone *zone,
> 		 * the new head of the free list before we release the
> 		 * zone lock.
> 		 */
>-		if (&page->lru != list && !list_is_first(&page->lru, list))
>+		if (!list_is_first(&page->lru, list))
> 			list_rotate_to_front(&page->lru, list);
> 
> 		/* release lock before waiting on report processing */
>-- 
>2.20.1 (Apple Git-117)

-- 
Wei Yang
Help you, Help me