Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp2948020pxa; Tue, 18 Aug 2020 02:18:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyEcluxhSr5vPW5cuSyxw1CXDdgvnXdTOR20zPYwF70vy63co8lob6gKaxa8yTgSM6DstK5 X-Received: by 2002:a50:cbc3:: with SMTP id l3mr18977914edi.58.1597742306397; Tue, 18 Aug 2020 02:18:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597742306; cv=none; d=google.com; s=arc-20160816; b=BPPJJa9QZlFo8ELMa6RSFc3w/zQNHZ/u9/pv+xqdxit+nWrmiw5bQdnrHwaPK9vAdk SEcciEdeMfNKjooJHfgjYKlp0D4QlP+NJZ9BShMsofccC1V6haUmJAvmS7CRL/Y425MW leTveb+5K24ivB6WnX0U0Z26p1O7/0Cvd8fCWbKM07wknM2fV8lnNhodCWhUhLiWxqxm /5arYc6kSKm8UmXpulnWC+a5sCqwnM1btAEgad3rR7kNMpXMmFDgQ5d4a4l6I4VcMGSy gk6lBV40u+1wUHxVL5wnKV8Z2I5Nng08OQMp6bCT6NMy5vOwttiw2XiMJTd3ilMjKbe9 6Xjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=W2hKsTS1LvaI0SOO9W3/5fRfJY5aEh/BZWVO9XitBWs=; b=RBuqHP3YnOS+V9aQ48QtHsZb9y7f9q9enwygIquuuy0RcChwTfLru6py5FbTV4YPgZ YG0XEiLmn5rGHcYfJmyK4LuPj7yCtPuNN109b6kE5FBbXPDlzoDlc4zYHX1ZUPQ4f38u GSW2ZDsP8zh2zAj+f++I3I3b0k7MuFf0dS2U/MfY3/4m+/7RmXwjJihxRwHdOOdGWbVJ kGygJAtDS9v2gPrucnu4FM6IbXeZI5Uo6VYla6Jkfg0OcP0cI1lKeozcsu8y4Oosrwk6 O6hmajlG8RQza0I5cp3uhQYi9xjVvJgO3E67dhf52OYSCH0MrXAY7kYpov6+uUhvCQBB Jv4A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=eGoDITci; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h9si12670444ejy.326.2020.08.18.02.18.02; Tue, 18 Aug 2020 02:18:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=eGoDITci; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726636AbgHRJPF (ORCPT + 99 others); Tue, 18 Aug 2020 05:15:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58540 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726203AbgHRJPE (ORCPT ); Tue, 18 Aug 2020 05:15:04 -0400 Received: from mail-ot1-x341.google.com (mail-ot1-x341.google.com [IPv6:2607:f8b0:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8856EC061389; Tue, 18 Aug 2020 02:15:04 -0700 (PDT) Received: by mail-ot1-x341.google.com with SMTP id a65so15695030otc.8; Tue, 18 Aug 2020 02:15:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=W2hKsTS1LvaI0SOO9W3/5fRfJY5aEh/BZWVO9XitBWs=; b=eGoDITciADrWQe3gs29cyT8xT1NKm5rz9rVcVLDn/bbuYp8fgY1hSDfcgcO2Y8A/FE zDJ9bm6G+z2N4IP6u1ELlhwB/iZ+1A+IwLuPDXV50yqTfWBpi2yoklrT0psD6GdMzRGm mKZXpjNtcSxOPcLuAlO8t6rlea5KpMBIJZl+zd87Fs8FGCP4YglR+Cy8uqT+GzI0stq3 viuaxAQxm/6lWfM0J1ue15DTH6MQ6CtMtlUoD1oYGIxuyF9v8tv3Vn0TjcM5dSCK8JbS fjcwz39yKbHCwapnbDs3GWnek7Qbumu+oEcYnimX4XO6Q66JRWEkGZLHrLAcc8kim4hs +0yA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=W2hKsTS1LvaI0SOO9W3/5fRfJY5aEh/BZWVO9XitBWs=; b=Gg+gEN8DUXLNvd3H4jM2RyIIxCbIyZqazH6jdWzal0lIUTvhZ8zjq2ws+ZwsblG3W6 SV0/LrC8a1jWrvZTG9CFDk9sutJWvHr34r2B3y4IJxgBYWiiIHVEoRZ5oHl9IqIi3hvb xlPRm6rnxr2580QuVR9DR0FD2lyJnYs5sccc7wju/2wIrB4Bo2ePAQuZtzOG+zgOpOQ4 /4mH59nkYKC6lQOFzR12ec8rDUxHGJyTxs12CofLm8HqqKDgAMf4bdrCHEpMaajMBrEc SY6ejebc95bw4Y0T6hesUgDpDDuHzYooxTVjRaoX5xQ/0qIeT+sVqGPJo1GLaDVE80HC EuVw== X-Gm-Message-State: AOAM533C+t6/sLu1xMpNWQjk+UxQaSLw48k9x28hav1/9fyNDFL5fNEA 8iMh0vebwTV7a8tzAOoC8aMuuxe+d7dMosLcwPs= X-Received: by 2002:a9d:774d:: with SMTP id t13mr13781704otl.108.1597742104000; Tue, 18 Aug 2020 02:15:04 -0700 (PDT) MIME-Version: 1.0 References: <20200817082434.21176-1-allen.lkml@gmail.com> <20200817082434.21176-8-allen.lkml@gmail.com> <20200817083216.5367f56a@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20200817083216.5367f56a@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> From: Allen Date: Tue, 18 Aug 2020 14:44:52 +0530 Message-ID: Subject: Re: [PATCH 06/20] ethernet: chelsio: convert tasklets to use new tasklet_setup() API To: Jakub Kicinski Cc: jes@trained-monkey.org, David Miller , kda@linux-powerpc.org, dougmill@linux.ibm.com, cooldavid@cooldavid.org, mlindner@marvell.com, borisp@mellanox.com, Kees Cook , linux-acenic@sunsite.dk, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-rdma@vger.kernel.org, oss-drivers@netronome.com, Romain Perier Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > You need to adjust kdoc when you change functions: > > drivers/net/ethernet/chelsio/cxgb4/sge.c:2664: warning: Function parameter or member 't' not described in 'restart_ctrlq' > drivers/net/ethernet/chelsio/cxgb4/sge.c:2664: warning: Excess function parameter 'data' description in 'restart_ctrlq' > drivers/net/ethernet/chelsio/cxgb4/sge.c:2965: warning: Function parameter or member 't' not described in 'restart_ofldq' > drivers/net/ethernet/chelsio/cxgb4/sge.c:2965: warning: Excess function parameter 'data' description in 'restart_ofldq' Thanks, will fix it and spin V2. -- - Allen