Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp2948591pxa; Tue, 18 Aug 2020 02:19:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyr4S2WDQHHN7S67RaJbCUBw4ENHB2gJiyXrzs7bH201CU3LTUW0oA+eApYtrs0f/r7rJCN X-Received: by 2002:a05:6402:22c8:: with SMTP id dm8mr19740593edb.41.1597742371184; Tue, 18 Aug 2020 02:19:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597742371; cv=none; d=google.com; s=arc-20160816; b=XTPBVo19MptthjnCFbUj3TSsBR47oyg4/HTey9BQlTS6n+e12IipOLyOvqUDpZ/weZ Vk1MKKSTIAw0hp7vWHNECi+cNkXYhi632z+QChzDn7UmzMZR18uuTjL9IQDiEus9nWlz yY+dZhRTwgTt3obxkefCjmsTrtHRl2iOPOrs93P3+/onf51jdJ54tXcWakLaGrsh9roL jFFZzWcMX1QI/b34txAYm2rIIwGqpwJs5k7t0EHbO1WW87EnWyIg3DHp8EmIY5GN5SMx 7QWLng4booVt0YqkkgnyakIaQKPybKMgnEd3+5ICCCvO0nbys5/82eD7HDGbR++UihV1 5sUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=1eliUMZTEbkWBf+VQBrm/YQjJEBrlLW04a4iyHZxDds=; b=VEI9JOyHFMClMKDJZy+SMw920TNaqHNF0ZBgzrI5hJj/oUgtEJ5TZ8b/BX5ixomu7j y3Hzewy5ryAhNKK8q5p2MdDEB80w0k7Sz8Nbr4/fr+exMVwwBMW3H34duBJQgfRz3++k WOTcAOY3Z9DyC1tbXQ8rtXCQ1E3jTxw2Cd2MNIxZFhhopF3wfCsBupdrhD8uJVo2/h3A HVL9dT74VsV4zEeq5ZdUdcCNbYmbQOckO1jQmRLL5R+GZNQi83uDcagpKvmNMqM10/L2 EwJwxx7Uwx3LT1uzQjjGAjf7vvcxzSzMlQRivuMLpFc48cCqkDHIID2BYIbNBA6/pTht 5xJA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=Od+3yT40; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e23si15682530ejl.306.2020.08.18.02.19.07; Tue, 18 Aug 2020 02:19:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=Od+3yT40; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726435AbgHRJQd (ORCPT + 99 others); Tue, 18 Aug 2020 05:16:33 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:46190 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726203AbgHRJQc (ORCPT ); Tue, 18 Aug 2020 05:16:32 -0400 Received: from pps.filterd (m0098419.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 07I93MQb177743; Tue, 18 Aug 2020 05:16:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=1eliUMZTEbkWBf+VQBrm/YQjJEBrlLW04a4iyHZxDds=; b=Od+3yT40b9LWYR89wCo4gH7As4E9LvfaHi0ToROvnk3au7H4YJfIiugv44RiJLGBqWVr Y5S4cW1FrlKapHMPe+pQ+Gm4SKuOroBZzGY7u4KyvwKRvgygz+LF4C3z2Trf9eadrjs3 Mf53sx5zWn8vt6RDpAuiJNxxQaIIi+lLSdrVmKIqMKdLrmAh292FPhDNVa8IJHAvSUdl qGZSKSZR3ht7EAXFDnk7jE6a256W/qn1Tc3+z8Tr89ii1VGPgLmD+CPyCKCbMTqc7Qa1 Ii3Yw3w0hCwyzt4xD862F1qcNJ5gS9AI1kqR81o2uBzaCJuiasT77BQ6j81KyJDHGilC Ww== Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com with ESMTP id 3304t1b4kv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 18 Aug 2020 05:16:22 -0400 Received: from m0098419.ppops.net (m0098419.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 07I93OU0177841; Tue, 18 Aug 2020 05:16:21 -0400 Received: from ppma04dal.us.ibm.com (7a.29.35a9.ip4.static.sl-reverse.com [169.53.41.122]) by mx0b-001b2d01.pphosted.com with ESMTP id 3304t1b4kg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 18 Aug 2020 05:16:21 -0400 Received: from pps.filterd (ppma04dal.us.ibm.com [127.0.0.1]) by ppma04dal.us.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 07I9FDPk032481; Tue, 18 Aug 2020 09:16:20 GMT Received: from b03cxnp07029.gho.boulder.ibm.com (b03cxnp07029.gho.boulder.ibm.com [9.17.130.16]) by ppma04dal.us.ibm.com with ESMTP id 3304uqb88s-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 18 Aug 2020 09:16:20 +0000 Received: from b03ledav003.gho.boulder.ibm.com (b03ledav003.gho.boulder.ibm.com [9.17.130.234]) by b03cxnp07029.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 07I9GJCX63701320 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 18 Aug 2020 09:16:19 GMT Received: from b03ledav003.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1A02C6A047; Tue, 18 Aug 2020 09:16:19 +0000 (GMT) Received: from b03ledav003.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5F1636A054; Tue, 18 Aug 2020 09:16:12 +0000 (GMT) Received: from localhost.localdomain (unknown [9.199.37.32]) by b03ledav003.gho.boulder.ibm.com (Postfix) with ESMTP; Tue, 18 Aug 2020 09:16:11 +0000 (GMT) Subject: Re: [PATCH v5 1/3] perf jevents: Add support for parsing perchip/percore events To: Andi Kleen Cc: acme@kernel.org, peterz@infradead.org, mingo@redhat.com, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, pc@us.ibm.com, jolsa@redhat.com, namhyung@kernel.org, yao.jin@linux.intel.com, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, irogers@google.com, maddy@linux.ibm.com, ravi.bangoria@linux.ibm.com, anju@linux.vnet.ibm.com, kan.liang@linux.intel.com, nasastry@in.ibm.com References: <20200816090719.72018-1-kjain@linux.ibm.com> <20200816090719.72018-2-kjain@linux.ibm.com> <20200816163521.GF1486171@tassilo.jf.intel.com> From: kajoljain Message-ID: <1265e9f4-fcfd-bb21-bf27-4ce56a04bcb9@linux.ibm.com> Date: Tue, 18 Aug 2020 14:46:10 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <20200816163521.GF1486171@tassilo.jf.intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235,18.0.687 definitions=2020-08-18_06:2020-08-18,2020-08-18 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 adultscore=0 suspectscore=0 mlxscore=0 lowpriorityscore=0 mlxlogscore=999 malwarescore=0 phishscore=0 priorityscore=1501 bulkscore=0 clxscore=1015 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2008180060 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/16/20 10:05 PM, Andi Kleen wrote: >> @@ -321,7 +331,7 @@ static void print_events_table_prefix(FILE *fp, const char *tblname) >> static int print_events_table_entry(void *data, char *name, char *event, >> char *desc, char *long_desc, >> char *pmu, char *unit, char *perpkg, >> - char *metric_expr, >> + char *metric_expr, char *aggr_mode, >> char *metric_name, char *metric_group, >> char *deprecated, char *metric_constraint) > > We should really define a struct now to pass the parameters, > the callback prototype is getting ridiculous. > > I know it's my fault originally, but sorry you probably have to do it > because you are touching it last. Hi Andi, I will look into it. Thanks, Kajol Jain > > -Andi >