Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp2977973pxa; Tue, 18 Aug 2020 03:18:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwIu1pOVHeX3CoIVAIBTo/mA+6RvpLyqWHiMI+L1IV9szJLFZsfZv9NnQJj+ycgwyUOfxC0 X-Received: by 2002:aa7:c251:: with SMTP id y17mr19484972edo.13.1597745911209; Tue, 18 Aug 2020 03:18:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597745911; cv=none; d=google.com; s=arc-20160816; b=NBmi75gzHnL1dAxmOxgrcSYtZqlIq0v5HNXIDzdzb/O9vFr0hsj1fb2qRB/CvrehUb akLEHBGF6I10GDoktkaXaolMXjounrla1xyo9EZPJQiwx8z6AmyTAfzAthPQGEJNMkSy SPv51y6or1D6kNrmINg+gZOlMopaMgk62Yomxj/QCSqRpfBjy0y2pa2h+Kiqz79h7+H/ lbQk/r0NZhRzENDeR3GzU73U9ZVejY56GFApcFHe6+h3m43lIYIUJNHiDWfM2Zj7BOp6 ostIdGhTXl9STCyN1ZtnNmPCDMCh1y/Rnr/3KxkS2V3zgKmpxDytgtf1y2dH5OG9ZOiH x6eA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=FqYkJWbp2CqJsKild8oLvagZa+ayPCfiD4I36979iNM=; b=AZ315a6xv7yyCB3eSU6k6bygO0nw48KoXBppjbF2e1vLi8Vbura/hqhBBIgB6lsfrg aMhLN+mPR2xLMZdUEezyZVDmLVL0H67sbrWYy0rJHTbaEQ76HUwc87gvHt7HC/SQCSWL nGoPuTeeEggXhcXgqZZp/o7xfD+JTXLDVANZhLjdimp/L7lHdCoZ13SiAN9wyzSK09XQ pMNg+yZfABdJdCg+w4+5/Z6kiE7cDaFzpK64TSvx5YolBLMPIKBctAxKqcilVEGcytQb fdTCpkQblEf6kB9CxAxbP03T6oclIMaqHWgkAGWWklCEtYIh9k1FnWXJqDVDVa7HlGu8 +B3w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cm21si12866478edb.111.2020.08.18.03.18.07; Tue, 18 Aug 2020 03:18:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726632AbgHRKPr (ORCPT + 99 others); Tue, 18 Aug 2020 06:15:47 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:38364 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726145AbgHRKPq (ORCPT ); Tue, 18 Aug 2020 06:15:46 -0400 Received: from ip5f5af70b.dynamic.kabel-deutschland.de ([95.90.247.11] helo=wittgenstein) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1k7yed-0001Hy-JQ; Tue, 18 Aug 2020 10:15:43 +0000 Date: Tue, 18 Aug 2020 12:15:42 +0200 From: Christian Brauner To: "Eric W. Biederman" Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, criu@openvz.org, bpf@vger.kernel.org, Linus Torvalds , Alexander Viro , Oleg Nesterov , Cyrill Gorcunov , Jann Horn , Kees Cook , Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= , Jeff Layton , Miklos Szeredi , Matthew Wilcox , "J. Bruce Fields" , Matthew Wilcox , Trond Myklebust , Chris Wright , Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , Andrii Nakryiko , John Fastabend , KP Singh Subject: Re: [PATCH 14/17] file: Merge __fd_install into fd_install Message-ID: <20200818101542.ipedpjtv652oqxgf@wittgenstein> References: <87ft8l6ic3.fsf@x220.int.ebiederm.org> <20200817220425.9389-14-ebiederm@xmission.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200817220425.9389-14-ebiederm@xmission.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 17, 2020 at 05:04:22PM -0500, Eric W. Biederman wrote: > The function __fd_install was added to support binder[1]. With binder > fixed[2] there are no more users. Further with get_files_struct > removed there can be no more users of __fd_install that pass anything > except current->files. > > As fd_install just calls __fd_install with "files=current->files", > merge them together by transforming the files parameter into a > local variable initialized to current->files. > > [1] f869e8a7f753 ("expose a low-level variant of fd_install() for binder") > [2] 44d8047f1d87 ("binder: use standard functions to allocate fds") > Signed-off-by: "Eric W. Biederman" > --- +1 on __fd_install() going away. Acked-by: Christian Brauner