Message-ID: <446D0573.4050204@myri.com>
Date: Fri, 19 May 2006 01:38:27 +0200
From: Brice Goglin <brice@myri.com>
User-Agent: Thunderbird 1.5.0.2 (X11/20060516)
MIME-Version: 1.0
To: Roland Dreier <rdreier@cisco.com>
CC: netdev@vger.kernel.org, gallatin@myri.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] myri10ge - Driver core
References: <20060517220218.GA13411@myri.com>	<20060517220608.GD13411@myri.com> <adairo446u3.fsf@cisco.com>
In-Reply-To: <adairo446u3.fsf@cisco.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1080
Lines: 35

Roland Dreier wrote:
> Still some suspicious uses of volatile here.
>
> For example:
>
>   
>> +struct myri10ge_priv {
>>     
>  ...
>   
>> +	volatile u8 __iomem *sram;
>>     
>
> as far as I can see this is always used with proper __iomem accessors,
> often with casts to strip the volatile anyway.  So why is volatile needed?
>
> I would suggest an audit of all uses of volatile in the driver, since
> "volatile" in drivers really should be read "there's probably a bug
> here, and if not something very tricky is going on."  If there are any
> valid uses of volatile then a comment should explain why, so that
> future reviewers don't have to try and puzzle out which of the
> two possible translations of volatile is correct.
>   

You are right, we audited the code and it looks like we don't need any
volatile.

Thanks,
Brice

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/