Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp3139246pxa; Tue, 18 Aug 2020 07:36:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw9HZYGWHCdkgs6BhlveblWttrihPqikRr/X4L9HdFcGlTrzEGPRQk21u2QRppYlNKzalhC X-Received: by 2002:a05:6402:1427:: with SMTP id c7mr20880732edx.245.1597761391045; Tue, 18 Aug 2020 07:36:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597761391; cv=none; d=google.com; s=arc-20160816; b=kYXYApF1YWO2ciJ65b2sMw+ci5p6NkF6vABGYPSqGD2qf6+G2aBsTL88lWtVWcKhXL Wup7rchNg9cXb/aw24Uljp5yiey6EkQth8daDlknIDsuNOdvRx7C6Xy+tnjYYKMjm8n8 NnHn/8Ci2u/+zQLO+EMskcr9UlyojwsfKZxG04iy7vFwR+ksFuplhCP6qqmnzfzSyj/F UBwH5MDc2bUNbkzvF8w3Jf4rfcHdVG8bdEZMbnx9Oz9NC/alMhgBeIioCLMXcAuKuyD1 7EHMW7PM/Ox4mLJRKWNuPkOT09SKYaLPzK4zWM1066oX5UfgWq7ubf8TqN6Zw6E7CIeq jyPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:ironport-sdr:ironport-sdr; bh=lddtMeRWS0iuoXoKD11fGPbu3hxW38ARx2g2jx3u+6o=; b=cWPyCzhBAX+uIo/qhvV2YhgEfneYKV+V03pFiKenBwLME9wvdTHjmmVQkfyPhjJYZA u/8LC000CkZfOJ/s81GThWnfVUXgtCRphOkw4+L1rLoEeslKGKJ7AJTfowojDf1TOgvl ujPtsJHhuVCQllCxdc4MTy2sRr97oec7CCye86//unBZl8o9emmLMikqtAnxiUgf7cbF 4fA5zcfny5pHGJyz5TIVBxH2GM8Fbvoxq9GhZ+i9RZc4cFE/bjbVbESrYISnfJTRdJr6 7BKIcxiki4RKo3ccWymg1hrtpxjZLKyKv8NG6cKM9e8xsmDFd7Pm9lE/7f5PmKQSadr5 ggoA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 39si13953518edq.552.2020.08.18.07.36.06; Tue, 18 Aug 2020 07:36:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727033AbgHROf0 (ORCPT + 99 others); Tue, 18 Aug 2020 10:35:26 -0400 Received: from mga14.intel.com ([192.55.52.115]:33372 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727021AbgHROfX (ORCPT ); Tue, 18 Aug 2020 10:35:23 -0400 IronPort-SDR: tSHcMHsobdSul9tyH2XLliJ0z7/QXwPNgbTGp4ycpp2INfEZALnzwPUA1SHF/rN9Lqdr99zhaj zhveQoKJP1lA== X-IronPort-AV: E=McAfee;i="6000,8403,9716"; a="154170454" X-IronPort-AV: E=Sophos;i="5.76,327,1592895600"; d="scan'208";a="154170454" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Aug 2020 07:35:22 -0700 IronPort-SDR: mJdXbCWdxOR7a6Q4QjeYKaPcZxbFWdVEEGC0RP0aoEQ+EeiHREsNbOYHR2uyrXUIg5KeDuAppf QcCeS+6DyOqw== X-IronPort-AV: E=Sophos;i="5.76,327,1592895600"; d="scan'208";a="471830344" Received: from bard-ubuntu.sh.intel.com ([10.239.13.33]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Aug 2020 07:35:16 -0700 From: Bard Liao To: alsa-devel@alsa-project.org, vkoul@kernel.org Cc: vinod.koul@linaro.org, linux-kernel@vger.kernel.org, tiwai@suse.de, broonie@kernel.org, gregkh@linuxfoundation.org, jank@cadence.com, srinivas.kandagatla@linaro.org, rander.wang@linux.intel.com, ranjani.sridharan@linux.intel.com, hui.wang@canonical.com, pierre-louis.bossart@linux.intel.com, sanyog.r.kale@intel.com, mengdong.lin@intel.com, bard.liao@intel.com Subject: [PATCH 02/11] soundwire: intel: ignore software command retries Date: Tue, 18 Aug 2020 10:41:11 +0800 Message-Id: <20200818024120.20721-3-yung-chuan.liao@linux.intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200818024120.20721-1-yung-chuan.liao@linux.intel.com> References: <20200818024120.20721-1-yung-chuan.liao@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Pierre-Louis Bossart with multiple links synchronized in hardware, retrying commands in software is not recommended. Signed-off-by: Pierre-Louis Bossart Signed-off-by: Bard Liao --- drivers/soundwire/intel.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/soundwire/intel.c b/drivers/soundwire/intel.c index fe9b92fd48db..c9ba706e20c6 100644 --- a/drivers/soundwire/intel.c +++ b/drivers/soundwire/intel.c @@ -1355,6 +1355,11 @@ static int intel_master_probe(struct platform_device *pdev) dev_info(dev, "SoundWire master %d is disabled, will be ignored\n", bus->link_id); + /* + * Ignore BIOS err_threshold, it's a really bad idea when dealing + * with multiple hardware synchronized links + */ + bus->prop.err_threshold = 0; return 0; } -- 2.17.1