Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp3140773pxa; Tue, 18 Aug 2020 07:38:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzAcW8DnwTltr3iHTwBcTLHvDRRhImqnqNOcW3DPu441xU07KsoJuXelksIy1qLIaNj0rlY X-Received: by 2002:a17:906:d8ca:: with SMTP id re10mr19745651ejb.382.1597761515088; Tue, 18 Aug 2020 07:38:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597761515; cv=none; d=google.com; s=arc-20160816; b=0jWxjfEbuO+Cs62k/afCjwTvhhmNqzUnyLTy+nCm8Dl/EcodkiKpPsPGdkN6XGvr4f siB3OwHq9+YP9krsPI27JZZubmiMqY3J0hEcERslNL0bbHfjYpil2YK9ooAWOTuTwHMO yVU48LpZGcMQqMsxmCpQh1X4A4QuEJfSwOfJg+qgplIgsveB691sa2/OxIpQba6YrT4M 0UEIG/PdbLiftBPm+2y4oQNrRzxLij/XXTtANCeJ8rRKXBX2UIS1lKI3WXfqe5qxZqJX MuSJzx5GcKdg2BuHLfjJzymviQt+hoV7xT2+UQae+GlFOib6q4WFqrA9v2OuxfrmzPTY WvCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:from:references:cc:to:subject; bh=HgYZrAake/uzt3aJOUtpsteAt3DU0kmaugtquDlc2uA=; b=EVTFH9GCv8jmFNFeSzdF8u008mBMlTXzHg+8MBhb2EW6qQYwAPDd526+0M9Q1p7+DO 52cL+xSFPI3Ug0nPn0E95LeAtZ9UoZ5HrJN9Nhrn7QiYzH7Zr+dDmKuGj7NNX0XkdJDq +jePOSGxNwnWRMPgX85y0fMMTai3Ca6kcAgt18gmnUE1nyMWnkobyWHYQfn3T8DPWXho NqpcXItR5n66hw7SGCSrRzvMKQfNs79ROu5zYNdomxzdipWkBnXRQJL/K5a6G9arf7Qt CCVN2toPloTDnQ+ioUMvzMB9mANkTc94A4H/9GQpHd6a+AVEiegmkCvwgY6SMLKptXTX ig0w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bw6si13822623ejb.653.2020.08.18.07.38.11; Tue, 18 Aug 2020 07:38:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727877AbgHROhK (ORCPT + 99 others); Tue, 18 Aug 2020 10:37:10 -0400 Received: from mail-pf1-f193.google.com ([209.85.210.193]:35789 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726145AbgHROhI (ORCPT ); Tue, 18 Aug 2020 10:37:08 -0400 Received: by mail-pf1-f193.google.com with SMTP id d188so10063134pfd.2; Tue, 18 Aug 2020 07:37:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=HgYZrAake/uzt3aJOUtpsteAt3DU0kmaugtquDlc2uA=; b=gUviDmXxe9EVFUBbm6wdg+uNQvsQyG36aNt8aQg0HoiiMpdNNc3byIY+GAK6vZrDTy SOnP64+liD3XOJCYWvMmc3XcYnpb7TRC1f+sSfvroHRBVAGppoMJHC1VU9InjEZsseOn MbxgSscsW1yqdAmdP2UfU5dQJrB/3t5n42zBz2jNwNEIOXRlzcjFIao5QcZJSktU8prp lEFfhyMSTvEVQNIN/SViWsBoVB1oegGn9UVbZWwZYABTB9SURRAAYStLC6scgCQxJBH3 74R4iUkZ0/BzOAvuwuc4mxIpBPZECW6v4T2Uz617eMIArwnd0ywdd9MBmT1QapZ4mm9z Xs6g== X-Gm-Message-State: AOAM53254faawMusulcg2web0yFjBxs3TXu/eRYZmTt0OG7XVWveiwdP BIj28znvuI5st0l6ko9r9a4sxlwquS4= X-Received: by 2002:a63:ff0b:: with SMTP id k11mr6786701pgi.156.1597761426300; Tue, 18 Aug 2020 07:37:06 -0700 (PDT) Received: from [192.168.3.217] (c-73-241-217-19.hsd1.ca.comcast.net. [73.241.217.19]) by smtp.gmail.com with ESMTPSA id a15sm24430330pfo.185.2020.08.18.07.37.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Aug 2020 07:37:04 -0700 (PDT) Subject: Re: [PATCH] scsi: ufs: Remove an unpaired ufshcd_scsi_unblock_requests() in err_handler() To: Can Guo , asutoshd@codeaurora.org, nguyenb@codeaurora.org, hongwus@codeaurora.org, rnayak@codeaurora.org, linux-scsi@vger.kernel.org, kernel-team@android.com, saravanak@google.com, salyzyn@google.com Cc: Alim Akhtar , Avri Altman , "James E.J. Bottomley" , "Martin K. Petersen" , Stanley Chu , Bean Huo , open list References: <1597728047-39936-1-git-send-email-cang@codeaurora.org> From: Bart Van Assche Autocrypt: addr=bvanassche@acm.org; prefer-encrypt=mutual; keydata= mQENBFSOu4oBCADcRWxVUvkkvRmmwTwIjIJvZOu6wNm+dz5AF4z0FHW2KNZL3oheO3P8UZWr LQOrCfRcK8e/sIs2Y2D3Lg/SL7qqbMehGEYcJptu6mKkywBfoYbtBkVoJ/jQsi2H0vBiiCOy fmxMHIPcYxaJdXxrOG2UO4B60Y/BzE6OrPDT44w4cZA9DH5xialliWU447Bts8TJNa3lZKS1 AvW1ZklbvJfAJJAwzDih35LxU2fcWbmhPa7EO2DCv/LM1B10GBB/oQB5kvlq4aA2PSIWkqz4 3SI5kCPSsygD6wKnbRsvNn2mIACva6VHdm62A7xel5dJRfpQjXj2snd1F/YNoNc66UUTABEB AAG0JEJhcnQgVmFuIEFzc2NoZSA8YnZhbmFzc2NoZUBhY20ub3JnPokBOQQTAQIAIwUCVI67 igIbAwcLCQgHAwIBBhUIAgkKCwQWAgMBAh4BAheAAAoJEHFcPTXFzhAJ8QkH/1AdXblKL65M Y1Zk1bYKnkAb4a98LxCPm/pJBilvci6boefwlBDZ2NZuuYWYgyrehMB5H+q+Kq4P0IBbTqTa jTPAANn62A6jwJ0FnCn6YaM9TZQjM1F7LoDX3v+oAkaoXuq0dQ4hnxQNu792bi6QyVdZUvKc macVFVgfK9n04mL7RzjO3f+X4midKt/s+G+IPr4DGlrq+WH27eDbpUR3aYRk8EgbgGKvQFdD CEBFJi+5ZKOArmJVBSk21RHDpqyz6Vit3rjep7c1SN8s7NhVi9cjkKmMDM7KYhXkWc10lKx2 RTkFI30rkDm4U+JpdAd2+tP3tjGf9AyGGinpzE2XY1K5AQ0EVI67igEIAKiSyd0nECrgz+H5 PcFDGYQpGDMTl8MOPCKw/F3diXPuj2eql4xSbAdbUCJzk2ETif5s3twT2ER8cUTEVOaCEUY3 eOiaFgQ+nGLx4BXqqGewikPJCe+UBjFnH1m2/IFn4T9jPZkV8xlkKmDUqMK5EV9n3eQLkn5g lco+FepTtmbkSCCjd91EfThVbNYpVQ5ZjdBCXN66CKyJDMJ85HVr5rmXG/nqriTh6cv1l1Js T7AFvvPjUPknS6d+BETMhTkbGzoyS+sywEsQAgA+BMCxBH4LvUmHYhpS+W6CiZ3ZMxjO8Hgc ++w1mLeRUvda3i4/U8wDT3SWuHcB3DWlcppECLkAEQEAAYkBHwQYAQIACQUCVI67igIbDAAK CRBxXD01xc4QCZ4dB/0QrnEasxjM0PGeXK5hcZMT9Eo998alUfn5XU0RQDYdwp6/kMEXMdmT oH0F0xB3SQ8WVSXA9rrc4EBvZruWQ+5/zjVrhhfUAx12CzL4oQ9Ro2k45daYaonKTANYG22y //x8dLe2Fv1By4SKGhmzwH87uXxbTJAUxiWIi1np0z3/RDnoVyfmfbbL1DY7zf2hYXLLzsJR mSsED/1nlJ9Oq5fALdNEPgDyPUerqHxcmIub+pF0AzJoYHK5punqpqfGmqPbjxrJLPJfHVKy goMj5DlBMoYqEgpbwdUYkH6QdizJJCur4icy8GUNbisFYABeoJ91pnD4IGei3MTdvINSZI5e Message-ID: Date: Tue, 18 Aug 2020 07:37:03 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <1597728047-39936-1-git-send-email-cang@codeaurora.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-08-17 22:20, Can Guo wrote: > Commit 5586dd8ea250a ("scsi: ufs: Fix a race condition between error > handler and runtime PM ops") moves the ufshcd_scsi_block_requests() inside > err_handler(), but forgets to remove the ufshcd_scsi_unblock_requests() in > the early return path. Correct the coding mistake. > > Signed-off-by: Can Guo Hi Can, Please add a "Fixes:" tag. Thanks, Bart.