Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp3144493pxa; Tue, 18 Aug 2020 07:44:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwAE8wS47RGcJOC5WY/pQiLhH0QV4GOvPuTzzR9N0csbynZ1bgWOIoFdFgnr7JE4VD9WwbH X-Received: by 2002:a17:906:e24f:: with SMTP id gq15mr20298391ejb.46.1597761843759; Tue, 18 Aug 2020 07:44:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597761843; cv=none; d=google.com; s=arc-20160816; b=TMnXfqOIT7R3xrgCmX9mGhKRkBK37KR8oQ8/2IY3z2WW8wy7FoKrs8Ad7rsjzGwHqN Vn/G0W7GbGQMAA+zd5YoKnWCtGRArHLx5PL1H7OLGzsGDzocXq4IbNP1PRNl9Ko0KnXp k5d3+Yxf2z3Xq9+8GihJhl2FjVgSaFw7LVCdRZKm8NW6/ZopvxXZbLIV1AE4uE9w8SDv As0/UTr287lmATHJFUqmaHIZy0pH3e7ZEhWoVWN6kn5d1SPMVrallXmF+LQfdN40iMGO 5vvrGAUbjMbQqAOTlYHIJRM12DZn5TbqC0IKImNqE/5kd3xeLpI049KQi4SNKLvkzvWY n55A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:cc :to:from; bh=gW2k3OgiRdtqJsElnyf8z8QBBh6GOFvSzXfYOsOobXg=; b=lj1uAldXUCyBl4alGezjMTxVbgh9GnxSInVj8+Ov4yHY+/ddoe7rrThjJr5+tyqCqK vnXY1u4xMiZZBFHxUMt0lazjnfyknX65PQ2or8NETd16ieRre+EXsQH3xPgH/5Z6Z037 glx5VZ5fiAxOg8kQNpYMB4srC2eWT5EdVFP2QGGxCL3rNoN+1rA8YAh/5NFG8oO+tr4B ed95OsoS9lYAopxhVFGxfPkw+mHhmOvf+wDmu1sBxBwew64GVJULdR/nKSOuEGBppgL2 wDhj3R+eGrKJzlewn55qPA0QTP71GxQB2IK4Ltv3SjnJhDNEHocXPy0W+wDK1kc/8qSh KF2A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y24si13781936eje.87.2020.08.18.07.43.40; Tue, 18 Aug 2020 07:44:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727782AbgHROlZ (ORCPT + 99 others); Tue, 18 Aug 2020 10:41:25 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:9767 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727783AbgHROlV (ORCPT ); Tue, 18 Aug 2020 10:41:21 -0400 Received: from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 8D3A3CA22FF82614D1D8; Tue, 18 Aug 2020 22:41:18 +0800 (CST) Received: from localhost (10.174.179.108) by DGGEMS408-HUB.china.huawei.com (10.3.19.208) with Microsoft SMTP Server id 14.3.487.0; Tue, 18 Aug 2020 22:41:08 +0800 From: YueHaibing To: , , , , , , CC: , , , , YueHaibing Subject: [PATCH] net: stmmac: Fix signedness bug in stmmac_probe_config_dt() Date: Tue, 18 Aug 2020 22:39:52 +0800 Message-ID: <20200818143952.50752-1-yuehaibing@huawei.com> X-Mailer: git-send-email 2.10.2.windows.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.174.179.108] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The "plat->phy_interface" variable is an enum and in this context GCC will treat it as an unsigned int so the error handling is never triggered. Fixes: b9f0b2f634c0 ("net: stmmac: platform: fix probe for ACPI devices") Signed-off-by: YueHaibing --- drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c index f32317fa75c8..b5b558b02e7d 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c @@ -413,7 +413,7 @@ stmmac_probe_config_dt(struct platform_device *pdev, const char **mac) } plat->phy_interface = device_get_phy_mode(&pdev->dev); - if (plat->phy_interface < 0) + if ((int)plat->phy_interface < 0) return ERR_PTR(plat->phy_interface); plat->interface = stmmac_of_get_mac_mode(np); -- 2.17.1