Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Alex Dewar <alex.dewar90@gmail.com>
Date:   Tue, 18 Aug 2020 16:06:56 +0100
To:     Randy Dunlap <rdunlap@infradead.org>
Cc:     Alex Dewar <alex.dewar90@gmail.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Saiyam Doshi <saiyamdoshi.in@gmail.com>,
        devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: emxx_udc: Use standard BIT() macro
Message-ID: <20200818150656.4ikg6fwzmmnwqapx@medion>
References: <20200818134922.409195-1-alex.dewar90@gmail.com>
 <baecb36e-1f82-1e0e-6460-d6759a9193c1@infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <baecb36e-1f82-1e0e-6460-d6759a9193c1@infradead.org>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Aug 18, 2020 at 07:29:02AM -0700, Randy Dunlap wrote:
> On 8/18/20 6:49 AM, Alex Dewar wrote:
> > Currently emxx_udc.h defines bit values using local macros. Use the
> > standard one instead.
> > 
> > Also, combine bit values with bitwise-or rather than addition, as
> > suggested by Coccinelle.
> > 
> > Signed-off-by: Alex Dewar <alex.dewar90@gmail.com>
> 
> Hi,
> 
> Does this build?  Just checking.
> 
> Looks like it would need this:
> 
> #include <linux/bits.h>
> 
> since it (indirectly) provides definition of the BIT() macro.

Yeah, it builds, because emxx_udc.c includes emxx_udc.h after a bunch of
standard headers. I agree that it would probably be cleaner to have the
include in there explicitly, though.

Best,
Alex

> 
> > ---
> >  drivers/staging/emxx_udc/emxx_udc.h | 456 +++++++++++++---------------
> >  1 file changed, 211 insertions(+), 245 deletions(-)
> 
> 
> thanks.
> -- 
> ~Randy
>